From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE15B10E33F for ; Wed, 5 Jul 2023 09:20:20 +0000 (UTC) Message-ID: Date: Wed, 5 Jul 2023 14:49:51 +0530 To: Anshuman Gupta , References: <20230628112621.4084988-1-anshuman.gupta@intel.com> <20230628112621.4084988-3-anshuman.gupta@intel.com> Content-Language: en-US From: Riana Tauro In-Reply-To: <20230628112621.4084988-3-anshuman.gupta@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v2 2/2] test/xe_pm: Add vram_d3cold_threshold subtest List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: badal.nilawar@intel.com Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Hi Anshuman On 6/28/2023 4:56 PM, Anshuman Gupta wrote: > Adding a vram_d3cold_threshold subtest, which creates a Xe bo and > set the vram_d3cold_threshold according to vram used and bo size. > Test setups the d3cold and expect card to be limited to d3hot. > > v2: > - Add subtest doc. > > Signed-off-by: Anshuman Gupta > --- > tests/xe/xe_pm.c | 80 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 80 insertions(+) > > diff --git a/tests/xe/xe_pm.c b/tests/xe/xe_pm.c > index c71fce892..eaafead23 100644 > --- a/tests/xe/xe_pm.c > +++ b/tests/xe/xe_pm.c > @@ -19,6 +19,7 @@ > #include "igt.h" > #include "lib/igt_device.h" > #include "lib/igt_pm.h" > +#include "lib/igt_sysfs.h" > #include "lib/igt_syncobj.h" > #include "lib/intel_reg.h" > > @@ -30,6 +31,8 @@ > #define NO_SUSPEND -1 > #define NO_RPM -1 > > +#define SIZE (4096 * 1024) > + > typedef struct { > int fd_xe; > struct pci_device *pci_xe; > @@ -77,6 +80,22 @@ static void set_d3cold_allowed(struct pci_device *pci, > close(fd); > } > > +static void set_vram_d3cold_threshold(int sysfs, uint64_t threshold) > +{ > + char path[64]; > + int ret; > + > + sprintf(path, "device/vram_d3cold_threshold"); > + > + if (!faccessat(sysfs, path, R_OK | W_OK, 0)) > + ret = igt_sysfs_printf(sysfs, path, "%lu", threshold); > + else > + igt_warn("vram_d3cold_threshold is not present\n"); > + > + igt_info("ret value %d", ret); > + igt_assert(ret > 0); > +} > + > static bool setup_d3(device_t device, enum igt_acpi_d_state state) > { > switch (state) { > @@ -359,6 +378,62 @@ NULL)); > igt_assert(in_d3(device, d_state)); > } > > +/** > + * SUBTEST: vram_d3cold_threshold Subtest: vram-d3cold-threshold > + * Description: > + * Validate whether card is limited to d3hot while vram used > + * is greater than vram_d3cold_threshol_d3cold. s/vram_d3cold_threshol_d3cold/vram_d3cold_threshold > + * Run type: FULL > + */ > +static void test_vram_d3cold_threshold(device_t device) > +{ > + struct drm_xe_query_mem_usage *mem_usage; > + struct drm_xe_device_query query = { > + .extensions = 0, > + .query = DRM_XE_DEVICE_QUERY_MEM_USAGE, > + .size = 0, > + .data = 0, > + }; > + uint64_t vram_used_mb = 0, vram_total_mb = 0, threshold, mmo; > + uint32_t bo; > + void *map; > + int i, sysfs_fd; > + > + igt_assert_eq(igt_ioctl(device.fd_xe, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0); > + igt_assert_neq(query.size, 0); > + > + mem_usage = malloc(query.size); > + igt_assert(mem_usage); > + > + query.data = to_user_pointer(mem_usage); > + igt_assert_eq(igt_ioctl(device.fd_xe, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0); > + > + for (i = 0; i < mem_usage->num_regions; i++) { > + if (mem_usage->regions[i].mem_class == XE_MEM_REGION_CLASS_VRAM) { > + vram_used_mb += (mem_usage->regions[i].used / (1024 * 1024)); > + vram_total_mb += (mem_usage->regions[i].total_size / (1024 * 1024)); > + } > + } > + > + bo = xe_bo_create_flags(device.fd_xe, 0, SIZE, vram_memory(device.fd_xe, 0)); It will fail on assert of ioctl if vram is not present. Should this test be skipped if !xe_has_vram > + mmo = xe_bo_mmap_offset(device.fd_xe, bo); > + map = mmap(NULL, SIZE, PROT_WRITE, MAP_SHARED, device.fd_xe, mmo); > + igt_assert(map != MAP_FAILED); Replace with xe_bo_map call > + > + memset(map, 0, SIZE); > + munmap(map, SIZE); > + threshold = vram_used_mb + (SIZE / (1024 * 1024));threshold should be set to vram_used_mb > + igt_require(threshold < vram_total_mb); > + sysfs_fd = igt_sysfs_open(device.fd_xe); > + set_vram_d3cold_threshold(sysfs_fd, threshold); > + close(sysfs_fd); > + > + /* Setup D3Cold but card should be in D0 */ s/D0/D3hot > + igt_assert(setup_d3(device, IGT_ACPI_D3Cold)); > + igt_assert(in_d3(device, IGT_ACPI_D3Hot)); > + igt_assert(out_of_d3(device, IGT_ACPI_D3Cold)); Release gem_close(fd, bo); Thanks Riana > +} > + > igt_main > { > struct drm_xe_engine_class_instance *hwe; > @@ -456,6 +531,11 @@ igt_main > } > } > > + igt_describe("Validate whether card is limited to d3hot, if vram used > vram threshold"); > + igt_subtest("vram-d3cold-threshold") { > + test_vram_d3cold_threshold(device); > + } > + > igt_fixture { > display_fini(&device); > set_d3cold_allowed(device.pci_xe, d3cold_allowed);