From: Jani Nikula <jani.nikula@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com
Subject: Re: [PATCH i-g-t 05/10] tests/kms_cursor_edge_walk: use CRTC indexes instead of pipes for CRTC tracking
Date: Mon, 09 Mar 2026 16:25:02 +0200 [thread overview]
Message-ID: <e93bb7158f8d7bd6b2a2247c82306aeff8e528f7@intel.com> (raw)
In-Reply-To: <c95cad26d78f52c2102a9bdedeb4062af5257f21.1773066012.git.jani.nikula@intel.com>
On Mon, 09 Mar 2026, Jani Nikula <jani.nikula@intel.com> wrote:
> The test tracks "active" CRTCs in a dedicated array. This does not
> depend on pipes in any way. Switch to using CRTC indexes instead.
Apparently copy-pasted some tabs here and other commit messages
accidentally.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> tests/kms_cursor_edge_walk.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tests/kms_cursor_edge_walk.c b/tests/kms_cursor_edge_walk.c
> index 08c9de601ce3..8036d43d5eef 100644
> --- a/tests/kms_cursor_edge_walk.c
> +++ b/tests/kms_cursor_edge_walk.c
> @@ -87,8 +87,8 @@ enum {
> };
>
> static bool extended;
> -static enum pipe active_pipes[IGT_MAX_PIPES];
> -static uint32_t last_pipe;
> +static int active_crtcs[IGT_MAX_PIPES];
> +static uint32_t last_crtc_index;
>
> static void create_cursor_fb(data_t *data, int cur_w, int cur_h)
> {
> @@ -377,10 +377,10 @@ int igt_main_args("", long_opts, help_str, opt_handler, &data)
> kmstest_set_vt_graphics_mode();
>
> /* Get active pipes. */
> - last_pipe = 0;
> + last_crtc_index = 0;
> for_each_crtc(&data.display, crtc)
> - active_pipes[last_pipe++] = crtc->pipe;
> - last_pipe--;
> + active_crtcs[last_crtc_index++] = crtc->crtc_index;
> + last_crtc_index--;
> }
>
> for (i = 0; i < ARRAY_SIZE(tests); i++) {
> @@ -397,8 +397,8 @@ int igt_main_args("", long_opts, help_str, opt_handler, &data)
> crtc,
> data.output) {
> data.crtc = crtc;
> - if (!extended && crtc->pipe != active_pipes[0] &&
> - crtc->pipe != active_pipes[last_pipe])
> + if (!extended && crtc->crtc_index != active_crtcs[0] &&
> + crtc->crtc_index != active_crtcs[last_crtc_index])
> continue;
>
> igt_display_reset(&data.display);
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-03-09 14:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 14:21 [PATCH i-g-t 00/10] tests: avoid using crtc->pipe where possible Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 01/10] tests/kms_writeback: use igt_crtc_name() Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 02/10] tests/kms_colorop: " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 03/10] tests/kms_color_pipeline: " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 04/10] tests/kms_cursor_crc: use CRTC indexes instead of pipes for CRTC tracking Jani Nikula
2026-03-10 10:05 ` Ville Syrjälä
2026-03-10 10:52 ` Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 05/10] tests/kms_cursor_edge_walk: " Jani Nikula
2026-03-09 14:25 ` Jani Nikula [this message]
2026-03-09 14:21 ` [PATCH i-g-t 06/10] tests/kms_pipe_crc_basic: " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 07/10] tests/kms_plane_alpha_blend: " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 08/10] tests/kms_vblank: " Jani Nikula
2026-03-09 14:25 ` Jani Nikula
2026-03-09 16:48 ` [PATCH i-g-t v2] " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 09/10] tests/kms_cursor_legacy: " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 10/10] tests/kms_debugfs: use CRTC indexes instead of pipes for fb tracking Jani Nikula
2026-03-10 10:08 ` Ville Syrjälä
2026-03-09 23:58 ` ✓ i915.CI.BAT: success for tests: avoid using crtc->pipe where possible (rev2) Patchwork
2026-03-10 0:04 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-10 5:31 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-10 9:03 ` ✗ i915.CI.Full: " Patchwork
2026-03-10 10:20 ` [PATCH i-g-t 00/10] tests: avoid using crtc->pipe where possible Ville Syrjälä
2026-03-10 11:24 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e93bb7158f8d7bd6b2a2247c82306aeff8e528f7@intel.com \
--to=jani.nikula@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox