Re: [PATCH i-g-t v2 2/3] tests/intel/xe_ccs: require flat CCS on xe2

["Jahagirdar, Akshata" <akshata.jahagirdar@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]


On 2/1/2024 11:31 PM, Zbigniew Kempczyński wrote:
> On Thu, Feb 01, 2024 at 09:34:27PM -0800, Jahagirdar, Akshata wrote:
>   
>>   +
>>           if (config->compression && !blt_block_copy_supports_compression(xe))
>>                   return;
>>
>>   This will check compression either, but indirectly via .cmds_info
>>   set to xe2_cmds_info in which we use BLT_CMD_SUPPORTS_COMPRESSION
>>   flag for block-copy command.
>>
>>     on a side note, IIUC the BLT_CMD_SUPPORTS_COMPRESSION flag doesn't make
>>     sense anymore due to xe2+ unified compression?
>
> Please fix your email client, it's hard to extract the answer.
>
> Regarding above - may you elaborate?
>
> --
> Zbigniew
Hi, sorry about that. not sure why it didn't quote properly before. Hope 
it is fixed now.

So, regarding my previous comment, The BLT_CMD_SUPPORTS_COMPRESSION flag 
checks if the "block-copy command" supports compression or not.

However, due to the unified compression in xe2+, we don't need to use 
specific blitter commands to use compression any more.

So, i wanted to say that this flag checking compression support doesn't 
make sense anymore for xe2, but I understand it would be different based 
on platform specific .cmds_info.

I didn't check it properly before.

So anyway: Reviewed-by: Akshata Jahagirdar <akshata.jahagirdar@intel.com>

-Akshata
>>     - Akshata
>>
>>   Do we have any Xe2 without compression on block-copy?
>>
>>   --
>>   Zbigniew
>>
>>
>>   
>>   --
>>   2.43.0

[-- Attachment #2: Type: text/html, Size: 3405 bytes --]