From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: Date: Mon, 15 May 2023 12:10:43 +0100 MIME-Version: 1.0 Content-Language: en-US To: Rob Clark References: <20230131113237.3707217-1-tvrtko.ursulin@linux.intel.com> <20230131113237.3707217-9-tvrtko.ursulin@linux.intel.com> From: Tvrtko Ursulin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [igt-dev] [PATCH i-g-t 8/8] gputop: Basic vendor agnostic GPU top tool List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin , =?UTF-8?Q?Christian_K=c3=b6nig?= , Intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org, =?UTF-8?Q?Christian_K=c3=b6nig?= Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 12/05/2023 15:18, Rob Clark wrote: > On Thu, Apr 6, 2023 at 7:33 AM Tvrtko Ursulin > wrote: >> >> >> On 06/04/2023 15:21, Rob Clark wrote: >>> On Thu, Apr 6, 2023 at 4:08 AM Tvrtko Ursulin >>> wrote: >>>> >>>> >>>> On 05/04/2023 18:57, Rob Clark wrote: >>>>> On Tue, Jan 31, 2023 at 3:33 AM Tvrtko Ursulin >>>>> wrote: >>>>>> >>>>>> From: Tvrtko Ursulin >>>>>> >>>>>> Rudimentary vendor agnostic example of how lib_igt_drm_clients can be used >>>>>> to display a sorted by card and usage list of processes using GPUs. >>>>>> >>>>>> Borrows a bit of code from intel_gpu_top but for now omits the fancy >>>>>> features like interactive functionality, card selection, client >>>>>> aggregation, sort modes, JSON output and pretty engine names. Also no >>>>>> support for global GPU or system metrics. >>>>>> >>>>>> On the other hand it shows clients from all DRM cards which >>>>>> intel_gpu_top does not do. >>>>>> >>>>>> Signed-off-by: Tvrtko Ursulin >>>>>> Cc: Rob Clark >>>>>> Cc: Christian König >>>>>> Acked-by: Christian König >>>>> >>>>> Reviewed-by: Rob Clark >>>> >>>> Presumably for 8/8 only? >>>> >>>> The rest of the series does not apply any more by now. I need to rebase.. >>> >>> I didn't look closely at the rest of the series (was kinda assuming >>> that was mostly just moving things around).. but I see you rebased it >>> so I can take a look. >> >> There's a lot in there - first patch is extracting some code into a >> library, with the corresponding renames, but then there are six patches >> of tweaks and feature additions which finally make gputop possible. >> >> Hopefully you can penetrate the concepts. It was all at least Valgrind >> clean back in the day I first did it. >> > > by now I've read (and rebased locally) the series, and even added a > couple things on top.. so r-b for the series, we should get this > landed Thanks for the reviews, pushed! Lets see if the future holds for this small tool. Regards, Tvrtko