From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95A6710E3B2 for ; Wed, 14 Sep 2022 04:54:14 +0000 (UTC) Message-ID: Date: Wed, 14 Sep 2022 10:23:57 +0530 Content-Language: en-US To: Bhanuprakash Modem , References: <20220909140331.1041095-1-bhanuprakash.modem@intel.com> <20220909140331.1041095-27-bhanuprakash.modem@intel.com> From: Karthik B S In-Reply-To: <20220909140331.1041095-27-bhanuprakash.modem@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [i-g-t V3 26/52] tests/kms_plane_multiple: Add support for Bigjoiner List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 9/9/2022 7:33 PM, Bhanuprakash Modem wrote: > This patch will add a check to Skip the subtest if a selected pipe/output > combo won't support Bigjoiner or 8K mode. > > Example: > * Pipe-D wont support a mode > 5K > * To use 8K mode on a pipe then consecutive pipe must be available & free. > > V2: - Use updated helper name > > Signed-off-by: Bhanuprakash Modem Reviewed-by: Karthik B S > --- > tests/kms_plane_multiple.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c > index cbe8c189..4ab49624 100644 > --- a/tests/kms_plane_multiple.c > +++ b/tests/kms_plane_multiple.c > @@ -102,6 +102,7 @@ get_reference_crc(data_t *data, igt_output_t *output, enum pipe pipe, > igt_plane_t *primary; > int ret; > > + igt_display_reset(&data->display); > igt_output_set_pipe(output, pipe); > > primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); > @@ -289,6 +290,9 @@ test_plane_position_with_output(data_t *data, enum pipe pipe, > bool loop_forever; > char info[256]; > > + igt_info("Using (pipe %s + %s) to run the subtest.\n", > + kmstest_pipe_name(pipe), igt_output_name(output)); > + > if (opt.iterations == LOOP_FOREVER) { > loop_forever = true; > sprintf(info, "forever"); > @@ -374,12 +378,17 @@ static void run_test(data_t *data, uint64_t modifier) > { > enum pipe pipe; > igt_output_t *output; > + igt_display_t *display = &data->display; > > - if (!igt_display_has_format_mod(&data->display, DRM_FORMAT_XRGB8888, modifier)) > + if (!igt_display_has_format_mod(display, DRM_FORMAT_XRGB8888, modifier)) > return; > > - for_each_pipe_with_valid_output(&data->display, pipe, output) { > - igt_display_reset(&data->display); > + for_each_pipe_with_valid_output(display, pipe, output) { > + igt_display_reset(display); > + > + igt_output_set_pipe(output, pipe); > + if (!i915_pipe_output_combo_valid(display)) > + continue; > > igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name) > test_plane_position(data, pipe, output, modifier);