Re: [PATCH 2/2] lib/intel_chipset: add Battlemage support

[Matthew Auld <matthew.auld@intel.com>]

On 17/06/2024 08:51, Andrzej Hajda wrote:
> Add basic definition for the Battlemage platform.
> Follow Lunar Lake convention.
> 
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>

Reviewed-by: Matthew Auld <matthew.auld@intel.com>

> ---
>   lib/intel_chipset.h     |  2 ++
>   lib/intel_device_info.c | 12 ++++++++++++
>   2 files changed, 14 insertions(+)
> 
> diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
> index 3f25345199b6..270392c83c2a 100644
> --- a/lib/intel_chipset.h
> +++ b/lib/intel_chipset.h
> @@ -91,6 +91,7 @@ struct intel_device_info {
>   	bool is_meteorlake : 1;
>   	bool is_pontevecchio : 1;
>   	bool is_lunarlake : 1;
> +	bool is_battlemage : 1;
>   	const struct intel_cmds_info *cmds_info;
>   	const char *codename;
>   };
> @@ -205,6 +206,7 @@ void intel_check_pch(void);
>   #define IS_METEORLAKE(devid)	(intel_get_device_info(devid)->is_meteorlake)
>   #define IS_PONTEVECCHIO(devid)	(intel_get_device_info(devid)->is_pontevecchio)
>   #define IS_LUNARLAKE(devid)	(intel_get_device_info(devid)->is_lunarlake)
> +#define IS_BATTLEMAGE(devid)	(intel_get_device_info(devid)->is_battlemage)
>   
>   #define IS_GEN(devid, x)	(intel_get_device_info(devid)->graphics_ver == x)
>   #define AT_LEAST_GEN(devid, x)	(intel_get_device_info(devid)->graphics_ver >= x)
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index e80ea54707de..9250abd444db 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -515,6 +515,16 @@ static const struct intel_device_info intel_lunarlake_info = {
>   	.cmds_info = &xe2_cmds_info,
>   };
>   
> +static const struct intel_device_info intel_battlemage_info = {
> +	.graphics_ver = 20,
> +	.graphics_rel = 1,
> +	.display_ver = 14,
> +	.has_4tile = true,
> +	.has_flatccs = true,
> +	.is_battlemage = true,
> +	.codename = "battlemage"
> +};
> +
>   static const struct pci_id_match intel_device_match[] = {
>   	INTEL_I810_IDS(INTEL_VGA_DEVICE, &intel_i810_info),
>   	INTEL_I815_IDS(INTEL_VGA_DEVICE, &intel_i815_info),
> @@ -621,6 +631,8 @@ static const struct pci_id_match intel_device_match[] = {
>   
>   	XE_LNL_IDS(INTEL_VGA_DEVICE, &intel_lunarlake_info),
>   
> +	XE_BMG_IDS(INTEL_VGA_DEVICE, &intel_battlemage_info),
> +
>   	INTEL_VGA_DEVICE(PCI_MATCH_ANY, &intel_generic_info),
>   };
>   
>