From: Jani Nikula <jani.nikula@intel.com>
To: Ashutosh Dixit <ashutosh.dixit@intel.com>, igt-dev@lists.freedesktop.org
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Zbigniew Kempczynski <zbigniew.kempczynski@intel.com>,
janusz.krzysztofik@linux.intel.com, lukasz.laguna@intel.com
Subject: Re: [PATCH i-g-t v2] lib/intel_chipset: Extend intel_get_pci_device to PCI accelerator class
Date: Tue, 16 Jun 2026 10:43:37 +0300 [thread overview]
Message-ID: <eb8c32f281d9f975ffadd4a2d4a0e03f750780b8@intel.com> (raw)
In-Reply-To: <20260615204723.18187-1-ashutosh.dixit@intel.com>
On Mon, 15 Jun 2026, Ashutosh Dixit <ashutosh.dixit@intel.com> wrote:
> +/**
> + * intel_get_pci_device_disp:
> + *
> + * Looks up display class pci device using libpciaccess
> + *
> + * Returns: The pci_device, exits the program on any failures
> + */
> +struct pci_device *intel_get_pci_device_disp(void)
> +{
> + return __intel_get_pci_device(false);
> +}
Nitpick, can we please not use "disp" as an abbreviation for "display",
especially in fairly fundamental function names?
It does not abbreviate enough to be useful. Please just use the whole
word.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-06-16 7:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 20:47 [PATCH i-g-t v2] lib/intel_chipset: Extend intel_get_pci_device to PCI accelerator class Ashutosh Dixit
2026-06-16 0:02 ` ✓ i915.CI.BAT: success for lib/intel_chipset: Extend intel_get_pci_device to PCI accelerator class (rev3) Patchwork
2026-06-16 0:13 ` ✓ Xe.CI.BAT: " Patchwork
2026-06-16 2:51 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-06-16 7:43 ` Jani Nikula [this message]
2026-06-16 12:03 ` ✓ i915.CI.Full: success " Patchwork
2026-06-16 15:15 ` [PATCH i-g-t v2] lib/intel_chipset: Extend intel_get_pci_device to PCI accelerator class Kamil Konieczny
2026-06-16 16:35 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb8c32f281d9f975ffadd4a2d4a0e03f750780b8@intel.com \
--to=jani.nikula@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=janusz.krzysztofik@linux.intel.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=lukasz.laguna@intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox