From: "Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>
To: Swati Sharma <swati2.sharma@intel.com>, <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_lease: rename subtests
Date: Tue, 26 Sep 2023 22:15:58 +0530 [thread overview]
Message-ID: <ebe34945-129d-0730-bf50-7924a3b63690@intel.com> (raw)
In-Reply-To: <20230918112216.260019-3-swati2.sharma@intel.com>
On Mon-18-09-2023 04:52 pm, Swati Sharma wrote:
> Use '-' instead of '_' while naming subtests.
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
> tests/kms_lease.c | 62 +++++++++++++++++++++++------------------------
> 1 file changed, 31 insertions(+), 31 deletions(-)
>
> diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> index 1a91b3eb4..343cdb812 100644
> --- a/tests/kms_lease.c
> +++ b/tests/kms_lease.c
> @@ -46,21 +46,21 @@
> #include "igt_device.h"
>
> /**
> - * SUBTEST: atomic_implicit_crtc
> + * SUBTEST: atomic-implicit-crtc
> * Description: Negative test by using a different crtc with atomic ioctl
> * Driver requirement: i915, xe
> * Functionality: lease
> * Mega feature: General Display Features
> * Test category: functionality test
> *
> - * SUBTEST: cursor_implicit_plane
> + * SUBTEST: cursor-implicit-plane
> * Description: Negative test by using a non-primary plane with setcursor ioctl
> * Driver requirement: i915, xe
> * Functionality: lease
> * Mega feature: General Display Features
> * Test category: functionality test
> *
> - * SUBTEST: empty_lease
> + * SUBTEST: empty-lease
> * Description: Check that creating an empty lease works
> * Driver requirement: i915, xe
> * Functionality: lease
> @@ -89,63 +89,63 @@
> * Mega feature: General Display Features
> * Test category: functionality test
> *
> - * SUBTEST: lease_again
> + * SUBTEST: lease-again
> * Description: Tests leasing objects more than once
> * Driver requirement: i915, xe
> * Functionality: lease
> * Mega feature: General Display Features
> * Test category: functionality test
> *
> - * SUBTEST: lease_get
> + * SUBTEST: lease-get
> * Description: Tests getting the required contents of a lease
> * Driver requirement: i915, xe
> * Functionality: lease
> * Mega feature: General Display Features
> * Test category: functionality test
> *
> - * SUBTEST: lease_invalid_connector
> + * SUBTEST: lease-invalid-connector
> * Description: Tests leasing an invalid connector
> * Driver requirement: i915, xe
> * Functionality: lease
> * Mega feature: General Display Features
> * Test category: functionality test
> *
> - * SUBTEST: lease_invalid_crtc
> + * SUBTEST: lease-invalid-crtc
> * Description: Tests leasing an invalid crtc
> * Driver requirement: i915, xe
> * Functionality: lease
> * Mega feature: General Display Features
> * Test category: functionality test
> *
> - * SUBTEST: lease_invalid_plane
> + * SUBTEST: lease-invalid-plane
> * Description: Tests leasing an invalid plane
> * Driver requirement: i915, xe
> * Functionality: lease
> * Mega feature: General Display Features
> * Test category: functionality test
> *
> - * SUBTEST: lease_revoke
> + * SUBTEST: lease-revoke
> * Description: Tests revocation of lease
> * Driver requirement: i915, xe
> * Functionality: lease
> * Mega feature: General Display Features
> * Test category: functionality test
> *
> - * SUBTEST: lease_unleased_connector
> + * SUBTEST: lease-unleased-connector
> * Description: Negative test by trying to use an unleased connector
> * Driver requirement: i915, xe
> * Functionality: lease
> * Mega feature: General Display Features
> * Test category: functionality test
> *
> - * SUBTEST: lease_unleased_crtc
> + * SUBTEST: lease-unleased-crtc
> * Description: Negative test by trying to use an unleased crtc
> * Driver requirement: i915, xe
> * Functionality: lease
> * Mega feature: General Display Features
> * Test category: functionality test
> *
> - * SUBTEST: lessee_list
> + * SUBTEST: lessee-list
> * Description: Check if listed lease is same as created one
> * Driver requirement: i915, xe
> * Functionality: lease
> @@ -168,7 +168,7 @@
> * Mega feature: General Display Features
> * Test category: functionality test
> *
> - * SUBTEST: page_flip_implicit_plane
> + * SUBTEST: page-flip-implicit-plane
> * Description: Negative test by using a non-primary plane with the page flip ioctl
> * Driver requirement: i915, xe
> * Functionality: lease
> @@ -184,14 +184,14 @@
> * Mega feature: General Display Features
> * Test category: functionality test
> *
> - * SUBTEST: setcrtc_implicit_plane
> + * SUBTEST: setcrtc-implicit-plane
> * Description: Negative test by using a non-primary plane with the setcrtc ioctl
> * Driver requirement: i915, xe
> * Functionality: lease
> * Mega feature: General Display Features
> * Test category: functionality test
> *
> - * SUBTEST: simple_lease
> + * SUBTEST: simple-lease
> * Description: Check if create lease ioctl call works
> * Driver requirement: i915, xe
> * Functionality: lease
> @@ -381,7 +381,7 @@ static void simple_lease(data_t *data)
> igt_assert_eq(0, prepare_crtc(&lease, data));
>
> /* Paint something attractive */
> - paint_fb(lease.fd, &lease.primary_fb, "simple_lease",
> + paint_fb(lease.fd, &lease.primary_fb, "simple-lease",
> lease.mode->name, igt_output_name(lease.output), kmstest_pipe_name(pipe));
> igt_debug_wait_for_keypress("lease");
> cleanup_crtc(&lease,
> @@ -1347,25 +1347,25 @@ igt_main
> void (*func)(data_t *);
> const char *desc;
> } funcs[] = {
> - { "simple_lease", simple_lease, "Check if create lease ioctl call works" },
> - { "empty_lease", empty_lease, "Check that creating an empty lease works" },
> - { "lessee_list", lessee_list, "Check if listed lease is same as created one" },
> - { "lease_get", lease_get, "Tests getting the required contents of a lease" },
> - { "lease_unleased_connector", lease_unleased_connector, "Negative test by trying to"
> + { "simple-lease", simple_lease, "Check if create lease ioctl call works" },
> + { "empty-lease", empty_lease, "Check that creating an empty lease works" },
> + { "lessee-list", lessee_list, "Check if listed lease is same as created one" },
> + { "lease-get", lease_get, "Tests getting the required contents of a lease" },
> + { "lease-unleased-connector", lease_unleased_connector, "Negative test by trying to"
> " use an unleased connector " },
> - { "lease_unleased_crtc", lease_unleased_crtc, "Negative test by trying to use an unleased crtc" },
> - { "lease_revoke", lease_revoke, "Tests revocation of lease" },
> - { "lease_again", lease_again, "Tests leasing objects more than once" },
> - { "lease_invalid_connector", lease_invalid_connector, "Tests leasing an invalid connector" },
> - { "lease_invalid_crtc", lease_invalid_crtc, "Tests leasing an invalid crtc" },
> - { "lease_invalid_plane", lease_invalid_plane, "Tests leasing an invalid plane" },
> - { "page_flip_implicit_plane", page_flip_implicit_plane, "Negative test by using a "
> + { "lease-unleased-crtc", lease_unleased_crtc, "Negative test by trying to use an unleased crtc" },
> + { "lease-revoke", lease_revoke, "Tests revocation of lease" },
> + { "lease-again", lease_again, "Tests leasing objects more than once" },
> + { "lease-invalid-connector", lease_invalid_connector, "Tests leasing an invalid connector" },
> + { "lease-invalid-crtc", lease_invalid_crtc, "Tests leasing an invalid crtc" },
> + { "lease-invalid-plane", lease_invalid_plane, "Tests leasing an invalid plane" },
> + { "page-flip-implicit-plane", page_flip_implicit_plane, "Negative test by using a "
> "non-primary plane with the page flip ioctl" },
> - { "setcrtc_implicit_plane", setcrtc_implicit_plane, "Negative test by using a "
> + { "setcrtc-implicit-plane", setcrtc_implicit_plane, "Negative test by using a "
> "non-primary plane with the setcrtc ioctl" },
> - { "cursor_implicit_plane", cursor_implicit_plane, "Negative test by using a non-primary"
> + { "cursor-implicit-plane", cursor_implicit_plane, "Negative test by using a non-primary"
> " plane with setcursor ioctl" },
> - { "atomic_implicit_crtc", atomic_implicit_crtc, "Negative test by using a different"
> + { "atomic-implicit-crtc", atomic_implicit_crtc, "Negative test by using a different"
> " crtc with atomic ioctl" },
> { }
> }, *f;
next prev parent reply other threads:[~2023-09-26 16:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 11:22 [igt-dev] [PATCH i-g-t 0/2] tests/kms_lease: Test rename Swati Sharma
2023-09-18 11:22 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_lease: remove redundant test doc Swati Sharma
2023-09-27 3:23 ` Karthik B S
2023-09-18 11:22 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_lease: rename subtests Swati Sharma
2023-09-26 16:45 ` Modem, Bhanuprakash [this message]
2023-09-18 19:05 ` [igt-dev] ✓ CI.xeBAT: success for tests/kms_lease: Test rename Patchwork
2023-09-18 19:09 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-09-19 22:38 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-21 6:00 ` Patchwork
2023-09-21 6:20 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebe34945-129d-0730-bf50-7924a3b63690@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox