Re: [PATCH i-g-t v2 05/16] tests/kms_frontbuffer_tracking: remove TEST_MODE_ITER_BEGIN() from `suspend`

["Thasleem, Mohammed" <mohammed.thasleem@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2048 bytes --]


On 08-08-2026 04:17 am, Michał Grzelak wrote:
> igt@kms_frontbuffer_tracking uses TEST_MODE_ITER_BEGIN(t) which consists
> of nested for loops. However many loops can be omitted due to continue
> statements. This obfuscates following the execution of any given
> codepath. Replace TEST_MODE_ITER_BEGIN(t) for fliptrack tests with macro
> definition and remove loops that are skipped.
>
> v1->v2
> - remove blank line (Mohammed)
>
> Signed-off-by: Michał Grzelak<michal.grzelak@intel.com>

LGTM:

Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>

> ---
>   tests/intel/kms_frontbuffer_tracking.c | 21 ++++++++++++++-------
>   1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
> index c2130d76a2..406018c88a 100644
> --- a/tests/intel/kms_frontbuffer_tracking.c
> +++ b/tests/intel/kms_frontbuffer_tracking.c
> @@ -4626,12 +4626,19 @@ int igt_main_args("", long_options, help_str, opt_handler, NULL)
>   		}
>   	TEST_MODE_ITER_END
>   
> -	TEST_MODE_ITER_BEGIN(t)
> -		if (t.pipes != PIPE_SINGLE ||
> -		    t.screen != SCREEN_PRIM ||
> -		    t.plane != PLANE_PRI ||
> -		    t.fbs != FBS_INDIVIDUAL ||
> -		    t.method != IGT_DRAW_BLT)
> +	t.format = FORMAT_DEFAULT;
> +	t.flip = FLIP_PAGEFLIP;
> +	t.tiling = opt.tiling;
> +	t.pipes = PIPE_SINGLE;
> +	t.screen = SCREEN_PRIM;
> +	t.plane = PLANE_PRI;
> +	t.fbs = FBS_INDIVIDUAL;
> +	t.method = IGT_DRAW_BLT;
> +
> +	for (t.feature = 0; t.feature < FEATURE_COUNT; t.feature++) {
> +		if (!opt.show_hidden && t.feature == FEATURE_NONE)
> +			continue;
> +		if ((t.feature & FEATURE_PSR) && (t.feature & FEATURE_DRRS))
>   			continue;
>   
>   		igt_subtest_f("%s-modesetfrombusy", feature_str(t.feature))
> @@ -4692,7 +4699,7 @@ int igt_main_args("", long_options, help_str, opt_handler, NULL)
>   			igt_require(igt_draw_supports_method(drm.fd, t.method));
>   			suspend_subtest(&t);
>   		}
> -	TEST_MODE_ITER_END
> +	}
>   
>   	t.pipes = PIPE_SINGLE;
>   	t.screen = SCREEN_PRIM;

[-- Attachment #2: Type: text/html, Size: 37920 bytes --]