Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
	<igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 3/4] lib/igt_fb: fix tiling and blitter to require intel instead of i915 device
Date: Thu, 29 Jun 2023 10:43:31 +0530	[thread overview]
Message-ID: <ec1b8723-65eb-ad56-8f27-39c3313b72fe@intel.com> (raw)
In-Reply-To: <20230628175830.12504-4-juhapekka.heikkila@gmail.com>


On Wed-28-06-2023 11:28 pm, Juha-Pekka Heikkila wrote:
> As per introduction of xe driver change device requirements when
> using blitter or x- or 4-tile.
> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

> ---
>   lib/igt_fb.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 597f926d9..c1029246e 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -447,7 +447,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
>   		*height_ret = 1;
>   		break;
>   	case I915_FORMAT_MOD_X_TILED:
> -		igt_require_i915(fd);
> +		igt_require_intel(fd);
>   		if (intel_display_ver(intel_get_drm_devid(fd)) == 2) {
>   			*width_ret = 128;
>   			*height_ret = 16;
> @@ -468,7 +468,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
>   	case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS:
>   	case I915_FORMAT_MOD_4_TILED_DG2_MC_CCS:
>   	case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC:
> -		igt_require_i915(fd);
> +		igt_require_intel(fd);
>   		if (intel_display_ver(intel_get_drm_devid(fd)) == 2) {
>   			*width_ret = 128;
>   			*height_ret = 16;
> @@ -2490,7 +2490,7 @@ static bool block_copy_ok(const struct igt_fb *fb)
>   
>   static bool blitter_ok(const struct igt_fb *fb)
>   {
> -	if (!is_i915_device(fb->fd))
> +	if (!is_intel_device(fb->fd))
>   		return false;
>   
>   	if ((is_ccs_modifier(fb->modifier) &&

  reply	other threads:[~2023-06-29  5:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-28 17:58 [igt-dev] [PATCH i-g-t 0/4] Include intel_blt funtions to blitter path for igt_fb.c Juha-Pekka Heikkila
2023-06-28 17:58 ` [igt-dev] [PATCH i-g-t 1/4] lib/intel_blt: Add offset to block and fast copy Juha-Pekka Heikkila
2023-06-28 17:58 ` [igt-dev] [PATCH i-g-t 2/4] lib/igt_fb: include lib/intel_blt functions to blitter path Juha-Pekka Heikkila
2023-06-29  5:14   ` Modem, Bhanuprakash
2023-06-28 17:58 ` [igt-dev] [PATCH i-g-t 3/4] lib/igt_fb: fix tiling and blitter to require intel instead of i915 device Juha-Pekka Heikkila
2023-06-29  5:13   ` Modem, Bhanuprakash [this message]
2023-06-28 17:58 ` [igt-dev] [PATCH i-g-t 4/4] lib/igt_fb: On blitter path take clear color modifier into account Juha-Pekka Heikkila
2023-06-28 18:38 ` [igt-dev] ✗ GitLab.Pipeline: warning for Include intel_blt funtions to blitter path for igt_fb.c (rev3) Patchwork
2023-06-28 21:30 ` [igt-dev] ✓ Fi.CI.BAT: success for Include intel_blt funtions to blitter path for igt_fb.c (rev4) Patchwork
2023-06-29 12:47 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec1b8723-65eb-ad56-8f27-39c3313b72fe@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juhapekka.heikkila@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox