From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id C315D10E5C9 for ; Thu, 31 Aug 2023 08:52:19 +0000 (UTC) Message-ID: Date: Thu, 31 Aug 2023 14:22:08 +0530 MIME-Version: 1.0 Content-Language: en-US To: Kamil Konieczny , igt-dev@lists.freedesktop.org, "Thasleem, Mohammed" References: <20230829161759.9315-1-mohammed.thasleem@intel.com> <20230830135109.ssdr3kkwalja35pa@kamilkon-desk.igk.intel.com> From: "Sharma, Swati2" In-Reply-To: <20230830135109.ssdr3kkwalja35pa@kamilkon-desk.igk.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_atomic_transition: Reduce the execution time on modest-transition List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Thasleem, Subject should be like "limit no. of iterations" On 30-Aug-23 7:21 PM, Kamil Konieczny wrote: > Hi, > > there is no such e-mail address at fdo: Thasleem@freedesktop.org > Please stop adding it to Cc. > > On 2023-08-29 at 21:47:59 +0530, Thasleem, Mohammed wrote: >> Due to the more number of iterations, "modest-transition" tests are >> getting timed out on CI. Reducing the number of iterations to half >> can save a lot of execution time. >> >> Signed-off-by: Thasleem, Mohammed > ---------------- ^ ------- ^ > Should be: > Signed-off-by: Mohammed Thasleem > > You should also consider adding From: at begin of patch. > >> --- >> tests/kms_atomic_transition.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c >> index a470eb88c..690202271 100644 >> --- a/tests/kms_atomic_transition.c >> +++ b/tests/kms_atomic_transition.c >> @@ -966,10 +966,7 @@ retry: >> } >> } >> >> - iter_max = 1 << j; >> - >> - if (igt_run_in_simulation() && iter_max > 1) >> - iter_max = iter_max >> 1; >> + iter_max = j << 1; > > This do not match with your description and looks wrong. > > Regards, > Kamil > >> >> if (igt_display_try_commit_atomic(&data->display, >> DRM_MODE_ATOMIC_TEST_ONLY | >> -- >> 2.34.1 >>