Re: [PATCH i-g-t] lib/pciids: sync pciids.h with kernel

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 13 Aug 2025, Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:
> Hi Jani,
> On 2025-08-12 at 18:49:38 +0300, Jani Nikula wrote:
>> On Tue, 12 Aug 2025, Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:
>> > Hi Jani,
>> > On 2025-08-11 at 16:09:01 +0300, Jani Nikula wrote:
>> >> Syncing lib/pciids.h with kernel include/drm/intel/pciids.h means there
>> >> must exist kernel and igt commits where the files are identical,
>> >> i.e. the file is copied verbatim at some kernel commit to igt.
>> >> 
>> >> It does *not* mean syncing the *changes* of a kernel commit to the igt
>> >> version of the file.
>> >> 
>> >> The latest changes to lib/pciids.h have gone out of sync with kernel,
>> >> completely missing kernel commit 3c0f211bc8fc ("drm/xe: Add Wildcat Lake
>> >> device IDs to PTL list").
>> >> 
>> >> Properly sync PCI IDs with kernel commit ccfb15b8158c ("drm/xe/bmg: Add
>> >> one additional PCI ID"), including the full file.
>> >> 
>> >> Fixes: 26ddb59c1d5f ("lib/pciids: Add one more PCI ID to BMG")
>> >> Cc: Ravi Kumar Vodapalli <ravi.kumar.vodapalli@intel.com>
>> >> Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
>> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> >
>> > Thank you for update of pciids, imho subject could be improved,
>> > something like:
>> >
>> > [PATCH i-g-t] lib/pciids: Add Wildcat Lake
>> >
>> > so it will be more informative with git log --oneline
>> >
>> > No need for resend, this could be done at merge so
>> >
>> > Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>> 
>> Thanks, pushed with the subject updated.
>> 
>> BR,
>> Jani.
>
> It somehow ended up with two lib/...:
>
> lib/pciids: lib/pciids: Add Wildcat Lake
>
> It is not a big deal here as it is still better then former
> subject.

Oops, sorry.

> Please re-read your submission before pushing, preferably
> with
> git log -N
>
> and then with
> git log -N --oneline
>
> where N is number of patches merged.

Funny.


BR,
Jani.


>
> Regards,
> Kamil
>
>> 
>> >
>> >> ---
>> >>  lib/pciids.h | 4 +++-
>> >>  1 file changed, 3 insertions(+), 1 deletion(-)
>> >> 
>> >> diff --git a/lib/pciids.h b/lib/pciids.h
>> >> index 666265b5f8c8..76f8d26f9cc9 100644
>> >> --- a/lib/pciids.h
>> >> +++ b/lib/pciids.h
>> >> @@ -872,6 +872,8 @@
>> >>  	MACRO__(0xB08F, ## __VA_ARGS__), \
>> >>  	MACRO__(0xB090, ## __VA_ARGS__), \
>> >>  	MACRO__(0xB0A0, ## __VA_ARGS__), \
>> >> -	MACRO__(0xB0B0, ## __VA_ARGS__)
>> >> +	MACRO__(0xB0B0, ## __VA_ARGS__), \
>> >> +	MACRO__(0xFD80, ## __VA_ARGS__), \
>> >> +	MACRO__(0xFD81, ## __VA_ARGS__)
>> >>  
>> >>  #endif /* __PCIIDS_H__ */
>> >> -- 
>> >> 2.47.2
>> >> 
>> 
>> -- 
>> Jani Nikula, Intel

-- 
Jani Nikula, Intel