* [PATCH i-g-t] lib/pciids: sync pciids.h with kernel
@ 2025-08-11 13:09 Jani Nikula
2025-08-11 19:44 ` ✗ i915.CI.BAT: failure for " Patchwork
2025-08-12 11:59 ` [PATCH i-g-t] " Kamil Konieczny
0 siblings, 2 replies; 6+ messages in thread
From: Jani Nikula @ 2025-08-11 13:09 UTC (permalink / raw)
To: igt-dev; +Cc: jani.nikula, Ravi Kumar Vodapalli, Dnyaneshwar Bhadane
Syncing lib/pciids.h with kernel include/drm/intel/pciids.h means there
must exist kernel and igt commits where the files are identical,
i.e. the file is copied verbatim at some kernel commit to igt.
It does *not* mean syncing the *changes* of a kernel commit to the igt
version of the file.
The latest changes to lib/pciids.h have gone out of sync with kernel,
completely missing kernel commit 3c0f211bc8fc ("drm/xe: Add Wildcat Lake
device IDs to PTL list").
Properly sync PCI IDs with kernel commit ccfb15b8158c ("drm/xe/bmg: Add
one additional PCI ID"), including the full file.
Fixes: 26ddb59c1d5f ("lib/pciids: Add one more PCI ID to BMG")
Cc: Ravi Kumar Vodapalli <ravi.kumar.vodapalli@intel.com>
Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
lib/pciids.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/pciids.h b/lib/pciids.h
index 666265b5f8c8..76f8d26f9cc9 100644
--- a/lib/pciids.h
+++ b/lib/pciids.h
@@ -872,6 +872,8 @@
MACRO__(0xB08F, ## __VA_ARGS__), \
MACRO__(0xB090, ## __VA_ARGS__), \
MACRO__(0xB0A0, ## __VA_ARGS__), \
- MACRO__(0xB0B0, ## __VA_ARGS__)
+ MACRO__(0xB0B0, ## __VA_ARGS__), \
+ MACRO__(0xFD80, ## __VA_ARGS__), \
+ MACRO__(0xFD81, ## __VA_ARGS__)
#endif /* __PCIIDS_H__ */
--
2.47.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* ✗ i915.CI.BAT: failure for lib/pciids: sync pciids.h with kernel
2025-08-11 13:09 [PATCH i-g-t] lib/pciids: sync pciids.h with kernel Jani Nikula
@ 2025-08-11 19:44 ` Patchwork
2025-08-12 11:59 ` [PATCH i-g-t] " Kamil Konieczny
1 sibling, 0 replies; 6+ messages in thread
From: Patchwork @ 2025-08-11 19:44 UTC (permalink / raw)
To: Jani Nikula; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 11021 bytes --]
== Series Details ==
Series: lib/pciids: sync pciids.h with kernel
URL : https://patchwork.freedesktop.org/series/152773/
State : failure
== Summary ==
CI Bug Log - changes from IGT_8492 -> IGTPW_13571
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_13571 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_13571, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/index.html
Participating hosts (44 -> 43)
------------------------------
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_13571:
### IGT changes ###
#### Possible regressions ####
* igt@core_hotunplug@unbind-rebind:
- bat-jsl-1: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8492/bat-jsl-1/igt@core_hotunplug@unbind-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-jsl-1/igt@core_hotunplug@unbind-rebind.html
- fi-cfl-8109u: [PASS][3] -> [ABORT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8492/fi-cfl-8109u/igt@core_hotunplug@unbind-rebind.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/fi-cfl-8109u/igt@core_hotunplug@unbind-rebind.html
Known issues
------------
Here are the changes found in IGTPW_13571 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@dmabuf@all-tests@dma_fence_chain:
- fi-bsw-n3050: [PASS][5] -> [ABORT][6] ([i915#12904]) +1 other test abort
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8492/fi-bsw-n3050/igt@dmabuf@all-tests@dma_fence_chain.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/fi-bsw-n3050/igt@dmabuf@all-tests@dma_fence_chain.html
* igt@gem_lmem_swapping@parallel-random-engines:
- bat-mtlp-9: NOTRUN -> [SKIP][7] ([i915#4613]) +3 other tests skip
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@gem_lmem_swapping@parallel-random-engines.html
- bat-arlh-3: NOTRUN -> [SKIP][8] ([i915#11671]) +3 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-arlh-3/igt@gem_lmem_swapping@parallel-random-engines.html
- bat-twl-1: NOTRUN -> [SKIP][9] ([i915#10213] / [i915#11671]) +3 other tests skip
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-twl-1/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_mmap@basic:
- bat-mtlp-9: NOTRUN -> [SKIP][10] ([i915#4083])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@gem_mmap@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-mtlp-9: NOTRUN -> [SKIP][11] ([i915#4079]) +1 other test skip
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-mtlp-9: NOTRUN -> [SKIP][12] ([i915#4077]) +2 other tests skip
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@gem_tiled_fence_blits@basic.html
* igt@i915_pm_rps@basic-api:
- bat-mtlp-9: NOTRUN -> [SKIP][13] ([i915#11681] / [i915#6621])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@workarounds:
- bat-mtlp-6: [PASS][14] -> [DMESG-FAIL][15] ([i915#12061]) +1 other test dmesg-fail
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8492/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
- bat-mtlp-9: NOTRUN -> [DMESG-FAIL][16] ([i915#12061]) +1 other test dmesg-fail
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@i915_selftest@live@workarounds.html
* igt@intel_hwmon@hwmon-read:
- bat-mtlp-9: NOTRUN -> [SKIP][17] ([i915#7707]) +1 other test skip
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@intel_hwmon@hwmon-read.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-mtlp-9: NOTRUN -> [SKIP][18] ([i915#5190])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-mtlp-9: NOTRUN -> [SKIP][19] ([i915#4212]) +8 other tests skip
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-mtlp-9: NOTRUN -> [SKIP][20] ([i915#4213]) +1 other test skip
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_dsc@dsc-basic:
- bat-mtlp-9: NOTRUN -> [SKIP][21] ([i915#3555] / [i915#3840] / [i915#9159])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@kms_dsc@dsc-basic.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-mtlp-9: NOTRUN -> [SKIP][22]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_psr@psr-primary-mmap-gtt:
- bat-mtlp-9: NOTRUN -> [SKIP][23] ([i915#4077] / [i915#9688]) +1 other test skip
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@kms_psr@psr-primary-mmap-gtt.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-mtlp-9: NOTRUN -> [SKIP][24] ([i915#3555] / [i915#8809])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-gtt:
- bat-mtlp-9: NOTRUN -> [SKIP][25] ([i915#3708] / [i915#4077]) +1 other test skip
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@basic-read:
- bat-mtlp-9: NOTRUN -> [SKIP][26] ([i915#3708]) +1 other test skip
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-write:
- bat-mtlp-9: NOTRUN -> [SKIP][27] ([i915#10216] / [i915#3708])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- bat-twl-1: [ABORT][28] -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8492/bat-twl-1/igt@core_hotunplug@unbind-rebind.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-twl-1/igt@core_hotunplug@unbind-rebind.html
* igt@dmabuf@all-tests@dma_fence_chain:
- fi-bsw-nick: [ABORT][30] ([i915#12904]) -> [PASS][31] +1 other test pass
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8492/fi-bsw-nick/igt@dmabuf@all-tests@dma_fence_chain.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/fi-bsw-nick/igt@dmabuf@all-tests@dma_fence_chain.html
* igt@i915_module_load@load:
- bat-mtlp-9: [ABORT][32] ([i915#13494] / [i915#14804]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8492/bat-mtlp-9/igt@i915_module_load@load.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-mtlp-9/igt@i915_module_load@load.html
* igt@i915_module_load@reload:
- bat-arlh-3: [ABORT][34] -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8492/bat-arlh-3/igt@i915_module_load@reload.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-arlh-3/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@module-reload:
- fi-hsw-4770: [ABORT][36] -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8492/fi-hsw-4770/igt@i915_pm_rpm@module-reload.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/fi-hsw-4770/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@workarounds:
- bat-arls-6: [DMESG-FAIL][38] ([i915#12061]) -> [PASS][39] +1 other test pass
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8492/bat-arls-6/igt@i915_selftest@live@workarounds.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/bat-arls-6/igt@i915_selftest@live@workarounds.html
[i915#10213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10213
[i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
[i915#11671]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11671
[i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#12904]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12904
[i915#13494]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13494
[i915#14804]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14804
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4213
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#6621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6621
[i915#7707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7707
[i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
[i915#9159]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9159
[i915#9688]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9688
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_8492 -> IGTPW_13571
CI-20190529: 20190529
CI_DRM_16980: 0aae2a6e4e71b046d167b9ad79e0ddd2d5d23e7d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_13571: 772a38c8ca08c3a4fa84325fdf25f9cad7eb12ca @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_8492: 1e6c0d07b83cde9f2300b193f441c37d9dde5981 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_13571/index.html
[-- Attachment #2: Type: text/html, Size: 12940 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH i-g-t] lib/pciids: sync pciids.h with kernel
2025-08-11 13:09 [PATCH i-g-t] lib/pciids: sync pciids.h with kernel Jani Nikula
2025-08-11 19:44 ` ✗ i915.CI.BAT: failure for " Patchwork
@ 2025-08-12 11:59 ` Kamil Konieczny
2025-08-12 15:49 ` Jani Nikula
1 sibling, 1 reply; 6+ messages in thread
From: Kamil Konieczny @ 2025-08-12 11:59 UTC (permalink / raw)
To: Jani Nikula; +Cc: igt-dev, Ravi Kumar Vodapalli, Dnyaneshwar Bhadane
Hi Jani,
On 2025-08-11 at 16:09:01 +0300, Jani Nikula wrote:
> Syncing lib/pciids.h with kernel include/drm/intel/pciids.h means there
> must exist kernel and igt commits where the files are identical,
> i.e. the file is copied verbatim at some kernel commit to igt.
>
> It does *not* mean syncing the *changes* of a kernel commit to the igt
> version of the file.
>
> The latest changes to lib/pciids.h have gone out of sync with kernel,
> completely missing kernel commit 3c0f211bc8fc ("drm/xe: Add Wildcat Lake
> device IDs to PTL list").
>
> Properly sync PCI IDs with kernel commit ccfb15b8158c ("drm/xe/bmg: Add
> one additional PCI ID"), including the full file.
>
> Fixes: 26ddb59c1d5f ("lib/pciids: Add one more PCI ID to BMG")
> Cc: Ravi Kumar Vodapalli <ravi.kumar.vodapalli@intel.com>
> Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Thank you for update of pciids, imho subject could be improved,
something like:
[PATCH i-g-t] lib/pciids: Add Wildcat Lake
so it will be more informative with git log --oneline
No need for resend, this could be done at merge so
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> lib/pciids.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/pciids.h b/lib/pciids.h
> index 666265b5f8c8..76f8d26f9cc9 100644
> --- a/lib/pciids.h
> +++ b/lib/pciids.h
> @@ -872,6 +872,8 @@
> MACRO__(0xB08F, ## __VA_ARGS__), \
> MACRO__(0xB090, ## __VA_ARGS__), \
> MACRO__(0xB0A0, ## __VA_ARGS__), \
> - MACRO__(0xB0B0, ## __VA_ARGS__)
> + MACRO__(0xB0B0, ## __VA_ARGS__), \
> + MACRO__(0xFD80, ## __VA_ARGS__), \
> + MACRO__(0xFD81, ## __VA_ARGS__)
>
> #endif /* __PCIIDS_H__ */
> --
> 2.47.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH i-g-t] lib/pciids: sync pciids.h with kernel
2025-08-12 11:59 ` [PATCH i-g-t] " Kamil Konieczny
@ 2025-08-12 15:49 ` Jani Nikula
2025-08-13 15:22 ` Kamil Konieczny
0 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2025-08-12 15:49 UTC (permalink / raw)
To: Kamil Konieczny; +Cc: igt-dev, Ravi Kumar Vodapalli, Dnyaneshwar Bhadane
On Tue, 12 Aug 2025, Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:
> Hi Jani,
> On 2025-08-11 at 16:09:01 +0300, Jani Nikula wrote:
>> Syncing lib/pciids.h with kernel include/drm/intel/pciids.h means there
>> must exist kernel and igt commits where the files are identical,
>> i.e. the file is copied verbatim at some kernel commit to igt.
>>
>> It does *not* mean syncing the *changes* of a kernel commit to the igt
>> version of the file.
>>
>> The latest changes to lib/pciids.h have gone out of sync with kernel,
>> completely missing kernel commit 3c0f211bc8fc ("drm/xe: Add Wildcat Lake
>> device IDs to PTL list").
>>
>> Properly sync PCI IDs with kernel commit ccfb15b8158c ("drm/xe/bmg: Add
>> one additional PCI ID"), including the full file.
>>
>> Fixes: 26ddb59c1d5f ("lib/pciids: Add one more PCI ID to BMG")
>> Cc: Ravi Kumar Vodapalli <ravi.kumar.vodapalli@intel.com>
>> Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Thank you for update of pciids, imho subject could be improved,
> something like:
>
> [PATCH i-g-t] lib/pciids: Add Wildcat Lake
>
> so it will be more informative with git log --oneline
>
> No need for resend, this could be done at merge so
>
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Thanks, pushed with the subject updated.
BR,
Jani.
>
>> ---
>> lib/pciids.h | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/pciids.h b/lib/pciids.h
>> index 666265b5f8c8..76f8d26f9cc9 100644
>> --- a/lib/pciids.h
>> +++ b/lib/pciids.h
>> @@ -872,6 +872,8 @@
>> MACRO__(0xB08F, ## __VA_ARGS__), \
>> MACRO__(0xB090, ## __VA_ARGS__), \
>> MACRO__(0xB0A0, ## __VA_ARGS__), \
>> - MACRO__(0xB0B0, ## __VA_ARGS__)
>> + MACRO__(0xB0B0, ## __VA_ARGS__), \
>> + MACRO__(0xFD80, ## __VA_ARGS__), \
>> + MACRO__(0xFD81, ## __VA_ARGS__)
>>
>> #endif /* __PCIIDS_H__ */
>> --
>> 2.47.2
>>
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH i-g-t] lib/pciids: sync pciids.h with kernel
2025-08-12 15:49 ` Jani Nikula
@ 2025-08-13 15:22 ` Kamil Konieczny
2025-08-14 8:55 ` Jani Nikula
0 siblings, 1 reply; 6+ messages in thread
From: Kamil Konieczny @ 2025-08-13 15:22 UTC (permalink / raw)
To: Jani Nikula; +Cc: igt-dev, Ravi Kumar Vodapalli, Dnyaneshwar Bhadane
Hi Jani,
On 2025-08-12 at 18:49:38 +0300, Jani Nikula wrote:
> On Tue, 12 Aug 2025, Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:
> > Hi Jani,
> > On 2025-08-11 at 16:09:01 +0300, Jani Nikula wrote:
> >> Syncing lib/pciids.h with kernel include/drm/intel/pciids.h means there
> >> must exist kernel and igt commits where the files are identical,
> >> i.e. the file is copied verbatim at some kernel commit to igt.
> >>
> >> It does *not* mean syncing the *changes* of a kernel commit to the igt
> >> version of the file.
> >>
> >> The latest changes to lib/pciids.h have gone out of sync with kernel,
> >> completely missing kernel commit 3c0f211bc8fc ("drm/xe: Add Wildcat Lake
> >> device IDs to PTL list").
> >>
> >> Properly sync PCI IDs with kernel commit ccfb15b8158c ("drm/xe/bmg: Add
> >> one additional PCI ID"), including the full file.
> >>
> >> Fixes: 26ddb59c1d5f ("lib/pciids: Add one more PCI ID to BMG")
> >> Cc: Ravi Kumar Vodapalli <ravi.kumar.vodapalli@intel.com>
> >> Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >
> > Thank you for update of pciids, imho subject could be improved,
> > something like:
> >
> > [PATCH i-g-t] lib/pciids: Add Wildcat Lake
> >
> > so it will be more informative with git log --oneline
> >
> > No need for resend, this could be done at merge so
> >
> > Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>
> Thanks, pushed with the subject updated.
>
> BR,
> Jani.
It somehow ended up with two lib/...:
lib/pciids: lib/pciids: Add Wildcat Lake
It is not a big deal here as it is still better then former
subject.
Please re-read your submission before pushing, preferably
with
git log -N
and then with
git log -N --oneline
where N is number of patches merged.
Regards,
Kamil
>
> >
> >> ---
> >> lib/pciids.h | 4 +++-
> >> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/lib/pciids.h b/lib/pciids.h
> >> index 666265b5f8c8..76f8d26f9cc9 100644
> >> --- a/lib/pciids.h
> >> +++ b/lib/pciids.h
> >> @@ -872,6 +872,8 @@
> >> MACRO__(0xB08F, ## __VA_ARGS__), \
> >> MACRO__(0xB090, ## __VA_ARGS__), \
> >> MACRO__(0xB0A0, ## __VA_ARGS__), \
> >> - MACRO__(0xB0B0, ## __VA_ARGS__)
> >> + MACRO__(0xB0B0, ## __VA_ARGS__), \
> >> + MACRO__(0xFD80, ## __VA_ARGS__), \
> >> + MACRO__(0xFD81, ## __VA_ARGS__)
> >>
> >> #endif /* __PCIIDS_H__ */
> >> --
> >> 2.47.2
> >>
>
> --
> Jani Nikula, Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH i-g-t] lib/pciids: sync pciids.h with kernel
2025-08-13 15:22 ` Kamil Konieczny
@ 2025-08-14 8:55 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2025-08-14 8:55 UTC (permalink / raw)
To: Kamil Konieczny; +Cc: igt-dev, Ravi Kumar Vodapalli, Dnyaneshwar Bhadane
On Wed, 13 Aug 2025, Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:
> Hi Jani,
> On 2025-08-12 at 18:49:38 +0300, Jani Nikula wrote:
>> On Tue, 12 Aug 2025, Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:
>> > Hi Jani,
>> > On 2025-08-11 at 16:09:01 +0300, Jani Nikula wrote:
>> >> Syncing lib/pciids.h with kernel include/drm/intel/pciids.h means there
>> >> must exist kernel and igt commits where the files are identical,
>> >> i.e. the file is copied verbatim at some kernel commit to igt.
>> >>
>> >> It does *not* mean syncing the *changes* of a kernel commit to the igt
>> >> version of the file.
>> >>
>> >> The latest changes to lib/pciids.h have gone out of sync with kernel,
>> >> completely missing kernel commit 3c0f211bc8fc ("drm/xe: Add Wildcat Lake
>> >> device IDs to PTL list").
>> >>
>> >> Properly sync PCI IDs with kernel commit ccfb15b8158c ("drm/xe/bmg: Add
>> >> one additional PCI ID"), including the full file.
>> >>
>> >> Fixes: 26ddb59c1d5f ("lib/pciids: Add one more PCI ID to BMG")
>> >> Cc: Ravi Kumar Vodapalli <ravi.kumar.vodapalli@intel.com>
>> >> Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
>> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> >
>> > Thank you for update of pciids, imho subject could be improved,
>> > something like:
>> >
>> > [PATCH i-g-t] lib/pciids: Add Wildcat Lake
>> >
>> > so it will be more informative with git log --oneline
>> >
>> > No need for resend, this could be done at merge so
>> >
>> > Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>>
>> Thanks, pushed with the subject updated.
>>
>> BR,
>> Jani.
>
> It somehow ended up with two lib/...:
>
> lib/pciids: lib/pciids: Add Wildcat Lake
>
> It is not a big deal here as it is still better then former
> subject.
Oops, sorry.
> Please re-read your submission before pushing, preferably
> with
> git log -N
>
> and then with
> git log -N --oneline
>
> where N is number of patches merged.
Funny.
BR,
Jani.
>
> Regards,
> Kamil
>
>>
>> >
>> >> ---
>> >> lib/pciids.h | 4 +++-
>> >> 1 file changed, 3 insertions(+), 1 deletion(-)
>> >>
>> >> diff --git a/lib/pciids.h b/lib/pciids.h
>> >> index 666265b5f8c8..76f8d26f9cc9 100644
>> >> --- a/lib/pciids.h
>> >> +++ b/lib/pciids.h
>> >> @@ -872,6 +872,8 @@
>> >> MACRO__(0xB08F, ## __VA_ARGS__), \
>> >> MACRO__(0xB090, ## __VA_ARGS__), \
>> >> MACRO__(0xB0A0, ## __VA_ARGS__), \
>> >> - MACRO__(0xB0B0, ## __VA_ARGS__)
>> >> + MACRO__(0xB0B0, ## __VA_ARGS__), \
>> >> + MACRO__(0xFD80, ## __VA_ARGS__), \
>> >> + MACRO__(0xFD81, ## __VA_ARGS__)
>> >>
>> >> #endif /* __PCIIDS_H__ */
>> >> --
>> >> 2.47.2
>> >>
>>
>> --
>> Jani Nikula, Intel
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-08-14 8:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-11 13:09 [PATCH i-g-t] lib/pciids: sync pciids.h with kernel Jani Nikula
2025-08-11 19:44 ` ✗ i915.CI.BAT: failure for " Patchwork
2025-08-12 11:59 ` [PATCH i-g-t] " Kamil Konieczny
2025-08-12 15:49 ` Jani Nikula
2025-08-13 15:22 ` Kamil Konieczny
2025-08-14 8:55 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).