From: Alex Hung <alex.hung@amd.com>
To: Aurabindo Pillai <aurabindo.pillai@amd.com>,
igt-dev@lists.freedesktop.org
Cc: hersenxs.wu@amd.com
Subject: Re: [igt-dev] [PATCH v4 1/2] lib/amdgpu: Add check for ODM combine segments debugfs endpoint
Date: Mon, 21 Aug 2023 09:38:04 -0600 [thread overview]
Message-ID: <ee6de4c4-266d-b4bc-ba33-2c6ac058d3c8@amd.com> (raw)
In-Reply-To: <20230821140712.1034591-1-aurabindo.pillai@amd.com>
Reviewed-by: Alex Hung <alex.hung@amd.com>
On 2023-08-21 08:07, Aurabindo Pillai wrote:
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> ---
> lib/igt_amd.c | 10 ++++++++++
> lib/igt_amd.h | 4 ++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/lib/igt_amd.c b/lib/igt_amd.c
> index 83011e8ca..1a720ff56 100644
> --- a/lib/igt_amd.c
> +++ b/lib/igt_amd.c
> @@ -325,6 +325,16 @@ static bool igt_amd_output_has_dsc(int drm_fd, char *connector_name)
> return igt_amd_output_has_debugfs(drm_fd, connector_name, DEBUGFS_DSC_CLOCK_EN);
> }
>
> +/**
> + * igt_amd_output_has_odm_combine_segments: check if connector has dsc debugfs entry
> + * @drm_fd: DRM file descriptor
> + * @connector_name: The connector's name, on which we're reading the status
> + */
> +bool igt_amd_output_has_odm_combine_segments(int drm_fd, char *connector_name)
> +{
> + return igt_amd_output_has_debugfs(drm_fd, connector_name, DEBUGFS_ODM_COMBINE_SEG);
> +}
> +
> /**
> * is_dp_dsc_supported: Checks if connector is DSC capable
> * @display: A pointer to an #igt_display_t structure
> diff --git a/lib/igt_amd.h b/lib/igt_amd.h
> index 6f538a195..c05b4b730 100644
> --- a/lib/igt_amd.h
> +++ b/lib/igt_amd.h
> @@ -54,6 +54,9 @@
> #define DEBUGFS_DM_VISUAL_CONFIRM "amdgpu_dm_visual_confirm"
> #define DEBUGFS_DM_CAPABILITIES "amdgpu_dm_capabilities"
>
> +/* ODM Combine */
> +#define DEBUGFS_ODM_COMBINE_SEG "odm_combine_segments"
> +
> enum amd_dsc_clock_force {
> DSC_AUTOMATIC = 0,
> DSC_FORCE_ON,
> @@ -197,4 +200,5 @@ int igt_amd_get_visual_confirm(int drm_fd);
> bool igt_amd_set_visual_confirm(int drm_fd, enum amdgpu_debug_visual_confirm option);
>
> bool igt_amd_is_mall_capable(int drm_fd);
> +bool igt_amd_output_has_odm_combine_segments(int drm_fd, char *connector_name);
> #endif /* IGT_AMD_H */
next prev parent reply other threads:[~2023-08-21 15:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 14:07 [igt-dev] [PATCH v4 1/2] lib/amdgpu: Add check for ODM combine segments debugfs endpoint Aurabindo Pillai
2023-08-21 14:07 ` [igt-dev] [PATCH v4 2/2] tests/amdgpu: Add test for ODM combine Aurabindo Pillai
2023-08-21 15:39 ` Alex Hung
2023-08-21 20:18 ` Aurabindo Pillai
2023-08-22 19:45 ` Kamil Konieczny
2023-08-22 20:18 ` Aurabindo Pillai
2023-08-23 8:02 ` Kamil Konieczny
2023-08-23 13:38 ` Aurabindo Pillai
2023-08-21 15:38 ` Alex Hung [this message]
2023-08-21 17:58 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [v4,1/2] lib/amdgpu: Add check for ODM combine segments debugfs endpoint Patchwork
2023-08-21 18:23 ` [igt-dev] ○ CI.xeBAT: info " Patchwork
2023-08-21 18:40 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2023-08-22 18:17 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [v4,1/2] lib/amdgpu: Add check for ODM combine segments debugfs endpoint (rev4) Patchwork
2023-08-22 18:46 ` [igt-dev] ○ CI.xeBAT: info " Patchwork
2023-08-22 18:55 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-08-22 23:29 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-08-23 8:05 ` Kamil Konieczny
2023-08-23 10:26 ` Yedireswarapu, SaiX Nandan
2023-08-23 10:07 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee6de4c4-266d-b4bc-ba33-2c6ac058d3c8@amd.com \
--to=alex.hung@amd.com \
--cc=aurabindo.pillai@amd.com \
--cc=hersenxs.wu@amd.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox