Re: [igt-dev] [PATCH i-g-t v10 22/31] tests/perf.c: Remove buffer from batch

[Lionel Landwerlin <lionel.g.landwerlin@intel.com>]

On 20/11/2020 13:31, Zbigniew Kempczyński wrote:
> Currently we need to ensure intel_buf is a part of single ibb due
> to fact it is acquiring address from allocator so we cannot keep
> it in two separate ibbs (theoretically it is possible when different
> ibbs would be in same context but it is not currently implemented).
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>


I did Rb that commit in case you missed it ;)


-Lionel


> ---
>   tests/i915/perf.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/tests/i915/perf.c b/tests/i915/perf.c
> index caeabd62..1061a50f 100644
> --- a/tests/i915/perf.c
> +++ b/tests/i915/perf.c
> @@ -3430,6 +3430,9 @@ gen8_test_single_ctx_render_target_writes_a_counter(void)
>   			/* Another redundant flush to clarify batch bo is free to reuse */
>   			intel_bb_flush_render(ibb0);
>   
> +			/* Remove intel_buf from ibb0 added implicitly in rendercopy */
> +			intel_bb_remove_intel_buf(ibb0, dst_buf);
> +
>   			/* submit two copies on the other context to avoid a false
>   			 * positive in case the driver somehow ended up filtering for
>   			 * context1
> @@ -3823,6 +3826,9 @@ static void gen12_single_ctx_helper(void)
>   				     BO_REPORT_ID0);
>   	intel_bb_flush_render(ibb0);
>   
> +	/* Remove intel_buf from ibb0 added implicitly in rendercopy */
> +	intel_bb_remove_intel_buf(ibb0, dst_buf);
> +
>   	/* This is the work/context that is measured for counter increments */
>   	render_copy(ibb0,
>   		    &src[0], 0, 0, width, height,
> @@ -3869,6 +3875,9 @@ static void gen12_single_ctx_helper(void)
>   				     BO_REPORT_ID3);
>   	intel_bb_flush_render(ibb1);
>   
> +	/* Remove intel_buf from ibb1 added implicitly in rendercopy */
> +	intel_bb_remove_intel_buf(ibb1, dst_buf);
> +
>   	/* Submit an mi-rpc to context0 after all measurable work */
>   #define BO_TIMESTAMP_OFFSET1 1032
>   #define BO_REPORT_OFFSET1 256


_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev