Re: [igt-dev] [PATCH i-g-t 2/4] lib/igt_debugfs: add AMDGPU pipe crc sources

["Kazlauskas, Nicholas" <Nicholas.Kazlauskas@amd.com>]

On 6/24/19 10:31 AM, Dingchen Zhang wrote:
> Need different pipe CRC sources to validate AMDGPU
> digital bypass mode.
> 
> Added available AMDGPU pipe crc sources in igt_debugfs.h
> 
> Cc: Harry Wentland <Harry.Wentland@amd.com>
> Cc: Nick Kazlauskas <Nicholas.Kazlauskas@amd.com>
> Change-Id: Ia6c9ccb7a904ec8a490e519425c006ae2ea95a9b

Drop the Change-ID.

> Signed-off-by: Dingchen Zhang <dingchen.zhang@amd.com>
> ---
>   lib/igt_debugfs.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/lib/igt_debugfs.h b/lib/igt_debugfs.h
> index 52520b3c..b49dd2b6 100644
> --- a/lib/igt_debugfs.h
> +++ b/lib/igt_debugfs.h
> @@ -83,6 +83,9 @@ typedef struct {
>   } igt_crc_t;
>   
>   #define INTEL_PIPE_CRC_SOURCE_AUTO "auto"
> +#define AMDGPU_PIPE_CRC_SOURCE_AUTO "auto"
> +#define AMDGPU_PIPE_CRC_SOURCE_CRTC "crtc"

We can probably just drop the "auto" and "crtc" defines here if we're 
not using them. Yes, it's a little strange that we're using the 
INTEL_PIPE_CRC_SOURCE_AUTO for every test, but it's already the convention.

The DPRX one below is fine.

Maybe just make the patch title "Add DPRX CRC source for AMDGPU" with 
that change.

Nicholas Kazlauskas

> +#define AMDGPU_PIPE_CRC_SOURCE_DPRX "dprx"
>   
>   void igt_assert_crc_equal(const igt_crc_t *a, const igt_crc_t *b);
>   bool igt_check_crc_equal(const igt_crc_t *a, const igt_crc_t *b);
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev