Re: [PATCH i-g-t 07/11] lib/igt_kms: use for_each_crtc() for iterating CRTCs

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 10 Feb 2026, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Feb 10, 2026 at 05:23:48PM +0200, Jani Nikula wrote:
>> The loop still figures out the pipe mask, keep using pipe here. The main
>> thing is not using the loop index as pipe, as that is subject to change
>> in the future.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  lib/igt_kms.c | 8 +++-----
>>  1 file changed, 3 insertions(+), 5 deletions(-)
>> 
>> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
>> index c4be889dc696..63fd8095c551 100644
>> --- a/lib/igt_kms.c
>> +++ b/lib/igt_kms.c
>> @@ -3622,16 +3622,14 @@ igt_output_t **__igt_pipe_populate_outputs(igt_display_t *display, igt_output_t
>>  {
>>  	unsigned full_pipe_mask = 0, assigned_pipes = 0;
>>  	igt_output_t *output;
>> +	igt_crtc_t *crtc;
>>  	int i, j;
>>  
>>  	memset(chosen_outputs, 0,
>>  	       sizeof(*chosen_outputs) * igt_display_n_crtcs(display));
>>  
>> -	for (i = 0; i < igt_display_n_crtcs(display); i++) {
>> -		igt_crtc_t *crtc = igt_crtc_for_pipe(display, i);
>> -		if (crtc->valid)
>> -			full_pipe_mask |= (1 << i);
>> -	}
>> +	for_each_crtc(display, crtc)
>> +		full_pipe_mask |= crtc->pipe;
>
> 1 << crtc->pipe

*facepalm* of course

>
>>  
>>  	/*
>>  	 * Try to assign all outputs to the first available CRTC for
>> -- 
>> 2.47.3

-- 
Jani Nikula, Intel