From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 896826E16D for ; Fri, 7 Dec 2018 07:38:34 +0000 (UTC) Message-ID: From: Paul Kocialkowski Date: Fri, 07 Dec 2018 08:38:33 +0100 In-Reply-To: References: <20181206141132.23349-1-paul.kocialkowski@bootlin.com> <20181206141132.23349-7-paul.kocialkowski@bootlin.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 6/9] lib/igt_vc4: Add helpers for converting linear to T-tiled XRGB buffers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Lyude Paul , igt-dev@lists.freedesktop.org Cc: Petri Latvala , Eben Upton , Thomas Petazzoni List-ID: SGksCgpPbiBUaHUsIDIwMTgtMTItMDYgYXQgMTY6NTEgLTA1MDAsIEx5dWRlIFBhdWwgd3JvdGU6 Cj4gT25lIHNtYWxsIG5pdHBpY2sKPiAKPiBPbiBUaHUsIDIwMTgtMTItMDYgYXQgMTU6MTEgKzAx MDAsIFBhdWwgS29jaWFsa293c2tpIHdyb3RlOgo+ID4gSW4gb3JkZXIgdG8gaW50ZWdyYXRlIHRl c3Rpbmcgb2YgVC10aWxlZCBidWZmZXJzLCB0aGUgZWFzaWVzdCBwYXRoIGlzIHRvCj4gPiBnZW5l cmF0ZSBwYXR0ZXJucyAod2l0aCB0aGUgYWxyZWFkeS1leGlzdGluZyBmdW5jdGlvbnMpIGluIGxp bmVhcgo+ID4gYnVmZmVycyBhbmQgY29udmVydCB0aGVtIHRvIFQtdGlsZWQgc3Vic2VxdWVudGx5 Lgo+ID4gCj4gPiBBZGQgaGVscGVycyB0byBkbyB0aGF0IGNvbnZlcnNpb24sIHdpdGggYSBmaXJz dCBoZWxwZXIgdGhhdCByZXR1cm5zIHRoZQo+ID4gbWVtb3J5IG9mZnNldCBmb3IgYSBnaXZlbiBw b3NpdGlvbiBpbiBhIFQtdGlsZWQgYnVmZmVyIGFuZCBhIHNlY29uZAo+ID4gaGVscGVyIHRoYXQg dXNlcyBpdCBmb3IgY29udmVydGluZyBiZXR3ZWVuIGZyYW1lYnVmZmVycy4KPiA+IAo+ID4gU2ln bmVkLW9mZi1ieTogUGF1bCBLb2NpYWxrb3dza2kgPHBhdWwua29jaWFsa293c2tpQGJvb3RsaW4u Y29tPgo+ID4gLS0tCj4gPiAgbGliL2lndF92YzQuYyB8IDk2ICsrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gIGxpYi9pZ3RfdmM0LmggfCAgNCAr KysKPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDEwMCBpbnNlcnRpb25zKCspCj4gPiAKPiA+IGRpZmYg LS1naXQgYS9saWIvaWd0X3ZjNC5jIGIvbGliL2lndF92YzQuYwo+ID4gaW5kZXggMTZkZmU2N2Eu LjBiNTEyNGYzIDEwMDY0NAo+ID4gLS0tIGEvbGliL2lndF92YzQuYwo+ID4gKysrIGIvbGliL2ln dF92YzQuYwo+ID4gQEAgLTM0LDYgKzM0LDcgQEAKPiA+ICAjaW5jbHVkZSAiZHJtdGVzdC5oIgo+ ID4gICNpbmNsdWRlICJpZ3RfYXV4LmgiCj4gPiAgI2luY2x1ZGUgImlndF9jb3JlLmgiCj4gPiAr I2luY2x1ZGUgImlndF9mYi5oIgo+ID4gICNpbmNsdWRlICJpZ3RfdmM0LmgiCj4gPiAgI2luY2x1 ZGUgImlvY3RsX3dyYXBwZXJzLmgiCj4gPiAgI2luY2x1ZGUgImludGVsX3JlZy5oIgo+ID4gQEAg LTE3NiwzICsxNzcsOTggQEAgYm9vbCBpZ3RfdmM0X3B1cmdlYWJsZV9ibyhpbnQgZmQsIGludCBo YW5kbGUsIGJvb2wKPiA+IHB1cmdlYWJsZSkKPiA+ICAKPiA+ICAJcmV0dXJuIGFyZy5yZXRhaW5l ZDsKPiA+ICB9Cj4gPiArCj4gPiArdW5zaWduZWQgaW50IGlndF92YzRfZmJfdF90aWxlZF9jb252 ZXJ0KHN0cnVjdCBpZ3RfZmIgKmRzdCwgc3RydWN0IGlndF9mYgo+ID4gKnNyYykKPiA+ICt7Cj4g PiArCXVuc2lnbmVkIGludCBmYl9pZDsKPiA+ICsJdW5zaWduZWQgaW50IGksIGo7Cj4gPiArCXVp bnQzMl90ICpzcmNfYnVmOwo+ID4gKwl1aW50MzJfdCAqZHN0X2J1ZjsKPiA+ICsJc2l6ZV90IG9m ZnNldDsKPiA+ICsKPiA+ICsJaWd0X2Fzc2VydChzcmMtPmRybV9mb3JtYXQgPT0gRFJNX0ZPUk1B VF9YUkdCODg4OCk7Cj4gPiArCj4gPiArCWZiX2lkID0gaWd0X2NyZWF0ZV9mYihzcmMtPmZkLCBz cmMtPndpZHRoLCBzcmMtPmhlaWdodCwgc3JjLQo+ID4gPiBkcm1fZm9ybWF0LAo+ID4gKwkJCSAg ICAgIERSTV9GT1JNQVRfTU9EX0JST0FEQ09NX1ZDNF9UX1RJTEVELCBkc3QpOwo+ID4gKwlpZ3Rf YXNzZXJ0KGZiX2lkID4gMCk7Cj4gPiArCj4gPiArCXNyY19idWYgPSBpZ3RfZmJfbWFwX2J1ZmZl cihzcmMtPmZkLCBzcmMpOwo+ID4gKwlpZ3RfYXNzZXJ0KHNyY19idWYpOwo+ID4gKwo+ID4gKwlk c3RfYnVmID0gaWd0X2ZiX21hcF9idWZmZXIoZHN0LT5mZCwgZHN0KTsKPiA+ICsJaWd0X2Fzc2Vy dChkc3RfYnVmKTsKPiA+ICsKPiA+ICsJZm9yIChpID0gMDsgaSA8IHNyYy0+aGVpZ2h0OyBpKysp IHsKPiA+ICsJCWZvciAoaiA9IDA7IGogPCBzcmMtPndpZHRoOyBqKyspIHsKPiA+ICsJCQlvZmZz ZXQgPSBpZ3RfdmM0X3RfdGlsZWRfb2Zmc2V0KHNyYy0+d2lkdGgsIHNyYy0KPiA+ID4gaGVpZ2h0 LAo+ID4gKwkJCQkJCQlzcmMtPmRybV9mb3JtYXQsIGosIGkpCj4gPiAvIDQ7Cj4gPiArCQkJKihk c3RfYnVmICsgb2Zmc2V0KSA9ICooc3JjX2J1ZiArCj4gPiArCQkJCQkJc3JjLT5zdHJpZGVzWzBd IC8gNCAqIGkgKyBqKTsKPiA+ICsJCX0KPiA+ICsJfQo+ID4gKwo+ID4gKwlpZ3RfZmJfdW5tYXBf YnVmZmVyKHNyYywgc3JjX2J1Zik7Cj4gPiArCWlndF9mYl91bm1hcF9idWZmZXIoZHN0LCBkc3Rf YnVmKTsKPiA+ICsKPiA+ICsJcmV0dXJuIGZiX2lkOwo+ID4gK30KPiA+ICsKPiA+ICtzaXplX3Qg aWd0X3ZjNF90X3RpbGVkX29mZnNldChzaXplX3Qgd2lkdGgsIHNpemVfdCBoZWlnaHQsIHNpemVf dCBmb3JtYXQsCj4gPiArCQkJICAgICAgc2l6ZV90IHgsIHNpemVfdCB5KQo+ID4gK3sKPiA+ICsJ c2l6ZV90IHQxa19tYXBfZXZlbls0XSA9IHsgMCwgMywgMSwgMiB9Owo+ID4gKwlzaXplX3QgdDFr X21hcF9vZGRbNF0gPSB7IDIsIDEsIDMsIDAgfTsKPiBObyBuZWVkIHRvIHNwZWNpZnkgdGhlIGFy cmF5IHNpemUgaGVyZSwgdDFrX21hcF9ldmVuW10gYW5kIHQxa19tYXBfb2RkW10KPiBzaG91bGQg YmUgZmluZS4gQWxzbywgdGhlc2UgbG9vayBsaWtlIHRoZXkgcHJvYmFibHkgc2hvdWxkIGJlIGNv bnN0LgoKRGVmaW5pdGVseSwgSSB3aWxsIG1ha2UgdGhlc2UgY2hhbmdlcyBpbiB2MiEKCkNoZWVy cywKClBhdWwKCj4gPiArCXNpemVfdCBvZmZzZXQgPSAwOwo+ID4gKwlzaXplX3QgdDRrX3csIHQ0 a194LCB0NGtfeTsKPiA+ICsJc2l6ZV90IHQxa194LCB0MWtfeTsKPiA+ICsJc2l6ZV90IHQ2NGJf eCwgdDY0Yl95Owo+ID4gKwlzaXplX3QgcGl4X3gsIHBpeF95Owo+ID4gKwl1bnNpZ25lZCBpbnQg aW5kZXg7Cj4gPiArCj4gPiArCWlndF9hc3NlcnQoZm9ybWF0ID09IERSTV9GT1JNQVRfWFJHQjg4 ODgpOwo+ID4gKwo+ID4gKwkvKiBXaWR0aCBpbiBudW1iZXIgb2YgNEsgdGlsZXMuICovCj4gPiAr CXQ0a193ID0gQUxJR04od2lkdGgsIDMyKSAvIDMyOwo+ID4gKwo+ID4gKwkvKiBYIGFuZCB5IGNv b3JkaW5hdGVzIGluIG51bWJlciBvZiA0SyB0aWxlcyAoMzJ4MzIpLiAqLwo+ID4gKwl0NGtfeCA9 IHggLyAzMjsKPiA+ICsJdDRrX3kgPSB5IC8gMzI7Cj4gPiArCj4gPiArCS8qIEluY3JlYXNlIG9m ZnNldCB0byB0aGUgYmVnaW5uaW5nIG9mIHRoZSBjb3JyZXNwb25kaW5nIDRLIHRpbGUuICovCj4g PiArCW9mZnNldCArPSB0NGtfeSAqIHQ0a193ICogMzIgKiAzMjsKPiA+ICsKPiA+ICsJLyogWCBh bmQgWSBjb29yZGluYXRlcyBpbiBudW1iZXIgb2YgMUsgdGlsZXMgKDE2eDE2KSB3aXRoaW4gdGhl IDRLCj4gPiB0aWxlLiAqLwo+ID4gKwl0MWtfeCA9ICh4ICUgMzIpIC8gMTY7Cj4gPiArCXQxa195 ID0gKHkgJSAzMikgLyAxNjsKPiA+ICsKPiA+ICsJaW5kZXggPSAyICogdDFrX3kgKyB0MWtfeDsK PiA+ICsKPiA+ICsJaWYgKHQ0a195ICUgMikgewo+ID4gKwkJLyogT2RkIHJvd3Mgc3RhcnQgZnJv bSB0aGUgcmlnaHQuICovCj4gPiArCQlvZmZzZXQgKz0gKHQ0a193IC0gdDRrX3ggLSAxKSAqIDMy ICogMzI7Cj4gPiArCQlvZmZzZXQgKz0gdDFrX21hcF9vZGRbaW5kZXhdICogMTYgKiAxNjsKPiA+ ICsJfSBlbHNlIHsKPiA+ICsJCS8qIEV2ZW4gcm93cyBzdGFydCBmcm9tIHRoZSBsZWZ0LiAqLwo+ ID4gKwkJb2Zmc2V0ICs9IHQ0a194ICogMzIgKiAzMjsKPiA+ICsJCW9mZnNldCArPSB0MWtfbWFw X2V2ZW5baW5kZXhdICogMTYgKiAxNjsKPiA+ICsJfQo+ID4gKwo+ID4gKwkvKiBYIGFuZCBZIGNv b3JkaW5hdGVzIGluIG51bWJlciBvZiA2NCBieXRlIHRpbGVzICg0eDQpIHdpdGhpbiB0aGUgMUsK PiA+IHRpbGUuICovCj4gPiArCXQ2NGJfeCA9ICh4ICUgMTYpIC8gNDsKPiA+ICsJdDY0Yl95ID0g KHkgJSAxNikgLyA0Owo+ID4gKwo+ID4gKwkvKiBJbmNyZWFzZSBvZmZzZXQgdG8gdGhlIGJlZ2lu bmluZyBvZiB0aGUgY29ycmVzcG9uZGluZyA2NCBieXRlIHRpbGUuCj4gPiAqLwo+ID4gKwlvZmZz ZXQgKz0gdDY0Yl95ICogNCAqIDQgKiA0ICsgdDY0Yl94ICogNCAqIDQ7Cj4gPiArCj4gPiArCS8q IFggYW5kIFkgY29vcmRpbmF0ZXMgaW4gbnVtYmVyIG9mIHBpeGVscyB3aXRoaW4gdGhlIDY0IGJ5 dGUgdGlsZS4gKi8KPiA+ICsJcGl4X3ggPSB4ICUgNDsKPiA+ICsJcGl4X3kgPSB5ICUgNDsKPiA+ ICsKPiA+ICsJLyogSW5jcmVhc2Ugb2Zmc2V0IHRvIHRoZSBjb3JyZWN0IHBpeGVsLiAqLwo+ID4g KwlvZmZzZXQgKz0gcGl4X3kgKiA0ICsgcGl4X3g7Cj4gPiArCj4gPiArCS8qIE11bHRpcGx5IGJ5 IHRoZSBudW1iZXIgb2YgYnl0ZXMgcGVyIHBpeGVsIGZvciB0aGUgZm9ybWF0LiAqLwo+ID4gKwlv ZmZzZXQgKj0gNDsKPiA+ICsKPiA+ICsJcmV0dXJuIG9mZnNldDsKPiA+ICt9Cj4gPiBkaWZmIC0t Z2l0IGEvbGliL2lndF92YzQuaCBiL2xpYi9pZ3RfdmM0LmgKPiA+IGluZGV4IGViYzhhMzg4Li5h YjQ0Zjc3MSAxMDA2NDQKPiA+IC0tLSBhL2xpYi9pZ3RfdmM0LmgKPiA+ICsrKyBiL2xpYi9pZ3Rf dmM0LmgKPiA+IEBAIC0zMyw0ICszMyw4IEBAIGJvb2wgaWd0X3ZjNF9wdXJnZWFibGVfYm8oaW50 IGZkLCBpbnQgaGFuZGxlLCBib29sCj4gPiBwdXJnZWFibGUpOwo+ID4gIHZvaWQgaWd0X3ZjNF9z ZXRfdGlsaW5nKGludCBmZCwgdWludDMyX3QgaGFuZGxlLCB1aW50NjRfdCBtb2RpZmllcik7Cj4g PiAgdWludDY0X3QgaWd0X3ZjNF9nZXRfdGlsaW5nKGludCBmZCwgdWludDMyX3QgaGFuZGxlKTsK PiA+ICAKPiA+ICt1bnNpZ25lZCBpbnQgaWd0X3ZjNF9mYl90X3RpbGVkX2NvbnZlcnQoc3RydWN0 IGlndF9mYiAqZHN0LCBzdHJ1Y3QgaWd0X2ZiCj4gPiAqc3JjKTsKPiA+ICtzaXplX3QgaWd0X3Zj NF90X3RpbGVkX29mZnNldChzaXplX3Qgd2lkdGgsIHNpemVfdCBoZWlnaHQsIHNpemVfdCBmb3Jt YXQsCj4gPiArCQkJICAgICAgc2l6ZV90IHgsIHNpemVfdCB5KTsKPiA+ICsKPiA+ICAjZW5kaWYg LyogSUdUX1ZDNF9IICovCi0tIApQYXVsIEtvY2lhbGtvd3NraSwgQm9vdGxpbiAoZm9ybWVybHkg RnJlZSBFbGVjdHJvbnMpCkVtYmVkZGVkIExpbnV4IGFuZCBrZXJuZWwgZW5naW5lZXJpbmcKaHR0 cHM6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2 Cg==