Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Laguna, Lukasz" <lukasz.laguna@intel.com>
To: "Piórkowski, Piotr" <piotr.piorkowski@intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [i-g-t,v2,1/2] lib/intel_mmio: Map the whole BAR0 for gen12+
Date: Fri, 29 Mar 2024 10:36:14 +0100	[thread overview]
Message-ID: <f21e5837-b74d-4e36-818f-6f61c2d43d60@intel.com> (raw)
In-Reply-To: <20240326100921.3539141-2-piotr.piorkowski@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]


On 3/26/2024 11:09, Piórkowski, Piotr wrote:
> From: Piotr Piórkowski<piotr.piorkowski@intel.com>
>
> Previously, we limited BAR0 mapping to register space only because of
> the potential conflict with wc mapping for the GTT region.
> For gen12+ platforms, the size of BAR0 varies due to the different amount
> of tile.
> And as for gen11+ platforms, we can already map the whole BAR0 as uc,
> so let's map the whole BAR0, without artificial limitations.
>
> Signed-off-by: Piotr Piórkowski<piotr.piorkowski@intel.com>
> ---
>   lib/intel_mmio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/intel_mmio.c b/lib/intel_mmio.c
> index 4b6820787..31975727e 100644
> --- a/lib/intel_mmio.c
> +++ b/lib/intel_mmio.c
> @@ -154,7 +154,7 @@ intel_mmio_use_pci_bar(struct intel_mmio_data *mmio_data, struct pci_device *pci
>   
>   	gen = intel_gen(devid);
>   	if (gen >= 12)
> -		mmio_size = 8 * 1024 * 1024;
> +		mmio_size = pci_dev->regions[mmio_bar].size;
>   	else if (gen >= 5)
>   		mmio_size = 2 * 1024 * 1024;
>   	else

Reviewed-by: Lukasz Laguna <lukasz.laguna@intel.com 
<mailto:lukasz.laguna@intel.com>>

[-- Attachment #2: Type: text/html, Size: 1821 bytes --]

  reply	other threads:[~2024-03-29  9:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 10:09 [PATCH i-g-t,v2 0/2] lib/xe_mmio: Introduce Xe MMIO lib Piórkowski, Piotr
2024-03-26 10:09 ` [PATCH i-g-t,v2 1/2] lib/intel_mmio: Map the whole BAR0 for gen12+ Piórkowski, Piotr
2024-03-29  9:36   ` Laguna, Lukasz [this message]
2024-03-26 10:09 ` [PATCH i-g-t,v2 2/2] lib/xe_mmio: Introduce Xe MMIO lib Piórkowski, Piotr
2024-03-29  9:35   ` [i-g-t,v2,2/2] " Laguna, Lukasz
2024-04-03  9:57     ` Piotr Piórkowski
2024-03-26 15:51 ` ✓ CI.xeBAT: success for lib/xe_mmio: Introduce Xe MMIO lib (rev2) Patchwork
2024-03-26 16:09 ` ✓ Fi.CI.BAT: " Patchwork
2024-03-27 13:38 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f21e5837-b74d-4e36-818f-6f61c2d43d60@intel.com \
    --to=lukasz.laguna@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=piotr.piorkowski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox