Re: [PATCH i-g-t v4 3/5] lib/intel_compute: Use user offsets and loop size if provided

["Sharma, Nishit" <nishit.sharma@intel.com>]

On 3/3/2026 7:17 PM, Zbigniew Kempczyński wrote:
> If user passes its own input/output or number of iterations start
> to use it instead of hardcoded ones. This pattern was already used
> in other pipelines and only Xe3p missed this.
> Small Nitpick: Description

lib/intel_compute: Improve Xe3p pipeline flexibility by allowing 
user-provided input/output buffers and iteration count

This updates Xe3P compute pipeline to use user-supplied input and output 
buffer addresses as well as user-defined iterations/loop count

when provided. Previously, pipeline used hardcoded buffer addresses and 
iteration counts and ignored user overrides. With this change

Xe3P correctly used user-supplied buffers and counts.

Otherwise LGTM

Acked-by: Nishit Sharma <nishit.sharma@intel.com>

> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Nishit Sharma <nishit.sharma@intel.com>
> ---
>   lib/intel_compute.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/intel_compute.c b/lib/intel_compute.c
> index 1165bdafd9..bfe0a75a7c 100644
> --- a/lib/intel_compute.c
> +++ b/lib/intel_compute.c
> @@ -2189,6 +2189,8 @@ static void xe3p_compute_exec(int fd, const unsigned char *kernel,
>   	struct inline_data idata = {};
>   	struct bo_execenv execenv;
>   	float *input_data, *output_data;
> +	uint64_t bind_input_addr = (user && user->input_addr) ? user->input_addr : ADDR_INPUT;
> +	uint64_t bind_output_addr = (user && user->output_addr) ? user->output_addr : ADDR_OUTPUT;
>   	uint64_t indirect_addr = ADDR_GENERAL_STATE_BASE + OFFSET_INDIRECT_DATA_START;
>   	int entries = ARRAY_SIZE(bo_dict);
>   	int64_t timeout_one_ns = 1;
> @@ -2205,7 +2207,7 @@ static void xe3p_compute_exec(int fd, const unsigned char *kernel,
>   	memcpy(bo_dict[0].data, kernel, size);
>   	memset(bo_dict[1].data, 0, 4096);
>   
> -	xe3p_create_indirect_data(bo_dict[1].data, ADDR_INPUT, ADDR_OUTPUT,
> +	xe3p_create_indirect_data(bo_dict[1].data, bind_input_addr, bind_output_addr,
>   				  execenv.loop_count);
>   	idata.xe3p.indirect_addr_lo = indirect_addr;
>   	idata.xe3p.indirect_addr_hi = indirect_addr >> 32;
> @@ -2233,7 +2235,7 @@ static void xe3p_compute_exec(int fd, const unsigned char *kernel,
>   	}
>   
>   	if (!user || (user && !user->skip_results_check))
> -		bo_check_square(input_data, output_data, execenv.array_size);
> +		bo_check_square(input_data, output_data, execenv.loop_count);
>   
>   	bo_execenv_unbind(&execenv, bo_dict, entries);
>   	bo_execenv_destroy(&execenv);