From: "Ser, Simon" <simon.ser@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"Latvala, Petri" <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] meson: Remove invalid required argument
Date: Mon, 20 May 2019 10:02:59 +0000 [thread overview]
Message-ID: <f34a61c603a8e76b82fce4c4c41806a361260bfb.camel@intel.com> (raw)
In-Reply-To: <20190520093924.9525-1-petri.latvala@intel.com>
On Mon, 2019-05-20 at 12:39 +0300, Petri Latvala wrote:
> declare_dependency doesn't take a 'required' argument.
>
> meson.build:207: WARNING: Passed invalid keyword argument "required".
> WARNING: This will become a hard error in the future.
>
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Simon Ser <simon.ser@intel.com>
Derp. Thanks for spotting this!
Reviewed-by: Simon Ser <simon.ser@intel.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index a05e912c..2af08f9a 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -210,7 +210,7 @@ if _build_chamelium
> xmlrpc_client,
> gsl,
> alsa,
> - ], required : _chamelium_required)
> + ])
> if xmlrpc.found() and xmlrpc_util.found() and
> xmlrpc_client.found() and gsl.found() and alsa.found() and
> libcurl.found()
> config.set('HAVE_CHAMELIUM', 1)
> chameliuminfo = 'Yes'
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-05-20 10:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 9:39 [igt-dev] [PATCH i-g-t] meson: Remove invalid required argument Petri Latvala
2019-05-20 10:02 ` Ser, Simon [this message]
2019-05-20 10:31 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2019-05-20 10:36 ` Petri Latvala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f34a61c603a8e76b82fce4c4c41806a361260bfb.camel@intel.com \
--to=simon.ser@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox