From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E3C210EB8D for ; Fri, 30 Sep 2022 06:46:22 +0000 (UTC) Message-ID: Date: Fri, 30 Sep 2022 12:16:08 +0530 Content-Language: en-US To: Bhanuprakash Modem , References: <20220922160004.2041598-1-bhanuprakash.modem@intel.com> <20220922160004.2041598-48-bhanuprakash.modem@intel.com> From: "Thasleem, Mohammed" In-Reply-To: <20220922160004.2041598-48-bhanuprakash.modem@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [i-g-t V4 47/52] tests/i915/kms_mmap_write_crc: Add support for Bigjoiner List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 9/22/2022 9:29 PM, Bhanuprakash Modem wrote: > This patch will add a check to Skip the subtest if a selected pipe/output > combo won't support Bigjoiner or 8K mode. > > Example: > * Pipe-D wont support a mode > 5K > * To use 8K mode on a pipe then consecutive pipe must be available & free. > > V2: - Use updated helper name > > Signed-off-by: Bhanuprakash Modem > --- > tests/i915/kms_mmap_write_crc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tests/i915/kms_mmap_write_crc.c b/tests/i915/kms_mmap_write_crc.c > index a57938b5..2153ee8a 100644 > --- a/tests/i915/kms_mmap_write_crc.c > +++ b/tests/i915/kms_mmap_write_crc.c > @@ -276,6 +276,12 @@ igt_main_args("n", NULL, NULL, opt_handler, NULL) > > igt_subtest_with_dynamic("main") { > for_each_pipe_with_valid_output(&data.display, pipe, output) { > + igt_display_reset(&data.display); > + > + igt_output_set_pipe(output, pipe); > + if (!i915_pipe_output_combo_valid(&data.display)) > + continue; > + > igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), > igt_output_name(output)) { > data.output = output; Reviewed-by: Mohammed Thasleem