From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Content-Type: multipart/alternative; boundary="===============4902070103251959979==" MIME-Version: 1.0 From: Patchwork To: "Bhanuprakash Modem" Date: Mon, 13 Nov 2023 11:51:02 -0000 Message-ID: <169987626228.24215.7204283394328763353@emeril.freedesktop.org> References: <20231113094353.1232575-1-bhanuprakash.modem@intel.com> In-Reply-To: <20231113094353.1232575-1-bhanuprakash.modem@intel.com> Subject: [igt-dev] =?utf-8?b?4pyXIEZpLkNJLkJBVDogZmFpbHVyZSBmb3IgUmV2ZXJ0?= =?utf-8?q?_=22syncobj=5Ftimeline=3A_don=27t_expect_EINVAL_for_WAIT=5FUNSU?= =?utf-8?q?BMITTED=2C_=7C_WAIT=5FAVAILABLE=22?= List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: igt-dev@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: --===============4902070103251959979== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit == Series Details == Series: Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE" URL : https://patchwork.freedesktop.org/series/126326/ State : failure == Summary == Series 126326 revision 1 was fully merged or fully failed: no git log --===============4902070103251959979== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Project List - Patchwork Patch Details
Series:Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE"
URL:https://patchwork.freedesktop.org/series/126326/
State:failure

Series 126326 revision 1 was fully merged or fully failed: no git log

--===============4902070103251959979==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 956D910E337 for ; Mon, 13 Nov 2023 09:53:46 +0000 (UTC) From: Bhanuprakash Modem To: igt-dev@lists.freedesktop.org Date: Mon, 13 Nov 2023 15:13:52 +0530 Message-Id: <20231113094353.1232575-1-bhanuprakash.modem@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [i-g-t] Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Ser Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: This reverts commit f6f5903348eff6510f8877043f9397a2a5cb94b3. This patch is causing the regression in CI. [1767/1775] Generating i915_tests.rst with a custom command FAILED: docs/testplan/i915_tests.rst ./igt_doc.py --config ../tests/intel/i915_test_config.json --rest docs/testplan/i915_tests.rst --check-testlist --igt-build-path ./build Warning: Documented igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted doesn't exist on source files Warning: Documented igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted-signaled doesn't exist on source files Warning: Documented igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted-submitted doesn't exist on source files Warning: Documented igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted-submitted-signaled doesn't exist on source files Warning: Documented igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted doesn't exist on source files Warning: Documented igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted-signaled doesn't exist on source files Warning: Documented igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted-submitted doesn't exist on source files Warning: Documented igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted-submitted-signaled doesn't exist on source files Warning: Documented igt@syncobj_timeline@invalid-single-wait-all-available-unsubmitted doesn't exist on source files Warning: Documented igt@syncobj_timeline@invalid-single-wait-available-unsubmitted doesn't exist on source files Warning: Missing documentation for igt@syncobj_timeline@etime-multi-wait-all-available-unsubmitted Warning: Missing documentation for igt@syncobj_timeline@etime-multi-wait-all-available-unsubmitted-signaled Warning: Missing documentation for igt@syncobj_timeline@etime-multi-wait-all-available-unsubmitted-submitted Warning: Missing documentation for igt@syncobj_timeline@etime-multi-wait-all-available-unsubmitted-submitted-signaled Warning: Missing documentation for igt@syncobj_timeline@etime-multi-wait-available-unsubmitted Warning: Missing documentation for igt@syncobj_timeline@etime-single-wait-all-available-unsubmitted Warning: Missing documentation for igt@syncobj_timeline@etime-single-wait-available-unsubmitted Warning: Missing documentation for igt@syncobj_timeline@multi-wait-available-unsubmitted-signaled Warning: Missing documentation for igt@syncobj_timeline@multi-wait-available-unsubmitted-submitted Warning: Missing documentation for igt@syncobj_timeline@multi-wait-available-unsubmitted-submitted-signaled Please refer: docs/test_documentation.md for more details [1771/1775] Compiling C object runner/runner_test.p/runner_tests.c.o ninja: build stopped: subcommand failed. Cc: Erik Kurzinger Cc: Zbigniew Kempczyński Cc: Simon Ser Signed-off-by: Bhanuprakash Modem --- tests/syncobj_timeline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/syncobj_timeline.c b/tests/syncobj_timeline.c index 0422bca51..b4e1d093a 100644 --- a/tests/syncobj_timeline.c +++ b/tests/syncobj_timeline.c @@ -1782,7 +1782,7 @@ igt_main WAIT_SIGNALED)) != 1) continue; - if ((flags & WAIT_UNSUBMITTED) && !((flags & WAIT_FOR_SUBMIT) || (flags & WAIT_AVAILABLE))) + if ((flags & WAIT_UNSUBMITTED) && !(flags & WAIT_FOR_SUBMIT)) err = -EINVAL; else if (!(flags & WAIT_SIGNALED) && !((flags & WAIT_SUBMITTED) && (flags & WAIT_AVAILABLE))) err = -ETIME; @@ -1851,7 +1851,7 @@ igt_main continue; err = 0; - if ((flags & WAIT_UNSUBMITTED) && !((flags & WAIT_FOR_SUBMIT) || (flags & WAIT_AVAILABLE))) { + if ((flags & WAIT_UNSUBMITTED) && !(flags & WAIT_FOR_SUBMIT)) { err = -EINVAL; } else if (flags & WAIT_ALL) { if (flags & (WAIT_UNSUBMITTED | WAIT_SUBMITTED)) -- 2.40.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-4317.proton.ch (mail-4317.proton.ch [185.70.43.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7CD3A10E337 for ; Mon, 13 Nov 2023 09:55:25 +0000 (UTC) Date: Mon, 13 Nov 2023 09:55:20 +0000 To: Bhanuprakash Modem From: Simon Ser Message-ID: <8HEEyr-hZOCEfFX_B7QVCqB5hDIu6JDdaZPl1vyqw6Ep-AMyApTLBdgROVNAKPiKb6fXfAr-Yqz-HcQ4evk3knZ-lGv5F9xjpILCCztDf4c=@emersion.fr> In-Reply-To: <20231113094353.1232575-1-bhanuprakash.modem@intel.com> References: <20231113094353.1232575-1-bhanuprakash.modem@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [i-g-t] Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: NACK. Please fix your docs/testplan/i915_tests.rst instead. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1509B10E337 for ; Mon, 13 Nov 2023 09:57:55 +0000 (UTC) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40a4d04af5cso12437695e9.0 for ; Mon, 13 Nov 2023 01:57:55 -0800 (PST) Message-ID: Date: Mon, 13 Nov 2023 11:57:45 +0200 MIME-Version: 1.0 Content-Language: en-US To: Bhanuprakash Modem , igt-dev@lists.freedesktop.org References: <20231113094353.1232575-1-bhanuprakash.modem@intel.com> From: Juha-Pekka Heikkila In-Reply-To: <20231113094353.1232575-1-bhanuprakash.modem@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [igt-dev] [i-g-t] Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: juhapekka.heikkila@gmail.com Cc: Simon Ser Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Acked-by: Juha-Pekka Heikkila On 13.11.2023 11.43, Bhanuprakash Modem wrote: > This reverts commit f6f5903348eff6510f8877043f9397a2a5cb94b3. > > This patch is causing the regression in CI. > > [1767/1775] Generating i915_tests.rst with a custom command > FAILED: docs/testplan/i915_tests.rst > ./igt_doc.py --config ../tests/intel/i915_test_config.json --rest docs/testplan/i915_tests.rst --check-testlist --igt-build-path ./build > Warning: Documented igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted doesn't exist on source files > Warning: Documented igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted-signaled doesn't exist on source files > Warning: Documented igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted-submitted doesn't exist on source files > Warning: Documented igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted-submitted-signaled doesn't exist on source files > Warning: Documented igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted doesn't exist on source files > Warning: Documented igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted-signaled doesn't exist on source files > Warning: Documented igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted-submitted doesn't exist on source files > Warning: Documented igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted-submitted-signaled doesn't exist on source files > Warning: Documented igt@syncobj_timeline@invalid-single-wait-all-available-unsubmitted doesn't exist on source files > Warning: Documented igt@syncobj_timeline@invalid-single-wait-available-unsubmitted doesn't exist on source files > Warning: Missing documentation for igt@syncobj_timeline@etime-multi-wait-all-available-unsubmitted > Warning: Missing documentation for igt@syncobj_timeline@etime-multi-wait-all-available-unsubmitted-signaled > Warning: Missing documentation for igt@syncobj_timeline@etime-multi-wait-all-available-unsubmitted-submitted > Warning: Missing documentation for igt@syncobj_timeline@etime-multi-wait-all-available-unsubmitted-submitted-signaled > Warning: Missing documentation for igt@syncobj_timeline@etime-multi-wait-available-unsubmitted > Warning: Missing documentation for igt@syncobj_timeline@etime-single-wait-all-available-unsubmitted > Warning: Missing documentation for igt@syncobj_timeline@etime-single-wait-available-unsubmitted > Warning: Missing documentation for igt@syncobj_timeline@multi-wait-available-unsubmitted-signaled > Warning: Missing documentation for igt@syncobj_timeline@multi-wait-available-unsubmitted-submitted > Warning: Missing documentation for igt@syncobj_timeline@multi-wait-available-unsubmitted-submitted-signaled > Please refer: docs/test_documentation.md for more details > [1771/1775] Compiling C object runner/runner_test.p/runner_tests.c.o > ninja: build stopped: subcommand failed. > > Cc: Erik Kurzinger > Cc: Zbigniew Kempczyński > Cc: Simon Ser > Signed-off-by: Bhanuprakash Modem > --- > tests/syncobj_timeline.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/syncobj_timeline.c b/tests/syncobj_timeline.c > index 0422bca51..b4e1d093a 100644 > --- a/tests/syncobj_timeline.c > +++ b/tests/syncobj_timeline.c > @@ -1782,7 +1782,7 @@ igt_main > WAIT_SIGNALED)) != 1) > continue; > > - if ((flags & WAIT_UNSUBMITTED) && !((flags & WAIT_FOR_SUBMIT) || (flags & WAIT_AVAILABLE))) > + if ((flags & WAIT_UNSUBMITTED) && !(flags & WAIT_FOR_SUBMIT)) > err = -EINVAL; > else if (!(flags & WAIT_SIGNALED) && !((flags & WAIT_SUBMITTED) && (flags & WAIT_AVAILABLE))) > err = -ETIME; > @@ -1851,7 +1851,7 @@ igt_main > continue; > > err = 0; > - if ((flags & WAIT_UNSUBMITTED) && !((flags & WAIT_FOR_SUBMIT) || (flags & WAIT_AVAILABLE))) { > + if ((flags & WAIT_UNSUBMITTED) && !(flags & WAIT_FOR_SUBMIT)) { > err = -EINVAL; > } else if (flags & WAIT_ALL) { > if (flags & (WAIT_UNSUBMITTED | WAIT_SUBMITTED)) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2DD0010E339 for ; Mon, 13 Nov 2023 09:59:29 +0000 (UTC) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40907b82ab9so29908615e9.1 for ; Mon, 13 Nov 2023 01:59:29 -0800 (PST) Message-ID: <11ff717a-06d2-49fd-b73d-0a372f1c80c8@gmail.com> Date: Mon, 13 Nov 2023 11:59:21 +0200 MIME-Version: 1.0 Content-Language: en-US To: Simon Ser , Bhanuprakash Modem References: <20231113094353.1232575-1-bhanuprakash.modem@intel.com> <8HEEyr-hZOCEfFX_B7QVCqB5hDIu6JDdaZPl1vyqw6Ep-AMyApTLBdgROVNAKPiKb6fXfAr-Yqz-HcQ4evk3knZ-lGv5F9xjpILCCztDf4c=@emersion.fr> From: Juha-Pekka Heikkila In-Reply-To: <8HEEyr-hZOCEfFX_B7QVCqB5hDIu6JDdaZPl1vyqw6Ep-AMyApTLBdgROVNAKPiKb6fXfAr-Yqz-HcQ4evk3knZ-lGv5F9xjpILCCztDf4c=@emersion.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [i-g-t] Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: juhapekka.heikkila@gmail.com Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 13.11.2023 11.55, Simon Ser wrote: > NACK. Please fix your docs/testplan/i915_tests.rst instead. Let's do fixes outside of master branch where it doesn't bother others. /Juha-Pekka From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-40136.proton.ch (mail-40136.proton.ch [185.70.40.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 016AE10E33E for ; Mon, 13 Nov 2023 10:02:19 +0000 (UTC) Date: Mon, 13 Nov 2023 10:02:07 +0000 To: juhapekka.heikkila@gmail.com From: Simon Ser Message-ID: <-X2kuWRq8oIQ1Lco4I-MR9aiuCxru-OYWgvZpjoaH-Vhou2l_0l7ojH97Xet1fRob4VpnlImB3BpP-lC0rTo80o4-xAYiK2hbo1_YgyD2ew=@emersion.fr> In-Reply-To: <11ff717a-06d2-49fd-b73d-0a372f1c80c8@gmail.com> References: <20231113094353.1232575-1-bhanuprakash.modem@intel.com> <8HEEyr-hZOCEfFX_B7QVCqB5hDIu6JDdaZPl1vyqw6Ep-AMyApTLBdgROVNAKPiKb6fXfAr-Yqz-HcQ4evk3knZ-lGv5F9xjpILCCztDf4c=@emersion.fr> <11ff717a-06d2-49fd-b73d-0a372f1c80c8@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [i-g-t] Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Monday, November 13th, 2023 at 10:59, Juha-Pekka Heikkila wrote: > On 13.11.2023 11.55, Simon Ser wrote: >=20 > > NACK. Please fix your docs/testplan/i915_tests.rst instead. >=20 > Let's do fixes outside of master branch where it doesn't bother others. Sorry, but no. This commit fixes a bug already. The CI regression is completely unrelated, and Intel-specific, I really don't understand why it happens in the first place. Is it by design that actual bug fixes break Intel CI? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4108A10E041 for ; Mon, 13 Nov 2023 10:04:47 +0000 (UTC) Message-ID: <7d479bc6-7a2e-97c8-b5c1-b90e0567e3d8@intel.com> Date: Mon, 13 Nov 2023 15:34:27 +0530 Content-Language: en-US To: Simon Ser References: <20231113094353.1232575-1-bhanuprakash.modem@intel.com> <8HEEyr-hZOCEfFX_B7QVCqB5hDIu6JDdaZPl1vyqw6Ep-AMyApTLBdgROVNAKPiKb6fXfAr-Yqz-HcQ4evk3knZ-lGv5F9xjpILCCztDf4c=@emersion.fr> From: "Modem, Bhanuprakash" In-Reply-To: <8HEEyr-hZOCEfFX_B7QVCqB5hDIu6JDdaZPl1vyqw6Ep-AMyApTLBdgROVNAKPiKb6fXfAr-Yqz-HcQ4evk3knZ-lGv5F9xjpILCCztDf4c=@emersion.fr> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [i-g-t] Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Mon-13-11-2023 03:25 pm, Simon Ser wrote: > NACK. Please fix your docs/testplan/i915_tests.rst instead. As "CI" won't pick the latest head, my patch can't go through the CI. And we can't guarantee that my fix may not end up in some other problem. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC7CE10E041 for ; Mon, 13 Nov 2023 10:07:03 +0000 (UTC) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-9e62ab773f1so400871866b.0 for ; Mon, 13 Nov 2023 02:07:03 -0800 (PST) Message-ID: <7e113968-b406-4753-a407-a7fc8ee3e908@gmail.com> Date: Mon, 13 Nov 2023 12:06:53 +0200 MIME-Version: 1.0 Content-Language: en-US To: Simon Ser References: <20231113094353.1232575-1-bhanuprakash.modem@intel.com> <8HEEyr-hZOCEfFX_B7QVCqB5hDIu6JDdaZPl1vyqw6Ep-AMyApTLBdgROVNAKPiKb6fXfAr-Yqz-HcQ4evk3knZ-lGv5F9xjpILCCztDf4c=@emersion.fr> <11ff717a-06d2-49fd-b73d-0a372f1c80c8@gmail.com> <-X2kuWRq8oIQ1Lco4I-MR9aiuCxru-OYWgvZpjoaH-Vhou2l_0l7ojH97Xet1fRob4VpnlImB3BpP-lC0rTo80o4-xAYiK2hbo1_YgyD2ew=@emersion.fr> From: Juha-Pekka Heikkila In-Reply-To: <-X2kuWRq8oIQ1Lco4I-MR9aiuCxru-OYWgvZpjoaH-Vhou2l_0l7ojH97Xet1fRob4VpnlImB3BpP-lC0rTo80o4-xAYiK2hbo1_YgyD2ew=@emersion.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [i-g-t] Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: juhapekka.heikkila@gmail.com Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 13.11.2023 12.02, Simon Ser wrote: > On Monday, November 13th, 2023 at 10:59, Juha-Pekka Heikkila wrote: > >> On 13.11.2023 11.55, Simon Ser wrote: >> >>> NACK. Please fix your docs/testplan/i915_tests.rst instead. >> >> Let's do fixes outside of master branch where it doesn't bother others. > > Sorry, but no. This commit fixes a bug already. The CI regression is > completely unrelated, and Intel-specific, I really don't understand why > it happens in the first place. > > Is it by design that actual bug fixes break Intel CI? As is this is blocking others totally unrelated to this. This patch never passed ci in the first place hence never should've been merged. Let's fix it somewhere else than on everyone's build machines independently. /Juha-Pekka From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-4317.proton.ch (mail-4317.proton.ch [185.70.43.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id CD18110E33F for ; Mon, 13 Nov 2023 10:31:11 +0000 (UTC) Date: Mon, 13 Nov 2023 10:30:55 +0000 To: juhapekka.heikkila@gmail.com From: Simon Ser Message-ID: In-Reply-To: <7e113968-b406-4753-a407-a7fc8ee3e908@gmail.com> References: <20231113094353.1232575-1-bhanuprakash.modem@intel.com> <8HEEyr-hZOCEfFX_B7QVCqB5hDIu6JDdaZPl1vyqw6Ep-AMyApTLBdgROVNAKPiKb6fXfAr-Yqz-HcQ4evk3knZ-lGv5F9xjpILCCztDf4c=@emersion.fr> <11ff717a-06d2-49fd-b73d-0a372f1c80c8@gmail.com> <-X2kuWRq8oIQ1Lco4I-MR9aiuCxru-OYWgvZpjoaH-Vhou2l_0l7ojH97Xet1fRob4VpnlImB3BpP-lC0rTo80o4-xAYiK2hbo1_YgyD2ew=@emersion.fr> <7e113968-b406-4753-a407-a7fc8ee3e908@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [i-g-t] Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Monday, November 13th, 2023 at 11:06, Juha-Pekka Heikkila wrote: > On 13.11.2023 12.02, Simon Ser wrote: >=20 > > On Monday, November 13th, 2023 at 10:59, Juha-Pekka Heikkila juhapekka.= heikkila@gmail.com wrote: > >=20 > > > On 13.11.2023 11.55, Simon Ser wrote: > > >=20 > > > > NACK. Please fix your docs/testplan/i915_tests.rst instead. > > >=20 > > > Let's do fixes outside of master branch where it doesn't bother other= s. > >=20 > > Sorry, but no. This commit fixes a bug already. The CI regression is > > completely unrelated, and Intel-specific, I really don't understand why > > it happens in the first place. > >=20 > > Is it by design that actual bug fixes break Intel CI? >=20 > As is this is blocking others totally unrelated to this. This patch > never passed ci in the first place hence never should've been merged. > Let's fix it somewhere else than on everyone's build machines independent= ly. If we want a quick fix, we can disable the broken Intel CI, instead of reverting a completely correct bugfix. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F0BB10E32F for ; Mon, 13 Nov 2023 10:44:49 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40859c464daso34658465e9.1 for ; Mon, 13 Nov 2023 02:44:49 -0800 (PST) Message-ID: Date: Mon, 13 Nov 2023 12:44:34 +0200 MIME-Version: 1.0 Content-Language: en-US To: Simon Ser References: <20231113094353.1232575-1-bhanuprakash.modem@intel.com> <8HEEyr-hZOCEfFX_B7QVCqB5hDIu6JDdaZPl1vyqw6Ep-AMyApTLBdgROVNAKPiKb6fXfAr-Yqz-HcQ4evk3knZ-lGv5F9xjpILCCztDf4c=@emersion.fr> <11ff717a-06d2-49fd-b73d-0a372f1c80c8@gmail.com> <-X2kuWRq8oIQ1Lco4I-MR9aiuCxru-OYWgvZpjoaH-Vhou2l_0l7ojH97Xet1fRob4VpnlImB3BpP-lC0rTo80o4-xAYiK2hbo1_YgyD2ew=@emersion.fr> <7e113968-b406-4753-a407-a7fc8ee3e908@gmail.com> From: Juha-Pekka Heikkila In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [i-g-t] Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: juhapekka.heikkila@gmail.com Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 13.11.2023 12.30, Simon Ser wrote: > On Monday, November 13th, 2023 at 11:06, Juha-Pekka Heikkila wrote: > >> On 13.11.2023 12.02, Simon Ser wrote: >> >>> On Monday, November 13th, 2023 at 10:59, Juha-Pekka Heikkila juhapekka.heikkila@gmail.com wrote: >>> >>>> On 13.11.2023 11.55, Simon Ser wrote: >>>> >>>>> NACK. Please fix your docs/testplan/i915_tests.rst instead. >>>> >>>> Let's do fixes outside of master branch where it doesn't bother others. >>> >>> Sorry, but no. This commit fixes a bug already. The CI regression is >>> completely unrelated, and Intel-specific, I really don't understand why >>> it happens in the first place. >>> >>> Is it by design that actual bug fixes break Intel CI? >> >> As is this is blocking others totally unrelated to this. This patch >> never passed ci in the first place hence never should've been merged. >> Let's fix it somewhere else than on everyone's build machines independently. > > If we want a quick fix, we can disable the broken Intel CI, instead of > reverting a completely correct bugfix. Simon, disabling CI doesn't universally fix the build for everyone. If you don't use testplan it's your story but it's not the story for all other igt users. Passing ci testing is the requirement for merging, that's why ci is running on patch sets. This reverted patch didn't even build in ci and after you merged it others started to see what ci already had reported about this patch. /Juha-Pekka From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-40136.proton.ch (mail-40136.proton.ch [185.70.40.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 77E0D10E35D for ; Mon, 13 Nov 2023 11:47:07 +0000 (UTC) Date: Mon, 13 Nov 2023 11:46:45 +0000 To: juhapekka.heikkila@gmail.com From: Simon Ser Message-ID: In-Reply-To: References: <20231113094353.1232575-1-bhanuprakash.modem@intel.com> <8HEEyr-hZOCEfFX_B7QVCqB5hDIu6JDdaZPl1vyqw6Ep-AMyApTLBdgROVNAKPiKb6fXfAr-Yqz-HcQ4evk3knZ-lGv5F9xjpILCCztDf4c=@emersion.fr> <11ff717a-06d2-49fd-b73d-0a372f1c80c8@gmail.com> <-X2kuWRq8oIQ1Lco4I-MR9aiuCxru-OYWgvZpjoaH-Vhou2l_0l7ojH97Xet1fRob4VpnlImB3BpP-lC0rTo80o4-xAYiK2hbo1_YgyD2ew=@emersion.fr> <7e113968-b406-4753-a407-a7fc8ee3e908@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [i-g-t] Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, Jani Nikula Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Apologies. Jani highlights that the bugfix does update the testlist (dynamically generated), and I completely missed that. The CI failure makes a lot more sense now.