From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5FB9989D43 for ; Wed, 31 Jul 2019 11:25:31 +0000 (UTC) From: "Ser, Simon" Date: Wed, 31 Jul 2019 11:25:29 +0000 Message-ID: References: <20190717181055.581-1-madhumitha.tolakanahalli.pradeep@intel.com> <6a7512c12f04cb23827f6d19536409b2359a7eb7.camel@intel.com> <43945c4d915ee825b3033d4d255bb96d276efcb4.camel@intel.com> In-Reply-To: <43945c4d915ee825b3033d4d255bb96d276efcb4.camel@intel.com> Content-Language: en-US Content-ID: MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH] lib/igt_kms.c igt_kms.h: tile property parser List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "igt-dev@lists.freedesktop.org" , "Tolakanahalli Pradeep, Madhumitha" Cc: "Navare, Manasi D" , "Latvala, Petri" List-ID: T24gVHVlLCAyMDE5LTA3LTMwIGF0IDE3OjUxIC0wNzAwLCBUb2xha2FuYWhhbGxpIFByYWRlZXAs IE1hZGh1bWl0aGEgd3JvdGU6DQo+IFRoYW5rIHlvdSBmb3IgeW91ciBjb21tZW50cywgU2ltb24u DQo+IA0KPiBJIGhhdmUgdGFrZW4gY2FyZSBvZiB0aGUgY29tbWVudHMgcmVnYXJkaW5nIHN0eWxl IGNoYW5nZXMuDQo+IA0KPiBPbiBUaHUsIDIwMTktMDctMTggYXQgMDc6MjQgKzAxMDAsIFNlciwg U2ltb24gd3JvdGU6DQo+ID4gSGksDQo+ID4gDQo+ID4gSGVyZSBhcmUgYSBmZXcgY29tbWVudHMu DQo+ID4gDQo+ID4gT24gV2VkLCAyMDE5LTA3LTE3IGF0IDExOjEwIC0wNzAwLCBNYWRodW1pdGhh IFRvbGFrYW5haGFsbGkgUHJhZGVlcA0KPiA+IHdyb3RlOg0KPiA+ID4gVGhlIHRpbGUgcHJvcGVy dHkgcGFyc2VyIHBhcnNlcyB0aGUgY29ubmVjdG9yIHRpbGUgcHJvcGVydHkNCj4gPiA+IG9idGFp bmVkDQo+ID4gPiBmcm9tIGNvbm5lY3RvcidzIERpc3BsYXkgSUQgYmxvY2sgYW5kIHNldCBwZXIg Y29ubmVjdG9yLg0KPiA+ID4gDQo+ID4gPiBDYzogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2 YXJlQGludGVsLmNvbT4NCj4gPiA+IENjOiBQZXRyaSBMYXR2YWxhIDxwZXRyaS5sYXR2YWxhQGlu dGVsLmNvbT4NCj4gPiA+IFNpZ25lZC1vZmYtYnk6IE1hZGh1bWl0aGEgVG9sYWthbmFoYWxsaSBQ cmFkZWVwIDwNCj4gPiA+IG1hZGh1bWl0aGEudG9sYWthbmFoYWxsaS5wcmFkZWVwQGludGVsLmNv bT4NCj4gPiA+IC0tLQ0KPiA+ID4gIGxpYi9pZ3Rfa21zLmMgfCAyNiArKysrKysrKysrKysrKysr KysrKysrKysrKw0KPiA+ID4gIGxpYi9pZ3Rfa21zLmggfCAxMSArKysrKysrKysrKw0KPiA+ID4g IDIgZmlsZXMgY2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKQ0KPiA+ID4gDQo+ID4gPiBkaWZmIC0t Z2l0IGEvbGliL2lndF9rbXMuYyBiL2xpYi9pZ3Rfa21zLmMNCj4gPiA+IGluZGV4IDE3NWU3MWMz Li44NDYzMTRkZSAxMDA2NDQNCj4gPiA+IC0tLSBhL2xpYi9pZ3Rfa21zLmMNCj4gPiA+ICsrKyBi L2xpYi9pZ3Rfa21zLmMNCj4gPiA+IEBAIC00NTExLDMgKzQ1MTEsMjkgQEAgYm9vbA0KPiA+ID4g aWd0X2Rpc3BsYXlfaGFzX2Zvcm1hdF9tb2QoaWd0X2Rpc3BsYXlfdCAqZGlzcGxheSwgdWludDMy X3QgZm9ybWF0LA0KPiA+ID4gIA0KPiA+ID4gIAlyZXR1cm4gZmFsc2U7DQo+ID4gPiAgfQ0KPiA+ ID4gKw0KPiA+ID4gKy8qKg0KPiA+ID4gKyAqIGlndF9wYXJzZV9jb25uZWN0b3JfdGlsZV9ibG9i Og0KPiA+ID4gKyAqIEBibG9iOiBwb2ludGVyIHRvIHRoZSBjb25uZWN0b3IncyB0aWxlIHByb3Bl cnRpZXMNCj4gPiA+ICsgKiBAdGlsZTogcG9pbnRlciB0byB0aWxlIHN0cnVjdHVyZSB0aGF0IGlz IHBvcHVsYXRlZCBieSB0aGUNCj4gPiA+IGZ1bmN0aW9uDQo+ID4gPiArICoNCj4gPiA+ICsgKiBQ YXJzZXMgdGhlIGNvbm5lY3RvciB0aWxlIGJsb2IgdG8gZXh0cmFjdCB0aGUgdGlsZSBpbmZvcm1h dGlvbg0KPiA+ID4gKyAqDQo+ID4gPiArICovDQo+ID4gPiArDQo+ID4gPiArdm9pZCBpZ3RfcGFy c2VfY29ubmVjdG9yX3RpbGVfYmxvYihkcm1Nb2RlUHJvcGVydHlCbG9iUHRyIGJsb2IsDQo+ID4g PiArCQkJCWlndF90aWxlX2luZm9fdCAqIHRpbGUpDQo+ID4gDQo+ID4gU3R5bGU6IGFsaWduIHdp dGggYXMgbWFueSB0YWJzIGFzIHBvc3NpYmxlLCB0aGVuIGZpbGwgdGhlIHJlc3Qgd2l0aA0KPiA+ IHNwYWNlcy4NCj4gPiANCj4gPiA+ICt7DQo+ID4gPiArCWNoYXIgKiBibG9iX2RhdGEgPSBibG9i LT5kYXRhOw0KPiA+IA0KPiA+IFN0eWxlOiBubyBzcGFjZSBhZnRlciBzdGFyLg0KPiA+IA0KPiA+ ICAgICBjaGFyICp0aGluZyA9IHN0dWZmOw0KPiA+IA0KPiA+IEFwcGxpZXMgdG8gdGhlIHdob2xl IHBhdGNoLg0KPiA+IA0KPiA+ID4gKwlpZihibG9iKSB7DQo+ID4gDQo+ID4gU3R5bGU6IHNwYWNl IGFmdGVyIGlmIGtleXdvcmQuDQo+ID4gDQo+ID4gPiArCQl0aWxlLT50aWxlX2dyb3VwX2lkID0g YXRvaShzdHJ0b2soYmxvYl9kYXRhLCAiOiIpKTsNCj4gPiANCj4gPiBUaGlzIHNlZ2ZhdWx0cyBp ZiB0aGUgZmllbGQgZG9lc24ndCBleGlzdC4gSXQgd291bGQgYmUgbmljZXIgdG8NCj4gPiBpZ3Rf YXNzZXJ0IHRoYXQgc3RydG9rIGRvZXNuJ3QgcmV0dXJuIE5VTEwuIE1heWJlIHdpdGggYSB3cmFw cGVyDQo+ID4gZnVuY3Rpb24/IGUuZy4NCj4gPiANCj4gPiAgICAgc3RhdGljIGludCBwYXJzZV9u ZXh0X3RpbGVfZmllbGQoY2hhciAqZGF0YSkNCj4gDQo+IFRoaXMgYmxvYiBpbmZvcm1hdGlvbiBp cyBvYnRhaW5lZCBmcm9tIHRoZSBrZXJuZWwNCj4gKGRybS9kcm1fY29ubmVjdG9yLmMpLiBJdCdz IGZvcm1hdCBpcyBkZWZpbmVkIGluDQo+IGRybV9jb25uZWN0b3Jfc2V0X3RpbGVfcHJvcGVydHko KSB0byBiZSBvZiB0aGUgZm9ybSBvZiA4IGludGVnZXJzIHVzaW5nDQo+ICc6JyBhcyBhIHNlcGFy YXRvci4gSGVuY2UsIHRoZSBmaWVsZCBub3QgZXhpc3Rpbmcgd291bGRuJ3QgYmUgYQ0KPiBwb3Nz aWJpbGl0eSwgd2hpY2ggaXMgd2h5IG5vIE5VTEwgcmV0dXJuIGNoZWNrcyBhcmUgYmVpbmcgcGVy Zm9ybWVkLg0KDQpHZW5lcmFsbHkgSUdUIHRlc3RzIGFzc3VtZSB0aGUga2VybmVsIGNvdWxkIGRv IGFueXRoaW5nLiBGb3IgaW5zdGFuY2UsDQphIGRyaXZlciBjb3VsZCByb2xsIGl0cyBvd24gbG9n aWMgaW5zdGVhZCBvZiB1c2luZw0KZHJtX2Nvbm5lY3Rvcl9zZXRfdGlsZV9wcm9wZXJ0eS4gT3Ig dGhlIFRJTEUgYmxvYiBmb3JtYXQgY291bGQgYmUNCmV4dGVuZGVkIGluIGEga2VybmVsIHBhdGNo LCBicmVha2luZyBiYWNrd2FyZHMgY29tcGF0aWJpbGl0eSBmb3IgYQ0KY29ybmVyIGNhc2UuDQoN CkkgYWdyZWUgaXQncyBub3QgdGhhdCBvZiBhIGJpZyBkZWFsIGZvciB0aGlzIHNwZWNpZmljIGNh c2UuIEknbSBmaW5lDQplaXRoZXIgd2F5Lg0KDQo+ID4gQWxzbyB0aGlzIGRvZXNuJ3QgY2hlY2sg Zm9yIGludGVnZXIgb3ZlcmZsb3dzLCBidXQgbm90IHN1cmUgaXQncw0KPiA+IHdvcnRoDQo+ID4g dGhlIGhhc3NsZS4NCj4gPiANCj4gPiA+ICsJCXRpbGUtPnRpbGVfaXNfc2luZ2xlX21vbml0b3Ig PSBhdG9pKHN0cnRvayhOVUxMLCAiOiIpKTsNCj4gPiA+ICsJCXRpbGUtPm51bV9oX3RpbGUgPSBh dG9pKHN0cnRvayhOVUxMLCAiOiIpKTsNCj4gPiA+ICsJCXRpbGUtPm51bV92X3RpbGUgPSBhdG9p KHN0cnRvayhOVUxMLCAiOiIpKTsNCj4gPiA+ICsJCXRpbGUtPnRpbGVfaF9sb2MgPSBhdG9pKHN0 cnRvayhOVUxMLCAiOiIpKTsNCj4gPiA+ICsJCXRpbGUtPnRpbGVfdl9sb2MgPSBhdG9pKHN0cnRv ayhOVUxMLCAiOiIpKTsNCj4gPiA+ICsJCXRpbGUtPnRpbGVfaF9zaXplID0gYXRvaShzdHJ0b2so TlVMTCwgIjoiKSk7DQo+ID4gPiArCQl0aWxlLT50aWxlX3Zfc2l6ZSA9IGF0b2koc3RydG9rKE5V TEwsICI6IikpOw0KPiA+ID4gKwl9DQo+ID4gPiArfQ0KPiA+ID4gZGlmZiAtLWdpdCBhL2xpYi9p Z3Rfa21zLmggYi9saWIvaWd0X2ttcy5oDQo+ID4gPiBpbmRleCAwNDg2NzM3Yi4uMDg0ODM1MDUg MTAwNjQ0DQo+ID4gPiAtLS0gYS9saWIvaWd0X2ttcy5oDQo+ID4gPiArKysgYi9saWIvaWd0X2tt cy5oDQo+ID4gPiBAQCAtMzg3LDYgKzM4NywxNCBAQCBzdHJ1Y3QgaWd0X2Rpc3BsYXkgew0KPiA+ ID4gIAlpbnQgZm9ybWF0X21vZF9jb3VudDsNCj4gPiA+ICB9Ow0KPiA+ID4gIA0KPiA+ID4gK3R5 cGVkZWYgc3RydWN0IHsNCj4gPiA+ICsJaW50IHRpbGVfZ3JvdXBfaWQ7DQo+ID4gPiArCWJvb2wg dGlsZV9pc19zaW5nbGVfbW9uaXRvcjsNCj4gPiA+ICsJdWludDhfdCBudW1faF90aWxlLCBudW1f dl90aWxlOw0KPiA+ID4gKwl1aW50OF90IHRpbGVfaF9sb2MsIHRpbGVfdl9sb2M7DQo+ID4gPiAr CXVpbnQxNl90IHRpbGVfaF9zaXplLCB0aWxlX3Zfc2l6ZTsNCj4gPiANCj4gPiBJIHdvdWxkbid0 IHJlcGVhdCB0aGUgdGlsZV8gcHJlZml4IGZvciBhbGwgb2YgdGhlc2UgZmllbGRzLCBpdCdzDQo+ ID4gYWxyZWFkeSBjbGVhciB0aGF0IGl0J3MgYWJvdXQgdGhlIHRpbGUgZnJvbSB0aGUgdHlwZSBu YW1lLg0KPiANCj4gVGhlIG5hbWluZyBjb252ZW50aW9uIG9mIHRoZSB0aWxlIHByb3BlcnRpZXMg Y29uZnJvbXMgdG8gdGhhdCBpbiB0aGUNCj4ga2VybmVsIHRvIG1haW50YWluIHVuaWZvcm1pdHku DQoNCkluZGVlZCwgdGhhdCBtYWtlcyBzZW5zZS4gQmV0dGVyIHRvIGtlZXAgaXQgdGhhdCB3YXku DQoNCj4gPiA+ICt9IGlndF90aWxlX2luZm9fdDsNCj4gPiANCj4gPiBJJ20gcGVyc29uYWxseSBu b3QgYSBmYW4gb2YgdHlwZWRlZnMsIGJ1dCBpdCBzZWVtcyBsaWtlIHRoZSByZXN0IG9mDQo+ID4g SUdUDQo+ID4gZG9lc24ndCBjYXJlLCBzbyBpdCdzIHByb2JhYmx5IGZpbmUuDQo+ID4gDQo+ID4g PiAgdm9pZCBpZ3RfZGlzcGxheV9yZXF1aXJlKGlndF9kaXNwbGF5X3QgKmRpc3BsYXksIGludCBk cm1fZmQpOw0KPiA+ID4gIHZvaWQgaWd0X2Rpc3BsYXlfZmluaShpZ3RfZGlzcGxheV90ICpkaXNw bGF5KTsNCj4gPiA+ICB2b2lkIGlndF9kaXNwbGF5X3Jlc2V0KGlndF9kaXNwbGF5X3QgKmRpc3Bs YXkpOw0KPiA+ID4gQEAgLTgzNSw0ICs4NDMsNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaWd0X3Zi bGFua19iZWZvcmUodWludDMyX3QNCj4gPiA+IGEsIHVpbnQzMl90IGIpDQo+ID4gPiAgCXJldHVy biBpZ3RfdmJsYW5rX2FmdGVyKGIsIGEpOw0KPiA+ID4gIH0NCj4gPiA+ICANCj4gPiA+ICt2b2lk IGlndF9wYXJzZV9jb25uZWN0b3JfdGlsZV9ibG9iKGRybU1vZGVQcm9wZXJ0eUJsb2JQdHIgYmxv YiwNCj4gPiA+ICsJCQlpZ3RfdGlsZV9pbmZvX3QgKiB0aWxlKTsNCj4gPiA+ICsNCj4gPiA+ICAj ZW5kaWYgLyogX19JR1RfS01TX0hfXyAqLw0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pZ3QtZGV2