From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20190329095402.29697-1-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Message-ID: Date: Mon, 1 Apr 2019 08:52:09 +0100 MIME-Version: 1.0 In-Reply-To: <20190329095402.29697-1-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_schedule: Verify that using HW semaphores doesn't block List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org, Tvrtko Ursulin List-ID: Ck9uIDI5LzAzLzIwMTkgMDk6NTQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBXZSBtYXkgdXNlIEhX IHNlbWFwaG9yZXMgdG8gc2NoZWR1bGUgbmVhcmx5LXJlYWR5IHdvcmsgc3VjaCB0aGF0IHRoZXkK PiBhcmUgYWxyZWFkeSBzcGlubmluZyBvbiB0aGUgR1BVIHdhaXRpbmcgZm9yIHRoZSBjb21wbGV0 aW9uIG9uIGFub3RoZXIKPiBlbmdpbmUuIEhvd2V2ZXIsIHdlIGRvbid0IHdhbnQgZm9yIHRoYXQg c3Bpbm5pbmcgdGFzayB0byBhY3R1YWxseSBibG9jawo+IGFueSByZWFsIHdvcmsgc2hvdWxkIGl0 IGJlIHNjaGVkdWxlZC4KPiAKPiB2MjogTm8gdHlwZW9mIGF1dG9zCj4gdjM6IERvbid0IGNoZWF0 LCBjaGVjayBnZW44IGFzIHdlbGwKPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1 bGluQGludGVsLmNvbT4KPiAtLS0KPiAgIHRlc3RzL2k5MTUvZ2VtX2V4ZWNfc2NoZWR1bGUuYyB8 IDg3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgIDEgZmlsZSBjaGFuZ2Vk LCA4NyBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL3Rlc3RzL2k5MTUvZ2VtX2V4ZWNf c2NoZWR1bGUuYyBiL3Rlc3RzL2k5MTUvZ2VtX2V4ZWNfc2NoZWR1bGUuYwo+IGluZGV4IDRmMDU3 N2I0ZS4uM2RmMzE5YmNjIDEwMDY0NAo+IC0tLSBhL3Rlc3RzL2k5MTUvZ2VtX2V4ZWNfc2NoZWR1 bGUuYwo+ICsrKyBiL3Rlc3RzL2k5MTUvZ2VtX2V4ZWNfc2NoZWR1bGUuYwo+IEBAIC00OCw2ICs0 OCwxMCBAQAo+ICAgCj4gICAjZGVmaW5lIE1BWF9DT05URVhUUyAxMDI0Cj4gICAKPiArI2RlZmlu ZSBMT0NBTF9JOTE1X0VYRUNfQlNEX1NISUZUICAgICAgKDEzKQo+ICsjZGVmaW5lIExPQ0FMX0k5 MTVfRVhFQ19CU0RfTUFTSyAgICAgICAoMyA8PCBMT0NBTF9JOTE1X0VYRUNfQlNEX1NISUZUKQo+ ICsjZGVmaW5lIEVOR0lORV9NQVNLICAoSTkxNV9FWEVDX1JJTkdfTUFTSyB8IExPQ0FMX0k5MTVf RVhFQ19CU0RfTUFTSykKPiArCj4gICBJR1RfVEVTVF9ERVNDUklQVElPTigiQ2hlY2sgdGhhdCB3 ZSBjYW4gY29udHJvbCB0aGUgb3JkZXIgb2YgZXhlY3V0aW9uIik7Cj4gICAKPiAgIHN0YXRpYyBp bmxpbmUKPiBAQCAtMzIwLDYgKzMyNCw4NiBAQCBzdGF0aWMgdm9pZCBzbW9rZXRlc3QoaW50IGZk LCB1bnNpZ25lZCByaW5nLCB1bnNpZ25lZCB0aW1lb3V0KQo+ICAgCX0KPiAgIH0KPiAgIAo+ICtz dGF0aWMgdWludDMyX3QgX19iYXRjaF9jcmVhdGUoaW50IGk5MTUsIHVpbnQzMl90IG9mZnNldCkK PiArewo+ICsJY29uc3QgdWludDMyX3QgYmJlID0gTUlfQkFUQ0hfQlVGRkVSX0VORDsKPiArCXVp bnQzMl90IGhhbmRsZTsKPiArCj4gKwloYW5kbGUgPSBnZW1fY3JlYXRlKGk5MTUsIEFMSUdOKG9m ZnNldCArIDQsIDQwOTYpKTsKPiArCWdlbV93cml0ZShpOTE1LCBoYW5kbGUsIG9mZnNldCwgJmJi ZSwgc2l6ZW9mKGJiZSkpOwo+ICsKPiArCXJldHVybiBoYW5kbGU7Cj4gK30KPiArCj4gK3N0YXRp YyB1aW50MzJfdCBiYXRjaF9jcmVhdGUoaW50IGk5MTUpCj4gK3sKPiArCXJldHVybiBfX2JhdGNo X2NyZWF0ZShpOTE1LCAwKTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgc2VtYXBob3JlX3VzZXJs b2NrKGludCBpOTE1KQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX2V4ZWNfb2JqZWN0MiBv YmogPSB7Cj4gKwkJLmhhbmRsZSA9IGJhdGNoX2NyZWF0ZShpOTE1KSwKPiArCX07Cj4gKwlpZ3Rf c3Bpbl90ICpzcGluID0gTlVMTDsKPiArCXVuc2lnbmVkIGludCBlbmdpbmU7Cj4gKwl1aW50MzJf dCBzY3JhdGNoOwo+ICsKPiArCWlndF9yZXF1aXJlKGdlbV9zY2hlZHVsZXJfaGFzX3NlbWFwaG9y ZXMoaTkxNSkpOwo+ICsKPiArCS8qCj4gKwkgKiBHaXZlbiB0aGUgdXNlIG9mIHNlbWFwaG9yZXMg dG8gZ292ZXJuIHBhcmFsbGVsIHN1Ym1pc3Npb24KPiArCSAqIG9mIG5lYXJseS1yZWFkeSB3b3Jr IHRvIEhXLCB3ZSBzdGlsbCB3YW50IHRvIHJ1biBhY3R1YWxseQo+ICsJICogcmVhZHkgd29yayBp bW1lZGlhdGVseS4gV2l0aG91dCBzZW1hcGhvcmVzLCB0aGUgZGVwZW5kZW50Cj4gKwkgKiB3b3Jr IHdvdWxkbid0IGJlIHN1Ym1pdHRlZCBzbyBvdXIgcmVhZHkgd29yayB3aWxsIHJ1bi4KPiArCSAq Lwo+ICsKPiArCXNjcmF0Y2ggPSBnZW1fY3JlYXRlKGk5MTUsIDQwOTYpOwo+ICsJZm9yX2VhY2hf cGh5c2ljYWxfZW5naW5lKGk5MTUsIGVuZ2luZSkgewo+ICsJCWlmICghc3Bpbikgewo+ICsJCQlz cGluID0gaWd0X3NwaW5fYmF0Y2hfbmV3KGk5MTUsCj4gKwkJCQkJCSAgLmRlcGVuZGVuY3kgPSBz Y3JhdGNoLAo+ICsJCQkJCQkgIC5lbmdpbmUgPSBlbmdpbmUpOwo+ICsJCX0gZWxzZSB7Cj4gKwkJ CXVpbnQ2NF90IHNhdmVkID0gc3Bpbi0+ZXhlY2J1Zi5mbGFnczsKPiArCj4gKwkJCXNwaW4tPmV4 ZWNidWYuZmxhZ3MgJj0gfkVOR0lORV9NQVNLOwo+ICsJCQlzcGluLT5leGVjYnVmLmZsYWdzIHw9 IGVuZ2luZTsKPiArCj4gKwkJCWdlbV9leGVjYnVmKGk5MTUsICZzcGluLT5leGVjYnVmKTsKPiAr Cj4gKwkJCXNwaW4tPmV4ZWNidWYuZmxhZ3MgPSBzYXZlZDsKPiArCQl9Cj4gKwl9Cj4gKwlpZ3Rf cmVxdWlyZShzcGluKTsKPiArCWdlbV9jbG9zZShpOTE1LCBzY3JhdGNoKTsKPiArCj4gKwkvKgo+ ICsJICogT24gYWxsIGRlcGVuZGVudCBlbmdpbmVzLCB0aGUgcmVxdWVzdCBtYXkgYmUgZXhlY3V0 aW5nIChidXN5d2FpdGluZwo+ICsJICogb24gYSBIVyBzZW1hcGhvcmUpIGJ1dCBpdCBzaG91bGQg bm90IHByZXZlbnQgYW55IHJlYWwgd29yayBmcm9tCj4gKwkgKiB0YWtpbmcgcHJlY2VkZW5jZS4K PiArCSAqLwo+ICsJc2NyYXRjaCA9IGdlbV9jb250ZXh0X2NyZWF0ZShpOTE1KTsKPiArCWZvcl9l YWNoX3BoeXNpY2FsX2VuZ2luZShpOTE1LCBlbmdpbmUpIHsKPiArCQlzdHJ1Y3QgZHJtX2k5MTVf Z2VtX2V4ZWNidWZmZXIyIGV4ZWNidWYgPSB7Cj4gKwkJCS5idWZmZXJzX3B0ciA9IHRvX3VzZXJf cG9pbnRlcigmb2JqKSwKPiArCQkJLmJ1ZmZlcl9jb3VudCA9IDEsCj4gKwkJCS5mbGFncyA9IGVu Z2luZSwKPiArCQkJLnJzdmQxID0gc2NyYXRjaCwKPiArCQl9Owo+ICsKPiArCQlpZiAoZW5naW5l ID09IChzcGluLT5leGVjYnVmLmZsYWdzICYgRU5HSU5FX01BU0spKQo+ICsJCQljb250aW51ZTsK PiArCj4gKwkJZ2VtX2V4ZWNidWYoaTkxNSwgJmV4ZWNidWYpOwo+ICsJfQo+ICsJZ2VtX2NvbnRl eHRfZGVzdHJveShpOTE1LCBzY3JhdGNoKTsKPiArCWdlbV9zeW5jKGk5MTUsIG9iai5oYW5kbGUp OyAvKiB0byBoYW5nIHVubGVzcyB3ZSBjYW4gcHJlZW1wdCAqLwo+ICsJZ2VtX2Nsb3NlKGk5MTUs IG9iai5oYW5kbGUpOwo+ICsKPiArCWlndF9zcGluX2JhdGNoX2ZyZWUoaTkxNSwgc3Bpbik7Cj4g K30KPiArCj4gICBzdGF0aWMgdm9pZCByZW9yZGVyKGludCBmZCwgdW5zaWduZWQgcmluZywgdW5z aWduZWQgZmxhZ3MpCj4gICAjZGVmaW5lIEVRVUFMIDEKPiAgIHsKPiBAQCAtMTMwNyw2ICsxMzkx LDkgQEAgaWd0X21haW4KPiAgIAkJCWlndF9yZXF1aXJlKGdlbV9zY2hlZHVsZXJfaGFzX2N0eF9w cmlvcml0eShmZCkpOwo+ICAgCQl9Cj4gICAKPiArCQlpZ3Rfc3VidGVzdCgic2VtYXBob3JlLXVz ZXIiKQo+ICsJCQlzZW1hcGhvcmVfdXNlcmxvY2soZmQpOwo+ICsKPiAgIAkJaWd0X3N1YnRlc3Qo InNtb2tldGVzdC1hbGwiKQo+ICAgCQkJc21va2V0ZXN0KGZkLCBBTExfRU5HSU5FUywgMzApOwo+ ICAgCj4gCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVs LmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p Z3QtZGV2