From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86E3D10E335 for ; Tue, 9 May 2023 07:22:36 +0000 (UTC) Message-ID: Date: Tue, 9 May 2023 12:51:48 +0530 Content-Language: en-US References: <20230504045726.2954788-1-bhanuprakash.modem@intel.com> <20230504045726.2954788-3-bhanuprakash.modem@intel.com> From: "Modem, Bhanuprakash" In-Reply-To: <20230504045726.2954788-3-bhanuprakash.modem@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [i-g-t 2/6] lib: Cache xe_device at driver open/close level List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: igt-dev@lists.freedesktop.org, ankit.k.nautiyal@intel.com, mchehab@kernel.org, kamil.konieczny@linux.intel.com, zbigniew.kempczynski@intel.com, karthik.b.s@intel.com, swati2.sharma@intel.com List-ID: On Thu-04-05-2023 10:27 am, Bhanuprakash Modem wrote: > Instead of caching the xe_device struct at subtest level, cache > just after opening the driver. And remove from the cache just > before closing the driver. > > Signed-off-by: Bhanuprakash Modem Cc: Janga Rahul Kumar > --- > lib/drmtest.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/lib/drmtest.c b/lib/drmtest.c > index 03b5239b2..f6cd8e500 100644 > --- a/lib/drmtest.c > +++ b/lib/drmtest.c > @@ -63,6 +63,7 @@ > #include "intel_reg.h" > #include "ioctl_wrappers.h" > #include "igt_dummyload.h" > +#include "xe/xe_query.h" > > /** > * SECTION:drmtest > @@ -601,6 +602,10 @@ int drm_open_driver(int chipset) > } > } > > + /* Cache xe_device struct. */ > + if (is_xe_device(fd)) > + xe_device_get(fd); > + > return fd; > } > > @@ -618,6 +623,10 @@ int drm_close_driver(int fd) > if (fd < 3) > return -1; > > + /* Remove xe_device from cache. */ > + if (is_xe_device(fd)) > + xe_device_put(fd); > + > return close(fd); > } >