Re: [igt-dev] [PATCH] lib/i915/drrs: close file handler after update DRRS setting

["Sharma, Swati2" <swati2.sharma@intel.com>]

LGTM

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 22-Oct-23 7:24 PM, Lee Shawn C wrote:
> After configure DRRS status, test tool has to release file handler
> properly to avoid unexpected problem.
> 
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Vidya Srinivas <vidya.srinivas@intel.com>
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Cc: Jouni Högander <jouni.hogander@intel.com>
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
>   lib/i915/intel_drrs.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/lib/i915/intel_drrs.c b/lib/i915/intel_drrs.c
> index 2f83e1394a61..deaec90d3f59 100644
> --- a/lib/i915/intel_drrs.c
> +++ b/lib/i915/intel_drrs.c
> @@ -69,6 +69,7 @@ static void drrs_set(int device, enum pipe pipe, unsigned int val)
>   	dir = igt_debugfs_pipe_dir(device, pipe, O_DIRECTORY);
>   	igt_require_fd(dir);
>   	ret = igt_sysfs_write(dir, "i915_drrs_ctl", buf, sizeof(buf) - 1);
> +	close(dir);
>   
>   	/*
>   	 * drrs_enable() is called on DRRS capable platform only,