Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Karolina Stolarek <karolina.stolarek@intel.com>
To: Vikas Srivastava <vikas.srivastava@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH] lib/intel_batchbuffer: Skip media-fill test for Graphics version 12.50 and above
Date: Thu, 9 Mar 2023 14:53:02 +0100	[thread overview]
Message-ID: <f8090d8c-c318-049e-b6ad-62dee798c74d@intel.com> (raw)
In-Reply-To: <20230302055424.75446-1-vikas.srivastava@intel.com>

On 2.03.2023 06:54, Vikas Srivastava wrote:
> From: Sinjan Kumar <sinjan.kumar@intel.com>
> 
> Xe_HP and beyond platforms does not have media pipeline.
> So, this test is not applicable for those platforms.
> 
> Cc: Chris Wilson <chris.p.wilson@linux.intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
> Cc: Zbigniew Kempczy��ski <zbigniew.kempczynski@intel.com>

Not sure if it's your git send-email playing tricks or something, but 
char coding is off. You can either try to force git to use UTF-8 or just 
write "Kempczynski" here.

With all tags corrected:

Reviewed-by: Karolina Stolarek <karolina.stolarek@intel.com>

> Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> Cc: Rahul Kumar <janga.rahul.kumar@intel.com>
> Reviewed-by: Chris Wilson <chris.p.wilson@linux.intel.com>
> Signed-off-by: Sinjan Kumar <sinjan.kumar@intel.com>
> Signed-off-by: Vikas Srivastava <vikas.srivastava@intel.com>
> ---
>   lib/intel_batchbuffer.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> index 59c788e68..cbb513f79 100644
> --- a/lib/intel_batchbuffer.c
> +++ b/lib/intel_batchbuffer.c
> @@ -643,7 +643,9 @@ igt_fillfunc_t igt_get_media_fillfunc(int devid)
>   {
>   	igt_fillfunc_t fill = NULL;
>   
> -	if (IS_GEN12(devid))
> +	if (intel_graphics_ver(devid) >= IP_VER(12, 50)) {
> +		/* current implementation defeatured PIPELINE_MEDIA */
> +	} else if (IS_GEN12(devid))
>   		fill = gen12_media_fillfunc;
>   	else if (IS_GEN9(devid) || IS_GEN10(devid) || IS_GEN11(devid))
>   		fill = gen9_media_fillfunc;

      parent reply	other threads:[~2023-03-09 13:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02  5:54 [igt-dev] [PATCH] lib/intel_batchbuffer: Skip media-fill test for Graphics version 12.50 and above Vikas Srivastava
2023-03-02  6:19 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2023-03-07 19:33 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/intel_batchbuffer: Skip media-fill test for Graphics version 12.50 and above (rev2) Patchwork
2023-03-09  8:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-03-09 13:53 ` Karolina Stolarek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8090d8c-c318-049e-b6ad-62dee798c74d@intel.com \
    --to=karolina.stolarek@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=vikas.srivastava@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox