From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 5599B6E4A6
 for <igt-dev@lists.freedesktop.org>; Thu, 22 Nov 2018 12:14:53 +0000 (UTC)
References: <20181121161023.1603-1-andi.shyti@intel.com>
 <20181121161023.1603-3-andi.shyti@intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Message-ID: <f8355c69-2b92-65c1-e51c-d309531d2db7@linux.intel.com>
Date: Thu, 22 Nov 2018 12:14:51 +0000
MIME-Version: 1.0
In-Reply-To: <20181121161023.1603-3-andi.shyti@intel.com>
Content-Language: en-US
Subject: Re: [igt-dev] [RFC v2 2/3] lib: implement new engine discovery
 interface
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Content-Transfer-Encoding: base64
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Andi Shyti <andi.shyti@intel.com>, IGT dev <igt-dev@lists.freedesktop.org>
Cc: Andi Shyti <andi@etezian.org>, Tvrtko Ursulin <tvrtko.ursulin@intel.com>
List-ID: <igt-dev@lists.freedesktop.org>

Ck9uIDIxLzExLzIwMTggMTY6MTAsIEFuZGkgU2h5dGkgd3JvdGU6Cj4gS2VybmVsIGNvbW1pdHM6
Cj4gCj4gWzFdIGFlOGY0NTQ0ZGQ4ZiAoImRybS9pOTE1OiBFbmdpbmUgZGlzY292ZXJ5IHF1ZXJ5
IikKPiBbMl0gMzFlN2QzNTY2N2EwICgiZHJtL2k5MTU6IEFsbG93IGEgY29udGV4dCB0byBkZWZp
bmUgaXRzIHNldCBvZiBlbmdpbmVzIikKPiAKPiBmcm9tIFsqXSByZXBvc2l0b3J5LCBpbXBsZW1l
bnQgYSBuZXcgd2F5IHVhcGkgZm9yIGVuZ2luZQo+IGRpc2NvdmVyeSB0aGF0IGNvbnNpc3QgaW4g
Zmlyc3QgY291cGxpbmcgY29udGV4dCB3aXRoIGVuZ2luZSBbMl0KPiBhbmQgdGhlbiBxdWVyeSB0
aGUgZW5naW5lcyB0aHJvdWdoIGEgc3BlY2lmaWMgc3RydWN0dXJlIFsxXS4KPiAKPiBJbiBpZ3Qg
dGhlIGNsYXNzaWMgd2F5IGZvciBkaXNjb3ZlcmluZyBlbmdpbmVzIGlzIGRvbmUgdHJob3VnaAoK
dHlwbyBpbiB0aHJvdWdoCgo+IHRoZSBmb3JfZWFjaF9waHlzaWNhbF9lbmdpbmUoKSBtYWNybywg
dGhhdCB3b3VsZCBiZSByZXBsYWNlZCBieQo+IHRoZSBuZXcgZm9yX2VhY2hfZW5naW5lX2N0eCgp
Lgo+IAo+IFsqXSBnaXQ6Ly9wZW9wbGUuZnJlZWRlc2t0b3Aub3JnL350dXJzdWxpbi9kcm0taW50
ZWwKPiAKPiBTaWduZWQtb2ZmLWJ5OiBBbmRpIFNoeXRpIDxhbmRpLnNoeXRpQGludGVsLmNvbT4K
PiAtLS0KPiAgIGxpYi9pZ3RfZ3QuYyB8IDgzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysKPiAgIGxpYi9pZ3RfZ3QuaCB8ICA4ICsrKysrCj4gICAy
IGZpbGVzIGNoYW5nZWQsIDkxIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL2ln
dF9ndC5jIGIvbGliL2lndF9ndC5jCj4gaW5kZXggYTIwNjE5MjQuLjRhN2I4NjcxIDEwMDY0NAo+
IC0tLSBhL2xpYi9pZ3RfZ3QuYwo+ICsrKyBiL2xpYi9pZ3RfZ3QuYwo+IEBAIC02NTAsMyArNjUw
LDg2IEBAIGJvb2wgZ2VtX3JpbmdfaGFzX3BoeXNpY2FsX2VuZ2luZShpbnQgZmQsIHVuc2lnbmVk
IHJpbmcpCj4gICAKPiAgIAlyZXR1cm4gZ2VtX2hhc19yaW5nKGZkLCByaW5nKTsKPiAgIH0KPiAr
Cj4gK3N0YXRpYyBzdHJ1Y3QgZHJtX2k5MTVfcXVlcnlfZW5naW5lX2luZm8gKl9fcXVlcnlfZW5n
aW5lcyhpbnQgZmQpCj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9xdWVyeSBxdWVyeTsKPiArCXN0
cnVjdCBkcm1faTkxNV9xdWVyeV9pdGVtIGl0ZW07Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcXVlcnlf
ZW5naW5lX2luZm8gKnF1ZXJ5X2VuZ2luZXM7Cj4gKwlzc2l6ZV90IHNpemUgPSBzaXplb2YoKnF1
ZXJ5X2VuZ2luZXMpICsgMTAgKiBzaXplb2YoKnF1ZXJ5X2VuZ2luZXMtPmVuZ2luZXMpOwoKWW91
J2xsIGhhdmUgdG8gY2hhbmdlIHRoaXMgaW4gdGhlIGZpbmFsIHZlcnNpb24gdG8gZHluYW1pY2Fs
bHkgcHJvYmUgdGhlIAphbW91bnQgb2Ygc3BhY2UgbmVlZGVkLgoKSWYgeW91IHNlbmQgb25lIERS
TV9JT0NUTF9JOTE1X1FVRVJZIHdpdGggdGhlIGxlbmd0aCBzZXQgdG8gemVybyBpdCB3aWxsIApy
ZXR1cm4geW91IHRoZSBhbW91bnQgb2Ygc3BhY2UgcmVxdWlyZWQgdG8gcmV0dXJuIGV2ZXJ5dGhp
bmcuCgo+ICsJaW50IGVycjsKPiArCj4gKwlxdWVyeV9lbmdpbmVzID0gbWFsbG9jKHNpemUpOwo+
ICsJaWYgKCFxdWVyeV9lbmdpbmVzKQo+ICsJCXJldHVybiBOVUxMOwoKV2UgcHJvYmFibHkgd2Fu
dCB0byBpZ3RfYXNzZXJ0IG9uIHRoaXMgc2luY2UgdGhlcmUgaXMgbm8gcG9pbnQgZ29pbmcgCmZ1
cnRoZXIuCgo+ICsKPiArCW1lbXNldCgmcXVlcnksIDAsIHNpemVvZihxdWVyeSkpOwo+ICsJbWVt
c2V0KCZpdGVtLCAwLCBzaXplb2YoaXRlbSkpOwoKRm9yIHRoZXNlIHR3byB5b3UgY2FuIHNhdmUg
c29tZSBsaW5lcyBieSBhZGRpbmcgYSBzdGF0aWMgaW5pdGlhbGl6ZXIgIj0gCnsgfTsiIHRvIHRo
ZSBkZWNsYXJhdGlvbiwgYnV0IGRvIGFzIHlvdSBwcmVmZXIuCgo+ICsJbWVtc2V0KHF1ZXJ5X2Vu
Z2luZXMsIDAsIHNpemVvZigqcXVlcnlfZW5naW5lcykpOwo+ICsKPiArCWl0ZW0ucXVlcnlfaWQg
PSBEUk1fSTkxNV9RVUVSWV9FTkdJTkVfSU5GTzsKPiArCWl0ZW0ubGVuZ3RoID0gc2l6ZTsKPiAr
CWl0ZW0uZmxhZ3MgPSAwOwoKQ2FuIHNraXAgc2luY2UgaXQgaXMgYWxyZWFkeSB6ZXJvLgoKPiAr
CWl0ZW0uZGF0YV9wdHIgPSB0b191c2VyX3BvaW50ZXIocXVlcnlfZW5naW5lcyk7Cj4gKwo+ICsJ
cXVlcnkuaXRlbXNfcHRyID0gdG9fdXNlcl9wb2ludGVyKCZpdGVtKTsKPiArCXF1ZXJ5Lm51bV9p
dGVtcyA9IDE7Cj4gKwo+ICsJZXJyID0gaWd0X2lvY3RsKGZkLCBEUk1fSU9DVExfSTkxNV9RVUVS
WSwgJnF1ZXJ5KTsKCkkgYW0gbm90IHN1cmUgYWJvdXQgdGhpcyBvbmUsIGJ1dCBhbSB0aGlua2lu
ZyB0aGF0IGhlcmUgd2Ugc2hvdWxkIApwcm9iYWJseSB1c2UgaW9jdGwoMykgZGlyZWN0bHkuIEkg
ZG9uJ3QgdGhpbmsgd2UgbmVlZCB0aGUgYXV0by1yZXRyeSBvbiAKRUlOVFIgYW5kIEVBR0FJTiBm
b3IgdGhpcyBvbmUuCgo+ICsJaWYgKGVycikgewoKU2hvdWxkIHdlIHBlcmhhcHMgaWd0X3JlcXVp
cmUgaW9jdGwgd29ya3M/IFNvIG5ldyBJR1Qgc2tpcHMgb24gb2xkIGtlcm5lbHMuCgo+ICsJCWZy
ZWUocXVlcnlfZW5naW5lcyk7Cj4gKwkJcmV0dXJuIE5VTCA+ICsJfQo+ICsKPiArCXJldHVybiBx
dWVyeV9lbmdpbmVzOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IF9fc2V0X3BhcmFtKGludCBmZCwg
dW5zaWduZWQgY3R4X2lkLAoKVXNlIHVpbnQzMl90IGZvciBjdHhfaWQgZm9yIGNvbnNpc3RlbmN5
LgoKPiArCQlzdHJ1Y3QgZHJtX2k5MTVfcXVlcnlfZW5naW5lX2luZm8gKnF1ZXJ5X2VuZ2luZSkK
PiArewo+ICsJaW50IGksIHJldDsKPiArCXN0cnVjdCBkcm1faTkxNV9nZW1fY29udGV4dF9wYXJh
bSBjdHhfcGFyYW07Cj4gKwlzdHJ1Y3QgaTkxNV9jb250ZXh0X3BhcmFtX2VuZ2luZXMgKmN0eF9l
bmdpbmU7Cj4gKwlzaXplX3Qgc2l6ZSA9IHNpemVvZihzdHJ1Y3QgaTkxNV9jb250ZXh0X3BhcmFt
X2VuZ2luZXMpICsKPiArCQkgICAgICBxdWVyeV9lbmdpbmUtPm51bV9lbmdpbmVzICoKPiArCQkg
ICAgICBzaXplb2YoKmN0eF9lbmdpbmUtPmNsYXNzX2luc3RhbmNlKTsKPiArCj4gKwljdHhfZW5n
aW5lID0gbWFsbG9jKHNpemUpOwo+ICsJaWYgKCFjdHhfZW5naW5lKQo+ICsJCXJldHVybiBlcnJu
bzsKCkFnYWluIHByb2JhYmx5IGJldHRlciB0byBqdXN0IGFzc2VydC4KCj4gKwo+ICsJY3R4X2Vu
Z2luZS0+ZXh0ZW5zaW9ucyA9IDA7Cj4gKwlmb3IgKGkgPSAwOyBpIDwgcXVlcnlfZW5naW5lLT5u
dW1fZW5naW5lczsgaSsrKSB7Cj4gKwkJY3R4X2VuZ2luZS0+Y2xhc3NfaW5zdGFuY2VbaV0uY2xh
c3MgPSBxdWVyeV9lbmdpbmUtPmVuZ2luZXNbaV0uY2xhc3M7Cj4gKwkJY3R4X2VuZ2luZS0+Y2xh
c3NfaW5zdGFuY2VbaV0uaW5zdGFuY2UgPSBxdWVyeV9lbmdpbmUtPmVuZ2luZXNbaV0uaW5zdGFu
Y2U7Cj4gKwl9Cj4gKwo+ICsJY3R4X3BhcmFtLmN0eF9pZCA9IGN0eF9pZDsKPiArCWN0eF9wYXJh
bS5zaXplID0gc2l6ZTsKPiArCWN0eF9wYXJhbS5wYXJhbSA9IEk5MTVfQ09OVEVYVF9QQVJBTV9F
TkdJTkVTOwo+ICsJY3R4X3BhcmFtLnZhbHVlID0gdG9fdXNlcl9wb2ludGVyKGN0eF9lbmdpbmUp
Owo+ICsKPiArCXJldCA9IGlndF9pb2N0bChmZCwgRFJNX0lPQ1RMX0k5MTVfR0VNX0NPTlRFWFRf
U0VUUEFSQU0sICZjdHhfcGFyYW0pOwoKU2FtZSBpZGVhIHRoYXQgd2Ugc2hvdWxkIHBlcmhhcHMg
c2tpcCBoZXJlIGFzIHdpdGggdGhlIHF1ZXJ5LgoKPiArCWZyZWUoY3R4X2VuZ2luZSk7Cj4gKwo+
ICsJcmV0dXJuIHJldDsKPiArfQo+ICsKPiAraW50IGdldF9lbmdpbmVzKGludCBmZCwgdWludDMy
X3QgY3R4X2lkKQoKc2V0dXBfY3R4X2VuZ2luZXM/CgpEb2VzIGl0IG5lZWQgdG8gYmUgZXhwb3J0
ZWQgb3IgaXQgY2FuIGJlIHN0YXRpYz8KCj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9xdWVyeV9l
bmdpbmVfaW5mbyAqcXVlcnlfZW5naW5lOwo+ICsJaW50IG47Cj4gKwo+ICsJcXVlcnlfZW5naW5l
ID0gX19xdWVyeV9lbmdpbmVzKGZkKTsKPiArCWlmICghcXVlcnlfZW5naW5lKQo+ICsJCXJldHVy
biAtMTsKPiArCj4gKwluID0gX19zZXRfcGFyYW0oZmQsIGN0eF9pZCwgcXVlcnlfZW5naW5lKTsK
PiArCWlmIChuIDwgMCkKPiArCQlyZXR1cm4gbjsKPiArCj4gKwluID0gcXVlcnlfZW5naW5lLT5u
dW1fZW5naW5lczsKPiArCWZyZWUocXVlcnlfZW5naW5lKTsKPiArCj4gKwlyZXR1cm4gbjsKPiAr
fQo+IGRpZmYgLS1naXQgYS9saWIvaWd0X2d0LmggYi9saWIvaWd0X2d0LmgKPiBpbmRleCA1NGU5
NWRhOS4uN2UyOTljMzEgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9ndC5oCj4gKysrIGIvbGliL2ln
dF9ndC5oCj4gQEAgLTg2LDggKzg2LDE2IEBAIGV4dGVybiBjb25zdCBzdHJ1Y3QgaW50ZWxfZXhl
Y3V0aW9uX2VuZ2luZSB7Cj4gICAJICAgICBlX18rKykgXAo+ICAgCQlmb3JfaWYgKGdlbV9yaW5n
X2hhc19waHlzaWNhbF9lbmdpbmUoZmRfXywgZmxhZ3NfXyA9IGVfXy0+ZXhlY19pZCB8IGVfXy0+
ZmxhZ3MpKQo+ICAgCj4gKyNkZWZpbmUgZm9yX2VhY2hfZW5naW5lX2N0eChmZCwgY3R4LCBlKSBc
CgpIaWdoIGxldmVsIGRlc2lnbiBxdWVzdGlvbjogRG8gd2Ugd2FudCAnZScgdG8gYmUgYW4gaW50
ZWdlciBvciBhIHN0cnVjdCAKZGVzY3JpYmluZyBlYWNoIGVuZ2luZT8KCj4gKwkJZm9yIChpbnQg
X19tLCBfX2UgPSAxOyAoX19tID0gZ2V0X2VuZ2luZXMoZmQsIGN0eCkpOyApIFwKPiArCQkJaWYg
KF9fZSA+IF9fbSkgXAo+ICsJCQkJYnJlYWs7IFwKPiArCQkJZWxzZSBcCj4gKwkJCQlmb3IoZSA9
IF9fZSA7IF9fZSA8PSBfX207IGUgPSArK19fZSkKCkkgYW0gc3RydWdnbGluZyB0byBmaWd1cmUg
dGhpcyBvdXQsIGJ1dCBpdCBpcyBwcm9iYWJseSBqdXN0IG1lLiBDYW4gaXQgCmNhdXNlIHNvbWUg
Y29tcGlsZXIgd2FybmluZ3MgZm9yIG1pc2xlYWRpbmcgYnJhY2VzLCBpbmRlbnQgb3Igd2hhdGV2
ZXIgCnRoZSB0aGluZ3MgYXJlIGl0IGNvdWxkIHdhcm4gaGVyZT8KCldvdWxkIHNvbWV0aGluZyBz
aW1wbGVyIG5vdCB3b3JrPwoKI2RlZmluZSBmb3JfZWFjaF9lbmdpbmVfY3R4KGZkLCBjdHgsIGUp
IFwKICAgIGZvciAoaW50IF9fZSA9IDAsIF9fbSA9IGdldF9lbmdpbmVzKGZkLCBjdHgpOwoJKGUp
ID0gX19lLCBfX2UgPCBfX207CglfX2UrKykKCkkgYW0gcHJvYmFibHkgbWlzc2luZyBzb21ldGhp
bmcgZWxlbWVudGFyeS4uLgoKCj4gKwo+ICAgYm9vbCBnZW1fcmluZ19pc19waHlzaWNhbF9lbmdp
bmUoaW50IGZkLCB1bnNpZ25lZCBpbnQgcmluZyk7Cj4gICBib29sIGdlbV9yaW5nX2hhc19waHlz
aWNhbF9lbmdpbmUoaW50IGZkLCB1bnNpZ25lZCBpbnQgcmluZyk7Cj4gK2ludCBnZXRfZW5naW5l
cyhpbnQgZmQsIHVpbnQzMl90IGN0eF9pZCk7Cj4gICAKPiAgIGJvb2wgZ2VtX2Nhbl9zdG9yZV9k
d29yZChpbnQgZmQsIHVuc2lnbmVkIGludCBlbmdpbmUpOwo+ICAgCj4gCgpSZWdhcmRzLAoKVHZy
dGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1k
ZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=