From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F1286F8A7 for ; Fri, 11 Jan 2019 17:54:58 +0000 (UTC) References: <20190111161548.15732-1-lukasz.kalamarz@intel.com> From: Daniele Ceraolo Spurio Message-ID: Date: Fri, 11 Jan 2019 09:54:56 -0800 MIME-Version: 1.0 In-Reply-To: <20190111161548.15732-1-lukasz.kalamarz@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t v3 1/4] lib/ioctl_wrapper: use defines for get_param instead of param number List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Lukasz Kalamarz , igt-dev@lists.freedesktop.org List-ID: CgpPbiAwMS8xMS8yMDE5IDA4OjE1IEFNLCBMdWthc3ogS2FsYW1hcnogd3JvdGU6Cj4gSW4gbGli IGNvZGUgdGhlcmUgd2VyZSBmZXcgZnVuY3Rpb25zIHVzaW5nIHBhcmFtIG51bWJlciBpbnN0ZWFk IG9mCj4gZGVmaW5lcy4gVGhpcyBjb3VsZCBsZWFkIHRvIHNvbWUgaXNzdWVzIChpLmUuIHN0b2xl biBzdXBwb3J0Cj4gcG9pbnRpbmcgb24gZGlmZmVyZW50IHBhcmFtZXRlcikgYW5kIHdlIHdvdWxk IGxpa2UgdG8gYXZvaWQgdGhlbS4KClRoZSAzIGRlZmluZXMgeW91J3JlIHRvdWNoaW5nIGFyZSBw YXJ0IG9mIHRoZSBwdWJsaXNoZWQga2VybmVsIHVhcGksIHNvIAp0aGVyZSBpcyBubyB3YXkgZm9y IHRoZW0gdG8gY2hhbmdlIGFuZCBjYXVzZSBpc3N1ZXMuIFRoZSBjaGFuZ2UgaXMgc3RpbGwgCndv cnRoIGRvaW5nIElNTyBzaW5jZSBkZWZpbmVzIGFyZSBiZXR0ZXIgdGhhbiBoYXJkLWNvZGVkIG51 bWJlcnMuCgo+IHYyOiBSZWJhc2VkIHBhdGNoCj4gCj4gU2lnbmVkLW9mZi1ieTogTHVrYXN6IEth bGFtYXJ6IDxsdWthc3oua2FsYW1hcnpAaW50ZWwuY29tPgo+IENjOiBNaWNoYWwgV2luaWFyc2tp IDxtaWNoYWwud2luaWFyc2tpQGludGVsLmNvbT4KPiBDYzogS2F0YXJ6eW5hIERlYyA8a2F0YXJ6 eW5hLmRlY0BpbnRlbC5jb20+Cj4gQ2M6IERhbmllbGUgQ2VyYW9sbyBTcHVyaW8gPGRhbmllbGUu Y2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+Cj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMt d2lsc29uLmNvLnVrPgoKQWxsIDMgZGVmcyBhcmUgaW4gdGhlIGk5MTVfZHJtLmggZmlsZSBpbiBJ R1QsIHNvIHdpdGggYSBjbGVhbmVkIGNvbW1pdCAKbWVzc2FnZToKClJldmlld2VkLWJ5OiBEYW5p ZWxlIENlcmFvbG8gU3B1cmlvIDxkYW5pZWxlLmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPgoKPiAt LS0KPiAgIGxpYi9pb2N0bF93cmFwcGVycy5jIHwgNiArKystLS0KPiAgIDEgZmlsZSBjaGFuZ2Vk LCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2xpYi9p b2N0bF93cmFwcGVycy5jIGIvbGliL2lvY3RsX3dyYXBwZXJzLmMKPiBpbmRleCA5ZjI1NTUwOC4u ZjcxZjBlMzIgMTAwNjQ0Cj4gLS0tIGEvbGliL2lvY3RsX3dyYXBwZXJzLmMKPiArKysgYi9saWIv aW9jdGxfd3JhcHBlcnMuYwo+IEBAIC03MDgsMTIgKzcwOCwxMiBAQCBib29sIGdlbV9tbWFwX19o YXNfd2MoaW50IGZkKQo+ICAgCQloYXNfd2MgPSAwOwo+ICAgCj4gICAJCW1lbXNldCgmZ3AsIDAs IHNpemVvZihncCkpOwo+IC0JCWdwLnBhcmFtID0gNDA7IC8qIE1NQVBfR1RUX1ZFUlNJT04gKi8K PiArCQlncC5wYXJhbSA9IEk5MTVfUEFSQU1fTU1BUF9HVFRfVkVSU0lPTjsKPiAgIAkJZ3AudmFs dWUgPSAmZ3R0X3ZlcnNpb247Cj4gICAJCWlvY3RsKGZkLCBEUk1fSU9DVExfSTkxNV9HRVRQQVJB TSwgJmdwKTsKPiAgIAo+ICAgCQltZW1zZXQoJmdwLCAwLCBzaXplb2YoZ3ApKTsKPiAtCQlncC5w YXJhbSA9IDMwOyAvKiBNTUFQX1ZFUlNJT04gKi8KPiArCQlncC5wYXJhbSA9IEk5MTVfUEFSQU1f TU1BUF9WRVJTSU9OOwo+ICAgCQlncC52YWx1ZSA9ICZtbWFwX3ZlcnNpb247Cj4gICAJCWlvY3Rs KGZkLCBEUk1fSU9DVExfSTkxNV9HRVRQQVJBTSwgJmdwKTsKPiAgIAo+IEBAIC05NjQsNyArOTY0 LDcgQEAgc3RhdGljIGludCBnZW1fZ3R0X3R5cGUoaW50IGZkKQo+ICAgCWludCB2YWwgPSAwOwo+ ICAgCj4gICAJbWVtc2V0KCZncCwgMCwgc2l6ZW9mKGdwKSk7Cj4gLQlncC5wYXJhbSA9IDE4OyAv KiBIQVNfQUxJQVNJTkdfUFBHVFQgKi8KPiArCWdwLnBhcmFtID0gSTkxNV9QQVJBTV9IQVNfQUxJ QVNJTkdfUFBHVFQ7Cj4gICAJZ3AudmFsdWUgPSAmdmFsOwo+ICAgCj4gICAJaWYgKGlvY3RsKGZk LCBEUk1fSU9DVExfSTkxNV9HRVRQQVJBTSwgJmdwLCBzaXplb2YoZ3ApKSkKPiAKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxp c3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==