Re: [igt-dev] [PATCH] Change igt log level from warn to info

["Shankar, Uma" <uma.shankar@intel.com>]

> -----Original Message-----
> From: B, Jeevan <jeevan.b@intel.com>
> Sent: Wednesday, September 8, 2021 12:48 AM
> To: igt-dev@lists.freedesktop.org
> Cc: Shankar, Uma <uma.shankar@intel.com>; B, Jeevan <jeevan.b@intel.com>
> Subject: [PATCH] Change igt log level from warn to info

Please prefix with the test fixed. Also since it's not done universally so in current form
the header is not right. Just say that "Drop log level for preventively unloading snd driver"

> change igt_warn to igt_info when unloading the snd module before unbinding i915
> until WA is fixed.

Try to give the reasoning as well as to why you are doing it.

Regards,
Uma Shankar
> 
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
>  tests/core_hotunplug.c | 2 +-
>  tests/device_reset.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c index
> 2d73e27f..b3661668 100644
> --- a/tests/core_hotunplug.c
> +++ b/tests/core_hotunplug.c
> @@ -164,7 +164,7 @@ static void driver_unbind(struct hotunplug *priv, const char
> *prefix,
>  			igt_lsof("/dev/snd");
>  			igt_skip("Audio is in use, skipping\n");
>  		} else {
> -			igt_warn("Preventively unloaded snd_hda_intel\n");
> +			igt_info("Preventively unloaded snd_hda_intel\n");
>  		}
>  	}
> 
> diff --git a/tests/device_reset.c b/tests/device_reset.c index e6a468e6..982ba5ef
> 100644
> --- a/tests/device_reset.c
> +++ b/tests/device_reset.c
> @@ -201,7 +201,7 @@ static void driver_unbind(struct device_fds *dev)
>  			igt_lsof("/dev/snd");
>  			igt_skip("Audio is in use, skipping\n");
>  		} else {
> -			igt_warn("Preventively unloaded snd_hda_intel\n");
> +			igt_info("Preventively unloaded snd_hda_intel\n");
>  		}
>  	}
> 
> --
> 2.19.1