From: "Reddy Guddati, Santhosh" <santhosh.reddy.guddati@intel.com>
To: Jeevan B <jeevan.b@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <vinod.govindapillai@intel.com>, <karthik.b.s@intel.com>
Subject: Re: [PATCH i-g-t] tests/intel/kms_dirtyfb: Fix misplaced parenthesis in display version check
Date: Fri, 4 Apr 2025 12:14:06 +0530 [thread overview]
Message-ID: <f970d9ff-d4ea-4802-b2fe-5dcd04cc8bd8@intel.com> (raw)
In-Reply-To: <20250404051503.2095885-1-jeevan.b@intel.com>
Hi Jeevan,
On 04-04-2025 10:45, Jeevan B wrote:
> Fixed a misplaced parenthesis in the FBC display version check to ensure
> correct tiling format selection.
>
> Fixes: f0b66883398b4a07bb8fcaa3663a2140129d9a58
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
LGTM
Reviewed-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
> ---
> tests/intel/kms_dirtyfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
> index 8efa14447..a5707c5b1 100644
> --- a/tests/intel/kms_dirtyfb.c
> +++ b/tests/intel/kms_dirtyfb.c
> @@ -386,7 +386,7 @@ igt_main
>
> /* FBC Disp_ver 8 and below supports only I915_FORMAT_MOD_X_TILED */
> if (data.feature == FEATURE_FBC &&
> - intel_display_ver(intel_get_drm_devid(data.drm_fd) <= 8))
> + intel_display_ver(intel_get_drm_devid(data.drm_fd)) <= 8)
> data.modifier = I915_FORMAT_MOD_X_TILED;
> else
> data.modifier = DRM_FORMAT_MOD_LINEAR;
next prev parent reply other threads:[~2025-04-04 6:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 5:15 [PATCH i-g-t] tests/intel/kms_dirtyfb: Fix misplaced parenthesis in display version check Jeevan B
2025-04-04 6:41 ` ✓ i915.CI.BAT: success for " Patchwork
2025-04-04 6:44 ` Reddy Guddati, Santhosh [this message]
2025-04-04 6:49 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-04 8:11 ` [PATCH i-g-t] " Govindapillai, Vinod
2025-04-04 8:21 ` ✓ i915.CI.Full: success for " Patchwork
2025-04-04 8:41 ` [PATCH i-g-t] " Sharma, Swati2
2025-04-04 9:04 ` Kamil Konieczny
2025-04-04 15:27 ` ✗ Xe.CI.Full: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f970d9ff-d4ea-4802-b2fe-5dcd04cc8bd8@intel.com \
--to=santhosh.reddy.guddati@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jeevan.b@intel.com \
--cc=karthik.b.s@intel.com \
--cc=vinod.govindapillai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox