Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Reset output->pipe after testing it.

Dhinakaran Pandiyan
2019-01-18T09:33:50Z

On Fri, 2019-01-18 at 09:20 +0200, Juha-Pekka Heikkilä wrote:
> Hi,
>
> I actually had this fix included here
> https://patchwork.freedesktop.org/patch/268867/
>
Ah, I didn't know you had sent a fix, apologies.

> my patch fixes also few other issues but it still need some work
> with
> gamma tables, I have there some mismatch.
Interesting, the only other failure I saw on my KBL was with NV12. I
sent a fix for that here
https://patchwork.freedesktop.org/series/55396/ - mind taking a look atthat as well?

>
> Your patch can go in on my behalf, I don't yet know how soon I get
> those
> gamma tables working so all crc's will start to pass.
>
> Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Thanks!

-DK

>
> Dhinakaran Pandiyan kirjoitti 17.1.2019 klo 21.34:
> > Not clearing the pipe results in a test failure when the same pipe
> > is
> > assigned to the next output.
> >
> > Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> > Suggested-by: James Ausmus <james.ausmus@intel.com>
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > ---
> > tests/kms_available_modes_crc.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/kms_available_modes_crc.c
> > b/tests/kms_available_modes_crc.c
> > index 45a47750..0c0282f8 100644
> > --- a/tests/kms_available_modes_crc.c
> > +++ b/tests/kms_available_modes_crc.c
> > @@ -484,6 +484,7 @@ test_available_modes(data_t* data)
> > igt_pipe_crc_stop(data->pipe_crc);
> > igt_pipe_crc_free(data->pipe_crc);
> > igt_display_commit2(&data->display, data->commit);
> > + igt_output_set_pipe(output, PIPE_NONE);
> > }
> > igt_assert(invalids == 0);
> > }
> >