From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Tvrtko Ursulin <tursulin@ursulin.net>,
igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/gem_set_tiling_vs_pwrite: Skip on unknown swizzling
Date: Thu, 11 Oct 2018 13:42:31 +0100 [thread overview]
Message-ID: <fb5ecccd-74c3-b83a-32a3-0f84d138baa2@linux.intel.com> (raw)
In-Reply-To: <153926124738.2691.8558923552654477730@skylake-alporthouse-com>
On 11/10/2018 13:34, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-10-11 13:30:27)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Same as in commit 78071c2fa53d ("igt/gem_tiled_partial_pwrite_pread: Check
>> for known swizzling"), to be able to compare the bo against the test
>> pattern we need to skip the test if the swizzling is not compatible.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102575
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> ---
>> Eeek confidence level low - is this correct?
>
> Actually this is a slightly more subtle problem,
> https://patchwork.freedesktop.org/patch/240327/
So assuming your patch is in, this IGT cannot actually work if any
swizzling is in effect? Or without your patch, it should skip based on
known_swizzling? Or is even that not enough?
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-10-11 12:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 12:30 [igt-dev] [PATCH i-g-t] tests/gem_set_tiling_vs_pwrite: Skip on unknown swizzling Tvrtko Ursulin
2018-10-11 12:34 ` Chris Wilson
2018-10-11 12:42 ` Tvrtko Ursulin [this message]
2018-10-11 12:49 ` Chris Wilson
2018-10-11 13:09 ` Tvrtko Ursulin
2018-10-11 13:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-10-11 21:20 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb5ecccd-74c3-b83a-32a3-0f84d138baa2@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=tursulin@ursulin.net \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox