From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id C95156E072 for ; Wed, 4 Dec 2019 00:38:47 +0000 (UTC) From: "Sripada, Radhakrishna" Date: Wed, 4 Dec 2019 00:38:46 +0000 Message-ID: References: <20191129134734.21965-1-mika.kahola@intel.com> <20191129134734.21965-4-mika.kahola@intel.com> In-Reply-To: <20191129134734.21965-4-mika.kahola@intel.com> Content-Language: en-US Content-ID: <5969852CDEF07B4AA96018A27D4AF06F@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 3/4] lib/igt_fb.c: Update tile sizes for GEN12 Color Clear List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "igt-dev@lists.freedesktop.org" , "Kahola, Mika" List-ID: T24gRnJpLCAyMDE5LTExLTI5IGF0IDE1OjQ3ICswMjAwLCBNaWthIEthaG9sYSB3cm90ZToNCj4g VXBkYXRlIHRpbGUgc2l6ZXMgZm9yIEdFTjEyIENvbG9yIENsZWFyLg0KPiANCj4gdjI6IFVwZGF0 ZSBudW1iZXIgb2YgcGxhbmVzIHRvIDMgaW4gY2FzZSBvZiBDQ1MgZm9ybWF0DQo+ICAgICBtb2Rp ZmllciAoUkspDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBNaWthIEthaG9sYSA8bWlrYS5rYWhvbGFA aW50ZWwuY29tPg0KUmV2aWV3ZWQtYnk6IFJhZGhha3Jpc2huYSBTcmlwYWRhPHJhZGhha3Jpc2hu YS5zcmlwYWRhQGludGVsLmNvbT4NCj4gLS0tDQo+ICBsaWIvaWd0X2ZiLmMgfCAzMCArKysrKysr KysrKysrKysrKysrKysrLS0tLS0tLS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25z KCspLCA4IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfZmIuYyBiL2xp Yi9pZ3RfZmIuYw0KPiBpbmRleCA1M2FhMzQ0YS4uNmNlN2NmZWEgMTAwNjQ0DQo+IC0tLSBhL2xp Yi9pZ3RfZmIuYw0KPiArKysgYi9saWIvaWd0X2ZiLmMNCj4gQEAgLTQwMiw2ICs0MDIsNyBAQCB2 b2lkIGlndF9nZXRfZmJfdGlsZV9zaXplKGludCBmZCwgdWludDY0X3QNCj4gbW9kaWZpZXIsIGlu dCBmYl9icHAsDQo+ICAJY2FzZSBMT0NBTF9JOTE1X0ZPUk1BVF9NT0RfWV9USUxFRDoNCj4gIAlj YXNlIExPQ0FMX0k5MTVfRk9STUFUX01PRF9ZX1RJTEVEX0NDUzoNCj4gIAljYXNlIExPQ0FMX0k5 MTVfRk9STUFUX01PRF9ZX1RJTEVEX0dFTjEyX1JDX0NDUzoNCj4gKwljYXNlIExPQ0FMX0k5MTVf Rk9STUFUX01PRF9ZX1RJTEVEX0dFTjEyX1JDX0NDU19DQzoNCj4gIAkJaWd0X3JlcXVpcmVfaW50 ZWwoZmQpOw0KPiAgCQlpZiAoaW50ZWxfZ2VuKGludGVsX2dldF9kcm1fZGV2aWQoZmQpKSA9PSAy KSB7DQo+ICAJCQkqd2lkdGhfcmV0ID0gMTI4Ow0KPiBAQCAtNDY4LDEzICs0NjksMTUgQEAgdm9p ZCBpZ3RfZ2V0X2ZiX3RpbGVfc2l6ZShpbnQgZmQsIHVpbnQ2NF90DQo+IG1vZGlmaWVyLCBpbnQg ZmJfYnBwLA0KPiAgDQo+ICBzdGF0aWMgYm9vbCBpc19nZW4xMl9jY3NfbW9kaWZpZXIodWludDY0 X3QgbW9kaWZpZXIpDQo+ICB7DQo+IC0JcmV0dXJuIG1vZGlmaWVyID09IEk5MTVfRk9STUFUX01P RF9ZX1RJTEVEX0dFTjEyX1JDX0NDUzsNCj4gKwlyZXR1cm4gbW9kaWZpZXIgPT0gSTkxNV9GT1JN QVRfTU9EX1lfVElMRURfR0VOMTJfUkNfQ0NTIHx8DQo+ICsJCW1vZGlmaWVyID09IEk5MTVfRk9S TUFUX01PRF9ZX1RJTEVEX0dFTjEyX1JDX0NDU19DQzsNCj4gIH0NCj4gIA0KPiAgc3RhdGljIGJv b2wgaXNfY2NzX21vZGlmaWVyKHVpbnQ2NF90IG1vZGlmaWVyKQ0KPiAgew0KPiAgDQo+IC0JcmV0 dXJuIGlzX2dlbjEyX2Njc19tb2RpZmllcihtb2RpZmllcikgfHwNCj4gKwlyZXR1cm4gbW9kaWZp ZXIgPT0gSTkxNV9GT1JNQVRfTU9EX1lfVElMRURfR0VOMTJfUkNfQ0NTIHx8DQo+ICsJCW1vZGlm aWVyID09IEk5MTVfRk9STUFUX01PRF9ZX1RJTEVEX0dFTjEyX1JDX0NDU19DQyB8fA0KPiAgCQlt b2RpZmllciA9PSBJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRF9DQ1MgfHwNCj4gIAkJbW9kaWZpZXIg PT0gSTkxNV9GT1JNQVRfTU9EX1lmX1RJTEVEX0NDUzsNCj4gIH0NCj4gQEAgLTQ4OSw2ICs0OTIs OCBAQCBzdGF0aWMgdW5zaWduZWQgZmJfcGxhbmVfd2lkdGgoY29uc3Qgc3RydWN0DQo+IGlndF9m YiAqZmIsIGludCBwbGFuZSkNCj4gIAkJCQkJICAgIDUxMiAvIChmYi0+cGxhbmVfYnBwWzBdIC8N Cj4gOCkpICogNjQ7DQo+ICAJCWVsc2UNCj4gIAkJCXJldHVybiBESVZfUk9VTkRfVVAoZmItPndp ZHRoLCAxMDI0KSAqIDEyODsNCj4gKwl9IGVsc2UgaWYgKGlzX2dlbjEyX2Njc19tb2RpZmllcihm Yi0+bW9kaWZpZXIpICYmIHBsYW5lID09IDIpIHsNCj4gKwkJcmV0dXJuIDY0Ow0KPiAgCX0NCj4g IA0KPiAgCWlmIChwbGFuZSA9PSAwKQ0KPiBAQCAtNTAxLDcgKzUwNiw3IEBAIHN0YXRpYyB1bnNp Z25lZCBmYl9wbGFuZV9icHAoY29uc3Qgc3RydWN0IGlndF9mYg0KPiAqZmIsIGludCBwbGFuZSkN Cj4gIHsNCj4gIAljb25zdCBzdHJ1Y3QgZm9ybWF0X2Rlc2Nfc3RydWN0ICpmb3JtYXQgPSBsb29r dXBfZHJtX2Zvcm1hdChmYi0NCj4gPmRybV9mb3JtYXQpOw0KPiAgDQo+IC0JaWYgKGlzX2Njc19t b2RpZmllcihmYi0+bW9kaWZpZXIpICYmIHBsYW5lID09IDEpDQo+ICsJaWYgKGlzX2Njc19tb2Rp ZmllcihmYi0+bW9kaWZpZXIpICYmIChwbGFuZSA9PSAxIHx8IHBsYW5lID09DQo+IDIpKQ0KPiAg CQlyZXR1cm4gODsNCj4gIAllbHNlDQo+ICAJCXJldHVybiBmb3JtYXQtPnBsYW5lX2JwcFtwbGFu ZV07DQo+IEBAIC01MTYsNyArNTIxLDggQEAgc3RhdGljIHVuc2lnbmVkIGZiX3BsYW5lX2hlaWdo dChjb25zdCBzdHJ1Y3QNCj4gaWd0X2ZiICpmYiwgaW50IHBsYW5lKQ0KPiAgCQkJcmV0dXJuIERJ Vl9ST1VORF9VUChmYi0+aGVpZ2h0LCAxMjgpICogNDsNCj4gIAkJZWxzZQ0KPiAgCQkJcmV0dXJu IERJVl9ST1VORF9VUChmYi0+aGVpZ2h0LCA1MTIpICogMzI7DQo+IC0JfQ0KPiArCX0gZWxzZSBp ZiAoaXNfZ2VuMTJfY2NzX21vZGlmaWVyKGZiLT5tb2RpZmllcikgJiYgcGxhbmUgPT0gMikNCj4g KwkJcmV0dXJuIDE7DQo+ICANCj4gIAlpZiAocGxhbmUgPT0gMCkNCj4gIAkJcmV0dXJuIGZiLT5o ZWlnaHQ7DQo+IEBAIC01MjgsMTAgKzUzNCwxNCBAQCBzdGF0aWMgaW50IGZiX251bV9wbGFuZXMo Y29uc3Qgc3RydWN0IGlndF9mYg0KPiAqZmIpDQo+ICB7DQo+ICAJY29uc3Qgc3RydWN0IGZvcm1h dF9kZXNjX3N0cnVjdCAqZm9ybWF0ID0gbG9va3VwX2RybV9mb3JtYXQoZmItDQo+ID5kcm1fZm9y bWF0KTsNCj4gIA0KPiAtCWlmIChpc19jY3NfbW9kaWZpZXIoZmItPm1vZGlmaWVyKSkNCj4gLQkJ cmV0dXJuIDI7DQo+IC0JZWxzZQ0KPiArCWlmIChpc19jY3NfbW9kaWZpZXIoZmItPm1vZGlmaWVy KSkgew0KPiArCQlpZiAoZmItPm1vZGlmaWVyID09DQo+IEk5MTVfRk9STUFUX01PRF9ZX1RJTEVE X0dFTjEyX1JDX0NDU19DQykNCj4gKwkJCXJldHVybiAzOw0KPiArCQllbHNlDQo+ICsJCQlyZXR1 cm4gMjsNCj4gKwl9IGVsc2Ugew0KPiAgCQlyZXR1cm4gZm9ybWF0LT5udW1fcGxhbmVzOw0KPiAr CX0NCj4gIH0NCj4gIA0KPiAgdm9pZCBpZ3RfaW5pdF9mYihzdHJ1Y3QgaWd0X2ZiICpmYiwgaW50 IGZkLCBpbnQgd2lkdGgsIGludCBoZWlnaHQsDQo+IEBAIC01OTIsNiArNjAyLDkgQEAgc3RhdGlj IHVpbnQzMl90IGNhbGNfcGxhbmVfc3RyaWRlKHN0cnVjdCBpZ3RfZmINCj4gKmZiLCBpbnQgcGxh bmUpDQo+ICAJfSBlbHNlIGlmIChpc19nZW4xMl9jY3NfbW9kaWZpZXIoZmItPm1vZGlmaWVyKSAm JiBwbGFuZSA9PSAxKSB7DQo+ICAJCS8qIEEgbWFpbiBzdXJmYWNlIHVzaW5nIGEgQ0NTIEFVWCBz dXJmYWNlIG11c3QgYmUgNHg0DQo+IHRpbGVzIGFsaWduZWQuICovDQo+ICAJCXJldHVybiBBTElH TihtaW5fc3RyaWRlLCA2NCk7DQo+ICsJfSBlbHNlIGlmIChpc19nZW4xMl9jY3NfbW9kaWZpZXIo ZmItPm1vZGlmaWVyKSAmJiBwbGFuZSA9PSAyKSB7DQo+ICsJCS8qIGNsZWFyIGNvbG9yIGFsd2F5 cyBmaXhlZCB0byA2NCBieXRlcyAqLw0KPiArCQlyZXR1cm4gNjQ7DQo+ICAJfSBlbHNlIHsNCj4g IAkJdW5zaWduZWQgaW50IHRpbGVfd2lkdGgsIHRpbGVfaGVpZ2h0Ow0KPiAgDQo+IEBAIC02MjYs NyArNjM5LDcgQEAgc3RhdGljIHVpbnQ2NF90IGNhbGNfcGxhbmVfc2l6ZShzdHJ1Y3QgaWd0X2Zi DQo+ICpmYiwgaW50IHBsYW5lKQ0KPiAgCQlzaXplID0gcm91bmR1cF9wb3dlcl9vZl90d28oc2l6 ZSk7DQo+ICANCj4gIAkJcmV0dXJuIHNpemU7DQo+IC0JfSBlbHNlIGlmIChpc19nZW4xMl9jY3Nf bW9kaWZpZXIoZmItPm1vZGlmaWVyKSAmJiBwbGFuZSA9PSAxKSB7DQo+ICsJfSBlbHNlIGlmIChp c19nZW4xMl9jY3NfbW9kaWZpZXIoZmItPm1vZGlmaWVyKSAmJiAocGxhbmUgPT0gMQ0KPiB8fCBw bGFuZSA9PSAyKSkgew0KPiAgCQkvKiBUaGUgQVVYIENDUyBzdXJmYWNlIG11c3QgYmUgcGFnZSBh bGlnbmVkICovDQo+ICAJCXJldHVybiAodWludDY0X3QpZmItPnN0cmlkZXNbcGxhbmVdICoNCj4g IAkJCUFMSUdOKGZiLT5wbGFuZV9oZWlnaHRbcGxhbmVdLCA2NCk7DQo+IEBAIC03MTksNiArNzMy LDcgQEAgdWludDY0X3QgaWd0X2ZiX21vZF90b190aWxpbmcodWludDY0X3QgbW9kaWZpZXIpDQo+ ICAJY2FzZSBMT0NBTF9JOTE1X0ZPUk1BVF9NT0RfWV9USUxFRDoNCj4gIAljYXNlIExPQ0FMX0k5 MTVfRk9STUFUX01PRF9ZX1RJTEVEX0NDUzoNCj4gIAljYXNlIExPQ0FMX0k5MTVfRk9STUFUX01P RF9ZX1RJTEVEX0dFTjEyX1JDX0NDUzoNCj4gKwljYXNlIExPQ0FMX0k5MTVfRk9STUFUX01PRF9Z X1RJTEVEX0dFTjEyX1JDX0NDU19DQzoNCj4gIAkJcmV0dXJuIEk5MTVfVElMSU5HX1k7DQo+ICAJ Y2FzZSBMT0NBTF9JOTE1X0ZPUk1BVF9NT0RfWWZfVElMRUQ6DQo+ICAJY2FzZSBMT0NBTF9JOTE1 X0ZPUk1BVF9NT0RfWWZfVElMRURfQ0NTOg0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pZ3QtZGV2