From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6137510E21D for ; Thu, 20 Apr 2023 05:19:33 +0000 (UTC) Message-ID: Date: Thu, 20 Apr 2023 10:49:11 +0530 Content-Language: en-US To: Karthik B S , "Nautiyal, Ankit K" , References: <20230419112243.1719789-1-bhanuprakash.modem@intel.com> <20230419112243.1719789-5-bhanuprakash.modem@intel.com> <2dd99ceb-e428-0bde-7339-d2fa808bfb6d@intel.com> From: "Modem, Bhanuprakash" In-Reply-To: <2dd99ceb-e428-0bde-7339-d2fa808bfb6d@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: Re: [igt-dev] [i-g-t V4 4/6] tests/i915/kms_psr: Use linear modifier to create FB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Thu-20-04-2023 10:42 am, Karthik B S wrote: > > On 4/20/2023 10:34 AM, Nautiyal, Ankit K wrote: >> >> On 4/19/2023 4:52 PM, Bhanuprakash Modem wrote: >>> To create a color framebuffer, nstead of using X-tiled use >>> liniear modifier. >> >> typos : instead, linear. >> >> Perhaps it can be reworded to specify that the change is to make the >> test compatible for drivers, only supporting >> >> linear modifiers. > > I agree with this. Please mention this reasoning as to why this change > is made. Sure, will update the commit message while merging the patch. Hope don't need to float a new rev. - Bhanu > > With this update the patch LGTM. > > Reviewed-by: Karthik B S > >> >> Otherwise the changes LGTM. >> >> Acked-by: Ankit Nautiyal >> >> >>> >>> Cc: Karthik B S >>> Signed-off-by: Bhanuprakash Modem >>> --- >>>   tests/i915/kms_psr.c | 4 ++-- >>>   1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/tests/i915/kms_psr.c b/tests/i915/kms_psr.c >>> index 3efe1faec..dfc2fbb65 100644 >>> --- a/tests/i915/kms_psr.c >>> +++ b/tests/i915/kms_psr.c >>> @@ -388,7 +388,7 @@ static void setup_test_plane(data_t *data, int >>> test_plane) >>>       igt_create_color_fb(data->drm_fd, >>>                   data->mode->hdisplay, data->mode->vdisplay, >>>                   DRM_FORMAT_XRGB8888, >>> -                I915_FORMAT_MOD_X_TILED, >>> +                DRM_FORMAT_MOD_LINEAR, >>>                   0.0, 1.0, 0.0, >>>                   &data->fb_green); >>>   @@ -416,7 +416,7 @@ static void setup_test_plane(data_t *data, int >>> test_plane) >>>           igt_create_color_fb(data->drm_fd, >>>                       white_h, white_v, >>>                       DRM_FORMAT_XRGB8888, >>> -                    I915_FORMAT_MOD_X_TILED, >>> +                    DRM_FORMAT_MOD_LINEAR, >>>                       1.0, 1.0, 1.0, >>>                       &data->fb_white); >>>           break;