From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BAB410E768 for ; Fri, 3 Feb 2023 10:53:38 +0000 (UTC) Message-ID: Date: Fri, 3 Feb 2023 16:23:33 +0530 MIME-Version: 1.0 Content-Language: en-US To: "Hogander, Jouni" , "igt-dev@lists.freedesktop.org" References: <20230202072121.26153-1-swati2.sharma@intel.com> From: Swati Sharma In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [igt-dev] [PATCH i-g-t v2 0/6] Enable VDSC output formats validation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Thanks for the review. Pushed 4/6 patches. On 02-Feb-23 4:22 PM, Hogander, Jouni wrote: > On Thu, 2023-02-02 at 12:51 +0530, Swati Sharma wrote: >> This series is split from >> https://patchwork.freedesktop.org/series/111342/ >> >> Initial dsc lib related changes got merged. Received review >> comments on driver debugfs YCBCR420 changes, to make debugfs >> entry generic so that all supported output formats can be >> validated. >> >> In this series, review comments from above PW are addressed. >> Along, with that changes are done to make test generic to >> validate all supported dsc formats. > > For the whole set: > > Reviewed-by: Jouni Högander > >> >> Swati Sharma (6): >>   lib/dsc: Fix return value >>   tests/i915/kms_dsc: Add plane_format as struct data_t member >>   tests/i915/kms_dsc: Remove pointless struct >>   tests/i915/kms_dsc: Make bpc_list static >>   lib/dsc: Add helpers for VDSC output format debugfs entry >>   tests/i915/kms_dsc: Enable validation for VDSC output formats >> >>  lib/igt_dsc.c               |  56 +++++++++++++++- >>  lib/igt_dsc.h               |   5 ++ >>  lib/igt_kms.c               |  18 +++++ >>  lib/igt_kms.h               |   7 ++ >>  tests/i915/kms_dsc.c        | 128 ++++++++++++++++++++++++++-------- >> -- >>  tests/i915/kms_dsc_helper.c |  40 ++++++++++- >>  tests/i915/kms_dsc_helper.h |   4 ++ >>  7 files changed, 218 insertions(+), 40 deletions(-) >> > -- ~Swati Sharma