From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 35CE210E381 for ; Fri, 20 Jan 2023 17:26:29 +0000 (UTC) Message-ID: Date: Fri, 20 Jan 2023 22:56:17 +0530 MIME-Version: 1.0 Content-Language: en-US To: Kamil Konieczny , igt-dev@lists.freedesktop.org References: <20230120170027.56231-1-kamil.konieczny@linux.intel.com> From: Swati Sharma In-Reply-To: <20230120170027.56231-1-kamil.konieczny@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_fb: add missing include in header List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petri Latvala Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Hi Kamil, Thanks for the patch. Getting following error while build. WARNING: custom_target 'i915-perf-metrics-mtlgt3' has more than one output! Using the first one. Can you check once? On 20-Jan-23 10:30 PM, Kamil Konieczny wrote: > Direct include of lib igt_fb header breaks builds with errors > > xf86drmMode.h:533:2: error: unknown type name ‘uint32_t’ > > Fixed it with adding proper include in header. > > Cc: Swati Sharma > Cc: Petri Latvala > Signed-off-by: Kamil Konieczny > > --- > Maybe it is worth to put this patch as first, together with > https://patchwork.freedesktop.org/series/113045/ > tests/i915/kms_dsc: Reorg > so it can be tested in CI. >> Sure, I'll float the series. > --- > lib/igt_fb.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/igt_fb.h b/lib/igt_fb.h > index 6995b14b..73bdfc86 100644 > --- a/lib/igt_fb.h > +++ b/lib/igt_fb.h > @@ -32,6 +32,7 @@ > #include > #include > #include > +#include > #include > #include > -- ~Swati Sharma