From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_cpu_reloc: Do the can-store-dword check at start
Date: Thu, 31 Jan 2019 09:41:21 +0000 [thread overview]
Message-ID: <fc751be4-ec4f-3215-83af-449a5779c140@linux.intel.com> (raw)
In-Reply-To: <20190130162128.13067-1-chris@chris-wilson.co.uk>
On 30/01/2019 16:21, Chris Wilson wrote:
> igt doesn't handle skipping from inside igt_fork very gracefully and
> crashes instead of reporting the lack of requirements. One solution
> would be to fix igt, but far easier is to just move the requirement
> checking around to do it before we even fork.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109493
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_cpu_reloc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/i915/gem_cpu_reloc.c b/tests/i915/gem_cpu_reloc.c
> index 48cc7ddc6..470998628 100644
> --- a/tests/i915/gem_cpu_reloc.c
> +++ b/tests/i915/gem_cpu_reloc.c
> @@ -158,9 +158,6 @@ create_tmpl(int i915, struct drm_i915_gem_relocation_entry *reloc)
> struct drm_i915_gem_relocation_entry *reloc);
> void *tmpl;
>
> - /* could use BLT_FILL instead for gen2 */
> - igt_require(gem_can_store_dword(i915, 0));
> -
> if (gen >= 8)
> emit_store_addr = gen8_emit_store_addr;
> else if (gen >= 4)
> @@ -276,6 +273,9 @@ igt_main
> i915 = drm_open_driver(DRIVER_INTEL);
> igt_require_gem(i915);
>
> + /* could use BLT_FILL instead for gen2 */
> + igt_require(gem_can_store_dword(i915, 0));
> +
> igt_fork_hang_detector(i915);
> }
>
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-01-31 9:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 16:21 [igt-dev] [PATCH i-g-t] i915/gem_cpu_reloc: Do the can-store-dword check at start Chris Wilson
2019-01-30 17:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-30 21:33 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-31 9:41 ` Tvrtko Ursulin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc751be4-ec4f-3215-83af-449a5779c140@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox