Re: [i-g-t V2] lib/igt_kms: Format cleanup in DRM mode printing

["Reddy Guddati, Santhosh" <santhosh.reddy.guddati@intel.com>]

Can a macro something like DUMP_MODE_FMT be added "%s %d %d %d %d %d %d 
%d %d %d 0x%x 0x%x %d%s%s%s%s%s%s" which would help to update as required.

#define DUMP_MODE_FMT "%s %d %d %d %d %d %d %d %d %d 0x%x 0x%x 
%d%s%s%s%s%s%s"

On 25-06-2024 09:28, Bhanuprakash Modem wrote:
> While printing the DRM mode, align the style with the
> Kernel logs, so that it would be easy to compare & debug.
> 
> Example:
>   Old:- 2880x1800 60 2880 2928 2960 3040 1800 1803 1809 1906 0xa 0x48 347710
>   New:- 2880x1800: 60 347710 2880 2928 2960 3040 1800 1803 1809 1906 0x48 0xa
> 
> V2:
> - Minor cleanup (Jeevan)
> 
> Cc: Jeevan B <jeevan.b@intel.com>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   lib/igt_kms.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 2e6f44e3c..174bbe6c4 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1144,13 +1144,13 @@ void kmstest_dump_mode(drmModeModeInfo *mode)
>   	const char *stereo = mode_stereo_name(mode);
>   	const char *aspect = mode_picture_aspect_name(mode);
>   
> -	igt_info("  %s %d %d %d %d %d %d %d %d %d 0x%x 0x%x %d%s%s%s%s%s%s\n",
> -		 mode->name, mode->vrefresh,
> +	igt_info("  %s: %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x %s%s%s%s%s%s\n",
> +		 mode->name, mode->vrefresh, mode->clock,
>   		 mode->hdisplay, mode->hsync_start,
>   		 mode->hsync_end, mode->htotal,
>   		 mode->vdisplay, mode->vsync_start,
>   		 mode->vsync_end, mode->vtotal,
> -		 mode->flags, mode->type, mode->clock,
> +		 mode->type, mode->flags,
>   		 stereo ? " (3D:" : "",
>   		 stereo ? stereo : "", stereo ? ")" : "",
>   		 aspect ? " (PAR:" : "",