From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3FE226E8FC for ; Tue, 19 Nov 2019 10:43:14 +0000 (UTC) From: "Kahola, Mika" Date: Tue, 19 Nov 2019 10:43:11 +0000 Message-ID: References: <20191108155704.31802-1-ville.syrjala@linux.intel.com> <20191108155704.31802-3-ville.syrjala@linux.intel.com> In-Reply-To: <20191108155704.31802-3-ville.syrjala@linux.intel.com> Content-Language: en-US Content-ID: <7823A11E6429E946AAF3FAAD81A13691@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 3/3] lib/igt_kms: Remove fragile display_info debugfs parsing List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "ville.syrjala@linux.intel.com" , "igt-dev@lists.freedesktop.org" List-ID: T24gRnJpLCAyMDE5LTExLTA4IGF0IDE3OjU3ICswMjAwLCBWaWxsZSBTeXJqYWxhIHdyb3RlOgo+ IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g Cj4gUmVseWluZyBvbiB0aGUgc3BlY2lmaWMgbGF5b3V0IG9mIHRoZSBkaXNwbGF5X2luZm8gZGVi dWdmcwo+IGZpbGUgaXMgZnJhZ2lsZS4gQW55IGNoYW5nZSBpbiB0aGUgZmlsZSBsYXlvdXQgd2ls bCBsaWtlbHkKPiByZXN1bHQgaW4gdGVzdCBmYWlsdXJlLiBMZXQncyBqdXN0IGdldCByaWQgb2Yg aXQuCj4gCj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KClJldmlld2VkLWJ5OiBNaWthIEthaG9sYSA8bWlrYS5rYWhvbGFAaW50 ZWwuY29tPgoKPiAtLS0KPiAgbGliL2lndF9rbXMuYyB8IDE0MSAtLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAtLQo+ICBsaWIvaWd0X2ttcy5oIHwgICAx IC0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxNDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2xpYi9pZ3Rfa21zLmMgYi9saWIvaWd0X2ttcy5jCj4gaW5kZXggZTliODBiOWJjYjgxLi43MDk1 ZDgyNTIyNjIgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9rbXMuYwo+ICsrKyBiL2xpYi9pZ3Rfa21z LmMKPiBAQCAtMTUyMCwxNDcgKzE1MjAsNiBAQCB2b2lkIGttc3Rlc3Rfd2FpdF9mb3JfcGFnZWZs aXAoaW50IGZkKQo+ICAJaWd0X2Fzc2VydChkcm1IYW5kbGVFdmVudChmZCwgJmV2Y3R4KSA9PSAw KTsKPiAgfQo+ICAKPiAtc3RhdGljIHZvaWQgZ2V0X3BsYW5lKGNoYXIgKnN0ciwgaW50IHR5cGUs IHN0cnVjdCBrbXN0ZXN0X3BsYW5lCj4gKnBsYW5lKQo+IC17Cj4gLQlpbnQgcmV0Owo+IC0JY2hh ciBidWZbMjU2XTsKPiAtCj4gLQlwbGFuZS0+dHlwZSA9IHR5cGU7Cj4gLQlyZXQgPSBzc2NhbmYo c3RyICsgMTIsICIlZCUqYyAlKnMgJVtebl1zIiwKPiAtCQkgICAgICZwbGFuZS0+aWQsCj4gLQkJ ICAgICBidWYpOwo+IC0JaWd0X2Fzc2VydF9lcShyZXQsIDIpOwo+IC0KPiAtCXJldCA9IHNzY2Fu ZihidWYgKyA5LCAiJTRkJSpjJTRkJSpjIiwgJnBsYW5lLT5wb3NfeCwgJnBsYW5lLQo+ID5wb3Nf eSk7Cj4gLQlpZ3RfYXNzZXJ0X2VxKHJldCwgMik7Cj4gLQo+IC0JcmV0ID0gc3NjYW5mKGJ1ZiAr IDMwLCAiJTRkJSpjJTRkJSpjIiwgJnBsYW5lLT53aWR0aCwgJnBsYW5lLQo+ID5oZWlnaHQpOwo+ IC0JaWd0X2Fzc2VydF9lcShyZXQsIDIpOwo+IC19Cj4gLQo+IC1zdGF0aWMgaW50IHBhcnNlX3Bs YW5lcyhGSUxFICpmaWQsIHN0cnVjdCBrbXN0ZXN0X3BsYW5lICpwbGFuZXMpCj4gLXsKPiAtCWNo YXIgdG1wWzI1Nl07Cj4gLQlpbnQgbl9wbGFuZXM7Cj4gLQo+IC0Jbl9wbGFuZXMgPSAwOwo+IC0J d2hpbGUgKGZnZXRzKHRtcCwgMjU2LCBmaWQpICE9IE5VTEwpIHsKPiAtCQlpZiAoc3Ryc3RyKHRt cCwgInR5cGU9UFJJIikgIT0gTlVMTCkgewo+IC0JCQlpZiAocGxhbmVzKSB7Cj4gLQkJCQlnZXRf cGxhbmUodG1wLCBEUk1fUExBTkVfVFlQRV9QUklNQVJZLAo+ICZwbGFuZXNbbl9wbGFuZXNdKTsK PiAtCQkJCXBsYW5lc1tuX3BsYW5lc10uaW5kZXggPSBuX3BsYW5lczsKPiAtCQkJfQo+IC0JCQlu X3BsYW5lcysrOwo+IC0JCX0gZWxzZSBpZiAoc3Ryc3RyKHRtcCwgInR5cGU9T1ZMIikgIT0gTlVM TCkgewo+IC0JCQlpZiAocGxhbmVzKSB7Cj4gLQkJCQlnZXRfcGxhbmUodG1wLCBEUk1fUExBTkVf VFlQRV9PVkVSTEFZLAo+ICZwbGFuZXNbbl9wbGFuZXNdKTsKPiAtCQkJCXBsYW5lc1tuX3BsYW5l c10uaW5kZXggPSBuX3BsYW5lczsKPiAtCQkJfQo+IC0JCQluX3BsYW5lcysrOwo+IC0JCX0gZWxz ZSBpZiAoc3Ryc3RyKHRtcCwgInR5cGU9Q1VSIikgIT0gTlVMTCkgewo+IC0JCQlpZiAocGxhbmVz KSB7Cj4gLQkJCQlnZXRfcGxhbmUodG1wLCBEUk1fUExBTkVfVFlQRV9DVVJTT1IsCj4gJnBsYW5l c1tuX3BsYW5lc10pOwo+IC0JCQkJcGxhbmVzW25fcGxhbmVzXS5pbmRleCA9IG5fcGxhbmVzOwo+ IC0JCQl9Cj4gLQkJCW5fcGxhbmVzKys7Cj4gLQkJCWJyZWFrOwo+IC0JCX0KPiAtCX0KPiAtCj4g LQlyZXR1cm4gbl9wbGFuZXM7Cj4gLX0KPiAtCj4gLXN0YXRpYyB2b2lkIHBhcnNlX2NydGMoY2hh ciAqaW5mbywgc3RydWN0IGttc3Rlc3RfY3J0YyAqY3J0YykKPiAtewo+IC0JY2hhciBidWZbMjU2 XTsKPiAtCWludCByZXQ7Cj4gLQljaGFyIHBpcGU7Cj4gLQo+IC0JcmV0ID0gc3NjYW5mKGluZm8g KyA0LCAiJWQlKmMgJSpzICVjJSpjICUqcyAlcyUqYyIsCj4gLQkJICAgICAmY3J0Yy0+aWQsICZw aXBlLCBidWYpOwo+IC0JaWd0X2Fzc2VydF9lcShyZXQsIDMpOwo+IC0KPiAtCWNydGMtPnBpcGUg PSBrbXN0ZXN0X3BpcGVfdG9faW5kZXgocGlwZSk7Cj4gLQlpZ3RfYXNzZXJ0KGNydGMtPnBpcGUg Pj0gMCk7Cj4gLQo+IC0JcmV0ID0gc3NjYW5mKGJ1ZiArIDYsICIlZCUqYyVkJSpjIiwKPiAtCQkg ICAgICZjcnRjLT53aWR0aCwgJmNydGMtPmhlaWdodCk7Cj4gLQlpZ3RfYXNzZXJ0X2VxKHJldCwg Mik7Cj4gLX0KPiAtCj4gLXN0YXRpYyB2b2lkIGttc3Rlc3RfZ2V0X2NydGMoaW50IGRldmljZSwg ZW51bSBwaXBlIHBpcGUsIHN0cnVjdAo+IGttc3Rlc3RfY3J0YyAqY3J0YykKPiAtewo+IC0JY2hh ciB0bXBbMjU2XTsKPiAtCUZJTEUgKmZpbGU7Cj4gLQlpbnQgbmNydGM7Cj4gLQlpbnQgbGluZTsK PiAtCWxvbmcgaW50IG47Cj4gLQlpbnQgZmQ7Cj4gLQo+IC0JZmQgPSBpZ3RfZGVidWdmc19vcGVu KGRldmljZSwgImk5MTVfZGlzcGxheV9pbmZvIiwgT19SRE9OTFkpOwo+IC0JZmlsZSA9IGZkb3Bl bihmZCwgInIiKTsKPiAtCWlndF9za2lwX29uKGZpbGUgPT0gTlVMTCk7Cj4gLQo+IC0JbmNydGMg PSAwOwo+IC0JbGluZSA9IDA7Cj4gLQl3aGlsZSAoZmdldHModG1wLCAyNTYsIGZpbGUpICE9IE5V TEwpIHsKPiAtCQlpZiAoKHN0cnN0cih0bXAsICJDUlRDIikgIT0gTlVMTCkgJiYgKGxpbmUgPiAw KSkgewo+IC0JCQlpZiAoc3Ryc3RyKHRtcCwgImFjdGl2ZT15ZXMiKSAhPSBOVUxMKSB7Cj4gLQkJ CQljcnRjLT5hY3RpdmUgPSB0cnVlOwo+IC0JCQkJcGFyc2VfY3J0Yyh0bXAsIGNydGMpOwo+IC0K PiAtCQkJCW4gPSBmdGVsbChmaWxlKTsKPiAtCQkJCWNydGMtPm5fcGxhbmVzID0gcGFyc2VfcGxh bmVzKGZpbGUsCj4gTlVMTCk7Cj4gLQkJCQlpZ3RfYXNzZXJ0X2x0KDAsIGNydGMtPm5fcGxhbmVz KTsKPiAtCQkJCWNydGMtPnBsYW5lcyA9IGNhbGxvYyhjcnRjLT5uX3BsYW5lcywKPiBzaXplb2Yo KmNydGMtPnBsYW5lcykpOwo+IC0JCQkJaWd0X2Fzc2VydF9mKGNydGMtPnBsYW5lcywgIkZhaWxl ZCB0bwo+IGFsbG9jYXRlIG1lbW9yeSBmb3IgJWQgcGxhbmVzXG4iLCBjcnRjLT5uX3BsYW5lcyk7 Cj4gLQo+IC0JCQkJZnNlZWsoZmlsZSwgbiwgU0VFS19TRVQpOwo+IC0JCQkJcGFyc2VfcGxhbmVz KGZpbGUsIGNydGMtPnBsYW5lcyk7Cj4gLQo+IC0JCQkJaWYgKGNydGMtPnBpcGUgIT0gcGlwZSkg ewo+IC0JCQkJCWZyZWUoY3J0Yy0+cGxhbmVzKTsKPiAtCQkJCX0gZWxzZSB7Cj4gLQkJCQkJbmNy dGMrKzsKPiAtCQkJCQlicmVhazsKPiAtCQkJCX0KPiAtCQkJfQo+IC0JCX0KPiAtCj4gLQkJbGlu ZSsrOwo+IC0JfQo+IC0KPiAtCWZjbG9zZShmaWxlKTsKPiAtCWNsb3NlKGZkKTsKPiAtCj4gLQlp Z3RfYXNzZXJ0KG5jcnRjID09IDEpOwo+IC19Cj4gLQo+IC0vKioKPiAtICogaWd0X2Fzc2VydF9w bGFuZV92aXNpYmxlOgo+IC0gKiBAZmQ6IE9wZW5lZCBmaWxlIGRlc2NyaXB0b3IKPiAtICogQHBp cGU6IERpc3BsYXkgcGlwZQo+IC0gKiBAdmlzaWJpbGl0eTogQm9vbGVhbiBwYXJhbWV0ZXIgdG8g dGVzdCBhZ2FpbnN0IHRoZSBwbGFuZSdzCj4gY3VycmVudCB2aXNpYmlsaXR5IHN0YXRlCj4gLSAq Cj4gLSAqIEFzc2VydHMgb25seSBpZiB0aGUgcGxhbmUncyB2aXNpYmlsaXR5IHN0YXRlIG1hdGNo ZXMgdGhlIHN0YXR1cwo+IGJlaW5nIHBhc3NlZCBieSBAdmlzaWJpbGl0eQo+IC0gKi8KPiAtdm9p ZCBpZ3RfYXNzZXJ0X3BsYW5lX3Zpc2libGUoaW50IGZkLCBlbnVtIHBpcGUgcGlwZSwgaW50Cj4g cGxhbmVfaW5kZXgsIGJvb2wgdmlzaWJpbGl0eSkKPiAtewo+IC0Jc3RydWN0IGttc3Rlc3RfY3J0 YyBjcnRjOwo+IC0JYm9vbCB2aXNpYmxlID0gdHJ1ZTsKPiAtCj4gLQlrbXN0ZXN0X2dldF9jcnRj KGZkLCBwaXBlLCAmY3J0Yyk7Cj4gLQo+IC0JaWd0X2Fzc2VydChwbGFuZV9pbmRleCA8IGNydGMu bl9wbGFuZXMpOwo+IC0KPiAtCWlmIChjcnRjLnBsYW5lc1twbGFuZV9pbmRleF0ucG9zX3ggPiBj cnRjLndpZHRoIHx8Cj4gLQkgICAgY3J0Yy5wbGFuZXNbcGxhbmVfaW5kZXhdLnBvc195ID4gY3J0 Yy5oZWlnaHQpCj4gLQkJdmlzaWJsZSA9IGZhbHNlOwo+IC0KPiAtCWZyZWUoY3J0Yy5wbGFuZXMp Owo+IC0JaWd0X2Fzc2VydF9lcSh2aXNpYmxlLCB2aXNpYmlsaXR5KTsKPiAtfQo+IC0KPiAgLyoq Cj4gICAqIGttc19oYXNfdmJsYW5rOgo+ICAgKiBAZmQ6IERSTSBmZAo+IGRpZmYgLS1naXQgYS9s aWIvaWd0X2ttcy5oIGIvbGliL2lndF9rbXMuaAo+IGluZGV4IDcxOTNmOWE1MGVhMi4uM2Y3OTgz OTJmOGEwIDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3Rfa21zLmgKPiArKysgYi9saWIvaWd0X2ttcy5o Cj4gQEAgLTIyOCw3ICsyMjgsNiBAQCB2b2lkICprbXN0ZXN0X2R1bWJfbWFwX2J1ZmZlcihpbnQg ZmQsIHVpbnQzMl90Cj4gaGFuZGxlLCB1aW50NjRfdCBzaXplLAo+ICB2b2lkIGttc3Rlc3RfZHVt Yl9kZXN0cm95KGludCBmZCwgdWludDMyX3QgaGFuZGxlKTsKPiAgdm9pZCBrbXN0ZXN0X3dhaXRf Zm9yX3BhZ2VmbGlwKGludCBmZCk7Cj4gIHVuc2lnbmVkIGludCBrbXN0ZXN0X2dldF92Ymxhbmso aW50IGZkLCBpbnQgcGlwZSwgdW5zaWduZWQgaW50Cj4gZmxhZ3MpOwo+IC12b2lkIGlndF9hc3Nl cnRfcGxhbmVfdmlzaWJsZShpbnQgZmQsIGVudW0gcGlwZSBwaXBlLCBpbnQKPiBwbGFuZV9pbmRl eCwgYm9vbCB2aXNpYmlsaXR5KTsKPiAgCj4gIGJvb2wga21zX2hhc192YmxhbmsoaW50IGZkKTsK PiAgCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1k ZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldg==