Re: [PATCH i-g-t] tests/kms_rotation_crc: Remove verbose debug logging from rotation paths

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Jeevan

On 26-05-2026 01:57 pm, Jeevan B wrote:
> The multiplane rotation tests were emitting per-iteration debug
> output, which can grow logs quickly and hit runner limits.

igt_debug() is zero-cost in normal runs — it only prints when --debug is 
passed. There's no noise reduction benefit in removing it.

Am I missing something here?

>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
>   tests/kms_rotation_crc.c | 17 -----------------
>   1 file changed, 17 deletions(-)
>
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 4a249ed21..4a7bf3f4d 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -470,8 +470,6 @@ static void test_single_case(data_t *data, igt_crtc_t *crtc,
>   	igt_crc_t crc_output;
>   	int ret;
>   
> -	igt_debug("Testing case %i on pipe %s, format %s\n", rect,
> -		  igt_crtc_name(crtc), igt_format_str(format));
>   	prepare_fbs(data, output, plane, rect, format);
>   
>   	igt_plane_set_rotation(plane, data->rotation);
> @@ -918,7 +916,6 @@ static void test_multi_plane_rotation(data_t *data, igt_crtc_t *crtc)
>   	drmModeModeInfo *mode;
>   	bool have_crc; // flag if can use previously logged crc for comparison
>   	igt_crc_t crclog[16] = {}; //4 * 4 rotation crc storage for packed formats
> -	char *str1, *str2; // for debug printouts
>   	int logindex;
>   
>   	static planeconfigs_t planeconfigs[] = {
> @@ -1053,20 +1050,6 @@ static void test_multi_plane_rotation(data_t *data, igt_crtc_t *crtc)
>   						}
>   						igt_pipe_crc_get_for_frame(data->gfx_fd, data->pipe_crc, fliphw, &retcrc_hw);
>   
> -						str1 = igt_crc_to_string(&retcrc_sw);
> -						str2 = igt_crc_to_string(&retcrc_hw);
> -
> -						igt_debug("crc %.8s vs %.8s -- %.4s - %.4s crc buffered:%s rot1 %d rot2 %d\n",
> -							str1, str2,
> -							(char *) &multiplaneformatlist[p[0].formatindex],
> -							(char *) &multiplaneformatlist[p[1].formatindex],
> -							have_crc ? "yes" : " no",
> -							(int[]) {0, 90, 180, 270} [ctz(planeconfigs[i].rotation)],
> -							(int[]) {0, 90, 180, 270} [ctz(planeconfigs[j].rotation)]);
> -
> -						free(str1);
> -						free(str2);
> -
>   						igt_assert_crc_equal(&retcrc_sw, &retcrc_hw);
>   
>   						lastroundjformat = multiplaneformatlist[p[1].formatindex];