Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [i-g-t V4 2/7] tests/intel/kms_pm_backlight: Fix testplan documentation
Date: Fri, 8 Sep 2023 17:59:00 +0530	[thread overview]
Message-ID: <fcb8bdb1-4ade-f25b-976d-7eb1025edcb1@intel.com> (raw)
In-Reply-To: <20230908121756.1850032-1-bhanuprakash.modem@intel.com>

LGTM

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 08-Sep-23 5:47 PM, Bhanuprakash Modem wrote:
> As kms_pm_backlight is moved to display, update the test
> documentation according to the kms testplan kms_test_config.json
> 
> V2, V3: - Fix "Run type"
> 
> Cc: Swati Sharma <swati2.sharma@intel.com>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/intel/kms_pm_backlight.c | 34 +++++++++++++++++++++++++++-------
>   1 file changed, 27 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/intel/kms_pm_backlight.c b/tests/intel/kms_pm_backlight.c
> index 3c73b054b..42aa7cb5d 100644
> --- a/tests/intel/kms_pm_backlight.c
> +++ b/tests/intel/kms_pm_backlight.c
> @@ -37,29 +37,49 @@
>   #include "igt_device.h"
>   #include "igt_device_scan.h"
>   /**
> - * TEST: i915 pm backlight
> + * TEST: kms pm backlight
> + * Category: Display
>    * Description: Basic backlight sysfs test
> - * Feature: backlight
>    *
>    * SUBTEST: bad-brightness
> - * Description: test the bad brightness.
> + * Description: Test the bad brightness.
> + * Driver requirement: i915
> + * Functionality: backlight
> + * Mega feature: Display Power
>    * Run type: FULL
> + * Test category: functionality test
>    *
>    * SUBTEST: basic-brightness
> - * Description: test the basic brightness.
> + * Description: Test the basic brightness.
> + * Driver requirement: i915
> + * Functionality: backlight
> + * Mega feature: Display Power
>    * Run type: BAT
> + * Test category: functionality test
>    *
>    * SUBTEST: fade
> - * Description: test basic fade.
> + * Description: Test basic fade.
> + * Driver requirement: i915
> + * Functionality: backlight
> + * Mega feature: Display Power
>    * Run type: FULL
> + * Test category: functionality test
>    *
>    * SUBTEST: fade-with-dpms
> - * Description: test the fade with DPMS.
> + * Description: Test the fade with DPMS.
> + * Driver requirement: i915
> + * Functionality: dpms, backlight
> + * Mega feature: Display Power
>    * Run type: FULL
> + * Test category: functionality test
>    *
>    * SUBTEST: fade-with-suspend
> - * Description: test the fade with suspend.
> + * Description: Test the fade with suspend.
> + * Driver requirement: i915
> + * Functionality: backlight, suspend
> + * Mega feature: Display Power
>    * Run type: FULL
> + * Test category: functionality test
>    */
>   
>   struct context {

  reply	other threads:[~2023-09-08 12:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07 16:11 [igt-dev] [i-g-t V3 0/7] Separate display PM tests from Core Bhanuprakash Modem
2023-09-07 16:11 ` [igt-dev] [i-g-t V3 1/7] tests/intel/pm: Rename i915_pm_backlight to kms_pm_backlight Bhanuprakash Modem
2023-09-08  8:25   ` Sharma, Swati2
2023-09-07 16:11 ` [igt-dev] [i-g-t V3 2/7] tests/intel/kms_pm_backlight: Fix testplan documentation Bhanuprakash Modem
2023-09-08  8:29   ` Sharma, Swati2
2023-09-08 12:17   ` [igt-dev] [i-g-t V4 " Bhanuprakash Modem
2023-09-08 12:29     ` Sharma, Swati2 [this message]
2023-09-07 16:11 ` [igt-dev] [i-g-t V3 3/7] tests/intel/pm: Rename i915_pm_dc to kms_pm_dc Bhanuprakash Modem
2023-09-08  8:30   ` Sharma, Swati2
2023-09-07 16:11 ` [igt-dev] [i-g-t V3 4/7] tests/intel/kms_pm_dc: Fix testplan documentation Bhanuprakash Modem
2023-09-07 16:11 ` [igt-dev] [i-g-t V3 5/7] tests/intel/pm: Rename i915_pm_lpsp to kms_pm_lpsp Bhanuprakash Modem
2023-09-08  8:32   ` Sharma, Swati2
2023-09-07 16:11 ` [igt-dev] [i-g-t V3 6/7] tests/intel/kms_pm_lpsp: Fix testplan documentation Bhanuprakash Modem
2023-09-07 16:11 ` [igt-dev] [i-g-t V3 7/7] tests/intel/pm: Separate display specific tests from i915_pm_rpm Bhanuprakash Modem
2023-09-08  8:42   ` Sharma, Swati2
2023-09-07 18:38 ` [igt-dev] ✓ Fi.CI.BAT: success for Separate display PM tests from Core (rev3) Patchwork
2023-09-07 19:17 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-09-07 20:52 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcb8bdb1-4ade-f25b-976d-7eb1025edcb1@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox