Re: [PATCH v5 10/10] tests/intel/xe_err_injection: add CRI GPU requirement check

["Purkait, Soham" <soham.purkait@intel.com>]

Hi Ravi,

On 14-10-2026 00:36, Ravi Kishore Koppuravuri wrote:
> Add support to verify the CRI GPU and skips test gracefully
> on non-cri platforms
>
> Cc: Soham Purkait <soham.purkait@intel.com>
> Cc: Riana Tauro <riana.tauro@intel.com>
> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
> Cc: Raag Jadav <raag.jadav@intel.com>
> Cc: Badal Nilawar <badal.nilawar@intel.com>
> Cc: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> Cc: Harish Chegondi <harish.chegondi@intel.com>
> Signed-off-by: Ravi Kishore Koppuravuri <ravi.kishore.koppuravuri@intel.com>
> ---
> v5: Renamed the CRI GPU check function
> ---
>   tests/intel/xe_err_injection.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/tests/intel/xe_err_injection.c b/tests/intel/xe_err_injection.c
> index 796b4d696..46d9f7f42 100644
> --- a/tests/intel/xe_err_injection.c
> +++ b/tests/intel/xe_err_injection.c
> @@ -20,6 +20,7 @@
>   
>   #include "igt.h"
>   #include "lib/igt_drm_ras_nl.h"
> +#include "lib/intel_chipset.h"
>   #include "lib/intel_reg.h"
>   #include "lib/intel_compute.h"
>   
> @@ -597,6 +598,14 @@ static void test_l2_bank_single_corr_err_injection(struct xe_mmio *mmio, int fd)
>   	CLEANUP_ON_ERROR(ctx, fw_handle);
>   }
>   
> +static void require_cri_gpu(int fd)
> +{
> +	uint16_t dev_id = xe_dev_id(fd);
> +
> +	igt_require_f(IS_CRESCENTISLAND(dev_id),
> +		      "This test requires CRI GPU, but found device ID 0x%04x\n", dev_id);
> +}
> +
>   enum xe_err_injection_type {
>   	XE_ERR_INJ_GT_UC_WKR_CMD_PARITY,
>   	XE_ERR_INJ_GT_UC_WKR_CMD_PARITY_POST_RECOVERY_WL,
> @@ -647,6 +656,11 @@ int igt_main()
>   		fd = drm_open_driver(DRIVER_XE);
>   		igt_require_f(igt_debugfs_exists(fd, "forcewake_all", O_RDONLY),
>   			      "forcewake_all is not available in debugfs\n");
> +		require_cri_gpu(fd);
> +		/*
> +		 * TODO: Add firmware query for error injection support.
> +		 * Should check: EOM (End of Manufacturing) status and error injection jumper state.
> +		 */
>   		xe_mmio_access_init(fd, &mmio);
>   		igt_require_f(xe_mmio_is_initialized(&mmio),
>   			      "Failed to initialize Xe MMIO access\n");
LGTM
Reviewed-by: Soham Purkait <soham.purkait@intel.com>

Regards,
Soham