From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3617E6E3AB for ; Thu, 7 Feb 2019 12:29:35 +0000 (UTC) References: <20190207092136.10659-1-maarten.lankhorst@linux.intel.com> <20190207092136.10659-3-maarten.lankhorst@linux.intel.com> From: Juha-Pekka Heikkila Message-ID: Date: Thu, 7 Feb 2019 14:29:22 +0200 MIME-Version: 1.0 In-Reply-To: <20190207092136.10659-3-maarten.lankhorst@linux.intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH v2 3/4] lib/igt_fb: Add support for Y21x formats as well, v2. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: juhapekka.heikkila@gmail.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maarten Lankhorst , igt-dev@lists.freedesktop.org List-ID: UmV2aWV3ZWQtYnk6IEp1aGEtUGVra2EgSGVpa2tpbGEgPGp1aGFwZWtrYS5oZWlra2lsYUBnbWFp bC5jb20+CgpPbiA3LjIuMjAxOSAxMS4yMSwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gVGhv c2UgZm9ybWF0cyBhcmUgcGFja2VkIGxpa2UgWVVZViwgYnV0IG9ubHkgMTYgYml0cyBwZXIgY29t cG9uZW50Lgo+IAo+IENoYW5nZXMgc2luY2UgdjE6Cj4gLSBSZWJhc2Ugb24gdG9wIG9mIHVwc3Ry ZWFtIFlVViBjaGFuZ2VzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxt YWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gICBpbmNsdWRlL2RybS11 YXBpL2RybV9mb3VyY2MuaCB8ICA2ICsrKystCj4gICBsaWIvaWd0X2NvbG9yX2VuY29kaW5nLmMg ICAgICB8ICAzICsrKwo+ICAgbGliL2lndF9mYi5jICAgICAgICAgICAgICAgICAgfCA0NiArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICAgMyBmaWxlcyBjaGFuZ2VkLCA1NCBp bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJt LXVhcGkvZHJtX2ZvdXJjYy5oIGIvaW5jbHVkZS9kcm0tdWFwaS9kcm1fZm91cmNjLmgKPiBpbmRl eCBmZTZiNjZlZjE3NTYuLmZmOWVhMDI3NjZlZSAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2RybS11 YXBpL2RybV9mb3VyY2MuaAo+ICsrKyBiL2luY2x1ZGUvZHJtLXVhcGkvZHJtX2ZvdXJjYy5oCj4g QEAgLTE0OSwxMCArMTQ5LDE0IEBAIGV4dGVybiAiQyIgewo+ICAgI2RlZmluZSBEUk1fRk9STUFU X1lWWVUJCWZvdXJjY19jb2RlKCdZJywgJ1YnLCAnWScsICdVJykgLyogWzMxOjBdIENiMDpZMTpD cjA6WTAgODo4Ojg6OCBsaXR0bGUgZW5kaWFuICovCj4gICAjZGVmaW5lIERSTV9GT1JNQVRfVVlW WQkJZm91cmNjX2NvZGUoJ1UnLCAnWScsICdWJywgJ1knKSAvKiBbMzE6MF0gWTE6Q3IwOlkwOkNi MCA4Ojg6ODo4IGxpdHRsZSBlbmRpYW4gKi8KPiAgICNkZWZpbmUgRFJNX0ZPUk1BVF9WWVVZCQlm b3VyY2NfY29kZSgnVicsICdZJywgJ1UnLCAnWScpIC8qIFszMTowXSBZMTpDYjA6WTA6Q3IwIDg6 ODo4OjggbGl0dGxlIGVuZGlhbiAqLwo+IC0KPiAgICNkZWZpbmUgRFJNX0ZPUk1BVF9BWVVWCQlm b3VyY2NfY29kZSgnQScsICdZJywgJ1UnLCAnVicpIC8qIFszMTowXSBBOlk6Q2I6Q3IgODo4Ojg6 OCBsaXR0bGUgZW5kaWFuICovCj4gICAjZGVmaW5lIERSTV9GT1JNQVRfWFlVVjg4ODgJCWZvdXJj Y19jb2RlKCdYJywgJ1knLCAnVScsICdWJykgLyogWzMxOjBdIFg6WTpDYjpDciA4Ojg6ODo4IGxp dHRsZSBlbmRpYW4gKi8KPiAgIAo+ICsvKiBMaWtlIFlVWVYsIGJ1dCAxNiBicGMsIGxvd2VzdCBi aXRzIHVudXNlZCBsaWtlIGluIERSTV9GT1JNQVRfUDAxWCAqLwo+ICsjZGVmaW5lIERSTV9GT1JN QVRfWTIxMAkJZm91cmNjX2NvZGUoJ1knLCAnMicsICcxJywgJzAnKQo+ICsjZGVmaW5lIERSTV9G T1JNQVRfWTIxMgkJZm91cmNjX2NvZGUoJ1knLCAnMicsICcxJywgJzInKQo+ICsjZGVmaW5lIERS TV9GT1JNQVRfWTIxNgkJZm91cmNjX2NvZGUoJ1knLCAnMicsICcxJywgJzYnKQo+ICsKPiAgIC8q Cj4gICAgKiBwYWNrZWQgWUNiQ3I0MjAgMngyIHRpbGVkIGZvcm1hdHMKPiAgICAqIGZpcnN0IDY0 IGJpdHMgd2lsbCBjb250YWluIFksQ2IsQ3IgY29tcG9uZW50cyBmb3IgYSAyeDIgdGlsZQo+IGRp ZmYgLS1naXQgYS9saWIvaWd0X2NvbG9yX2VuY29kaW5nLmMgYi9saWIvaWd0X2NvbG9yX2VuY29k aW5nLmMKPiBpbmRleCBiN2ExMmExZTA3ZjcuLjZmODJmY2VjNjJlNCAxMDA2NDQKPiAtLS0gYS9s aWIvaWd0X2NvbG9yX2VuY29kaW5nLmMKPiArKysgYi9saWIvaWd0X2NvbG9yX2VuY29kaW5nLmMK PiBAQCAtMTQ0LDYgKzE0NCw5IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgY29sb3JfZW5jb2Rpbmdf Zm9ybWF0IHsKPiAgIAl7IERSTV9GT1JNQVRfUDAxMCwgNjU0NzIuZiwgNDA5Ni5mLCA2MDE2MC5m LCA0MDk2LmYsIDMyNzY4LmYsIDYxNDQwLmYgfSwKPiAgIAl7IERSTV9GT1JNQVRfUDAxMiwgNjU1 MjAuZiwgNDA5Ni5mLCA2MDE2MC5mLCA0MDk2LmYsIDMyNzY4LmYsIDYxNDQwLmYgfSwKPiAgIAl7 IERSTV9GT1JNQVRfUDAxNiwgNjU1MzUuZiwgNDA5Ni5mLCA2MDE2MC5mLCA0MDk2LmYsIDMyNzY4 LmYsIDYxNDQwLmYgfSwKPiArCXsgRFJNX0ZPUk1BVF9ZMjEwLCA2NTQ3Mi5mLCA0MDk2LmYsIDYw MTYwLmYsIDQwOTYuZiwgMzI3NjguZiwgNjE0NDAuZiB9LAo+ICsJeyBEUk1fRk9STUFUX1kyMTIs IDY1NTIwLmYsIDQwOTYuZiwgNjAxNjAuZiwgNDA5Ni5mLCAzMjc2OC5mLCA2MTQ0MC5mIH0sCj4g Kwl7IERSTV9GT1JNQVRfWTIxNiwgNjU1MzUuZiwgNDA5Ni5mLCA2MDE2MC5mLCA0MDk2LmYsIDMy NzY4LmYsIDYxNDQwLmYgfSwKPiAgIH07Cj4gICAKPiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3QgY29s b3JfZW5jb2RpbmdfZm9ybWF0ICpsb29rdXBfZm91cmNjKHVpbnQzMl90IGZvdXJjYykKPiBkaWZm IC0tZ2l0IGEvbGliL2lndF9mYi5jIGIvbGliL2lndF9mYi5jCj4gaW5kZXggMTI3NjNjYzg1Yzg2 Li5jY2NkNmJiOTgzOTUgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9mYi5jCj4gKysrIGIvbGliL2ln dF9mYi5jCj4gQEAgLTE4NCw2ICsxODQsMjEgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBmb3JtYXRf ZGVzY19zdHJ1Y3Qgewo+ICAgCSAgLm51bV9wbGFuZXMgPSAxLCAucGxhbmVfYnBwID0geyAxNiwg fSwKPiAgIAkgIC5oc3ViID0gMiwgLnZzdWIgPSAxLAo+ICAgCX0sCj4gKwl7IC5uYW1lID0gIlky MTAiLCAuZGVwdGggPSAtMSwgLmRybV9pZCA9IERSTV9GT1JNQVRfWTIxMCwKPiArCSAgLmNhaXJv X2lkID0gQ0FJUk9fRk9STUFUX1JHQjk2RiwKPiArCSAgLm51bV9wbGFuZXMgPSAxLCAucGxhbmVf YnBwID0geyAzMiwgfSwKPiArCSAgLmhzdWIgPSAyLCAudnN1YiA9IDEsCj4gKwl9LAo+ICsJeyAu bmFtZSA9ICJZMjEyIiwgLmRlcHRoID0gLTEsIC5kcm1faWQgPSBEUk1fRk9STUFUX1kyMTIsCj4g KwkgIC5jYWlyb19pZCA9IENBSVJPX0ZPUk1BVF9SR0I5NkYsCj4gKwkgIC5udW1fcGxhbmVzID0g MSwgLnBsYW5lX2JwcCA9IHsgMzIsIH0sCj4gKwkgIC5oc3ViID0gMiwgLnZzdWIgPSAxLAo+ICsJ fSwKPiArCXsgLm5hbWUgPSAiWTIxNiIsIC5kZXB0aCA9IC0xLCAuZHJtX2lkID0gRFJNX0ZPUk1B VF9ZMjE2LAo+ICsJICAuY2Fpcm9faWQgPSBDQUlST19GT1JNQVRfUkdCOTZGLAo+ICsJICAubnVt X3BsYW5lcyA9IDEsIC5wbGFuZV9icHAgPSB7IDMyLCB9LAo+ICsJICAuaHN1YiA9IDIsIC52c3Vi ID0gMSwKPiArCX0sCj4gICAJeyAubmFtZSA9ICJQMDEwIiwgLmRlcHRoID0gLTEsIC5kcm1faWQg PSBEUk1fRk9STUFUX1AwMTAsCj4gICAJICAuY2Fpcm9faWQgPSBDQUlST19GT1JNQVRfUkdCOTZG LAo+ICAgCSAgLm51bV9wbGFuZXMgPSAyLCAucGxhbmVfYnBwID0geyAxNiwgMzIgfSwKPiBAQCAt NTYxLDYgKzU3NiwxNCBAQCBzdGF0aWMgdm9pZCBjbGVhcl95dXZfYnVmZmVyKHN0cnVjdCBpZ3Rf ZmIgKmZiKQo+ICAgCQl3bWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzFdLCAweDgwMDA4MDAwLAo+ ICAgCQkJZmItPnN0cmlkZXNbMV0gKiBmYi0+cGxhbmVfaGVpZ2h0WzFdIC8gc2l6ZW9mKHdjaGFy X3QpKTsKPiAgIAkJYnJlYWs7Cj4gKwljYXNlIERSTV9GT1JNQVRfWTIxMDoKPiArCWNhc2UgRFJN X0ZPUk1BVF9ZMjEyOgo+ICsJY2FzZSBEUk1fRk9STUFUX1kyMTY6Cj4gKwkJd21lbXNldChwdHIg KyBmYi0+b2Zmc2V0c1swXSwKPiArCQkJZnVsbF9yYW5nZSA/IDB4ODAwMDAwMDAgOiAweDgwMDAx MDAwLAo+ICsJCQlmYi0+c3RyaWRlc1swXSAqIGZiLT5wbGFuZV9oZWlnaHRbMF0gLyBzaXplb2Yo d2NoYXJfdCkpOwo+ICsJCWJyZWFrOwo+ICsKPiAgIAl9Cj4gICAKPiAgIAlpZ3RfZmJfdW5tYXBf YnVmZmVyKGZiLCBwdHIpOwo+IEBAIC0xNjUyLDYgKzE2NzUsOSBAQCBzdGF0aWMgdm9pZCBnZXRf eXV2X3BhcmFtZXRlcnMoc3RydWN0IGlndF9mYiAqZmIsIHN0cnVjdCB5dXZfcGFyYW1ldGVycyAq cGFyYW1zKQo+ICAgCWNhc2UgRFJNX0ZPUk1BVF9ZVllVOgo+ICAgCWNhc2UgRFJNX0ZPUk1BVF9V WVZZOgo+ICAgCWNhc2UgRFJNX0ZPUk1BVF9WWVVZOgo+ICsJY2FzZSBEUk1fRk9STUFUX1kyMTA6 Cj4gKwljYXNlIERSTV9GT1JNQVRfWTIxMjoKPiArCWNhc2UgRFJNX0ZPUk1BVF9ZMjE2Ogo+ICAg CQlwYXJhbXMtPnlfaW5jID0gMjsKPiAgIAkJcGFyYW1zLT51dl9pbmMgPSA0Owo+ICAgCQlicmVh azsKPiBAQCAtMTY3NSw2ICsxNzAxLDkgQEAgc3RhdGljIHZvaWQgZ2V0X3l1dl9wYXJhbWV0ZXJz KHN0cnVjdCBpZ3RfZmIgKmZiLCBzdHJ1Y3QgeXV2X3BhcmFtZXRlcnMgKnBhcmFtcykKPiAgIAlj YXNlIERSTV9GT1JNQVRfWVZZVToKPiAgIAljYXNlIERSTV9GT1JNQVRfVVlWWToKPiAgIAljYXNl IERSTV9GT1JNQVRfVllVWToKPiArCWNhc2UgRFJNX0ZPUk1BVF9ZMjEwOgo+ICsJY2FzZSBEUk1f Rk9STUFUX1kyMTI6Cj4gKwljYXNlIERSTV9GT1JNQVRfWTIxNjoKPiAgIAljYXNlIERSTV9GT1JN QVRfWFlVVjg4ODg6Cj4gICAJCXBhcmFtcy0+eV9zdHJpZGUgPSBmYi0+c3RyaWRlc1swXTsKPiAg IAkJcGFyYW1zLT51dl9zdHJpZGUgPSBmYi0+c3RyaWRlc1swXTsKPiBAQCAtMTcyMCw2ICsxNzQ5 LDE0IEBAIHN0YXRpYyB2b2lkIGdldF95dXZfcGFyYW1ldGVycyhzdHJ1Y3QgaWd0X2ZiICpmYiwg c3RydWN0IHl1dl9wYXJhbWV0ZXJzICpwYXJhbXMpCj4gICAJCXBhcmFtcy0+dl9vZmZzZXQgPSBm Yi0+b2Zmc2V0c1swXTsKPiAgIAkJYnJlYWs7Cj4gICAKPiArCWNhc2UgRFJNX0ZPUk1BVF9ZMjEw Ogo+ICsJY2FzZSBEUk1fRk9STUFUX1kyMTI6Cj4gKwljYXNlIERSTV9GT1JNQVRfWTIxNjoKPiAr CQlwYXJhbXMtPnlfb2Zmc2V0ID0gZmItPm9mZnNldHNbMF07Cj4gKwkJcGFyYW1zLT51X29mZnNl dCA9IGZiLT5vZmZzZXRzWzBdICsgMjsKPiArCQlwYXJhbXMtPnZfb2Zmc2V0ID0gZmItPm9mZnNl dHNbMF0gKyA2Owo+ICsJCWJyZWFrOwo+ICsKPiAgIAljYXNlIERSTV9GT1JNQVRfWFlVVjg4ODg6 Cj4gICAJCXBhcmFtcy0+eV9vZmZzZXQgPSBmYi0+b2Zmc2V0c1swXSArIDE7Cj4gICAJCXBhcmFt cy0+dV9vZmZzZXQgPSBmYi0+b2Zmc2V0c1swXSArIDI7Cj4gQEAgLTIxMjEsNiArMjE1OCw5IEBA IHN0YXRpYyB2b2lkIGZiX2NvbnZlcnQoc3RydWN0IGZiX2NvbnZlcnQgKmN2dCkKPiAgIAkJY2Fz ZSBEUk1fRk9STUFUX1AwMTA6Cj4gICAJCWNhc2UgRFJNX0ZPUk1BVF9QMDEyOgo+ICAgCQljYXNl IERSTV9GT1JNQVRfUDAxNjoKPiArCQljYXNlIERSTV9GT1JNQVRfWTIxMDoKPiArCQljYXNlIERS TV9GT1JNQVRfWTIxMjoKPiArCQljYXNlIERSTV9GT1JNQVRfWTIxNjoKPiAgIAkJCWNvbnZlcnRf eXV2MTZfdG9fZmxvYXQoY3Z0KTsKPiAgIAkJCXJldHVybjsKPiAgIAkJfQo+IEBAIC0yMTI5LDYg KzIxNjksOSBAQCBzdGF0aWMgdm9pZCBmYl9jb252ZXJ0KHN0cnVjdCBmYl9jb252ZXJ0ICpjdnQp Cj4gICAJCWNhc2UgRFJNX0ZPUk1BVF9QMDEwOgo+ICAgCQljYXNlIERSTV9GT1JNQVRfUDAxMjoK PiAgIAkJY2FzZSBEUk1fRk9STUFUX1AwMTY6Cj4gKwkJY2FzZSBEUk1fRk9STUFUX1kyMTA6Cj4g KwkJY2FzZSBEUk1fRk9STUFUX1kyMTI6Cj4gKwkJY2FzZSBEUk1fRk9STUFUX1kyMTY6Cj4gICAJ CQljb252ZXJ0X2Zsb2F0X3RvX3l1djE2KGN2dCk7Cj4gICAJCQlyZXR1cm47Cj4gICAJCX0KPiBA QCAtMjUxOCw2ICsyNTYxLDkgQEAgYm9vbCBpZ3RfZm9ybWF0X2lzX3l1dih1aW50MzJfdCBkcm1f Zm9ybWF0KQo+ICAgCWNhc2UgRFJNX0ZPUk1BVF9QMDEwOgo+ICAgCWNhc2UgRFJNX0ZPUk1BVF9Q MDEyOgo+ICAgCWNhc2UgRFJNX0ZPUk1BVF9QMDE2Ogo+ICsJY2FzZSBEUk1fRk9STUFUX1kyMTA6 Cj4gKwljYXNlIERSTV9GT1JNQVRfWTIxMjoKPiArCWNhc2UgRFJNX0ZPUk1BVF9ZMjE2Ogo+ICAg CWNhc2UgRFJNX0ZPUk1BVF9ZVVlWOgo+ICAgCWNhc2UgRFJNX0ZPUk1BVF9ZVllVOgo+ICAgCWNh c2UgRFJNX0ZPUk1BVF9VWVZZOgo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p Z3QtZGV2Cg==