From: "Joshi, Kunal1" <kunal1.joshi@intel.com>
To: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [i-g-t,2/2] tests/intel/kms_dirtyfb: Fix DRRS status check
Date: Tue, 27 Feb 2024 19:24:08 +0530 [thread overview]
Message-ID: <fda36966-c282-45f2-9cfc-722ed51eec0e@intel.com> (raw)
In-Reply-To: <20240221112341.2329405-2-bhanuprakash.modem@intel.com>
On 2/21/2024 4:53 PM, Bhanuprakash Modem wrote:
> Fix assertion check for DRRS status.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Both patch LGTM
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
> tests/intel/kms_dirtyfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
> index 26b82e50a..0e315bfb4 100644
> --- a/tests/intel/kms_dirtyfb.c
> +++ b/tests/intel/kms_dirtyfb.c
> @@ -154,7 +154,7 @@ static void check_feature(data_t *data)
> "PSR still disabled\n");
> break;
> case FEATURE_DRRS:
> - igt_assert_f(intel_is_drrs_inactive(data->drm_fd, data->pipe),
> + igt_assert_f(!intel_is_drrs_inactive(data->drm_fd, data->pipe),
> "DRRS INACTIVE\n");
> break;
> case FEATURE_DEFAULT:
next prev parent reply other threads:[~2024-02-27 13:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 11:23 [PATCH i-g-t 1/2] lib/i915/intel_drrs: Update DRRS capability check Bhanuprakash Modem
2024-02-21 11:23 ` [PATCH i-g-t 2/2] tests/intel/kms_dirtyfb: Fix DRRS status check Bhanuprakash Modem
2024-02-27 13:54 ` Joshi, Kunal1 [this message]
2024-02-21 11:59 ` ✓ CI.xeBAT: success for series starting with [i-g-t,1/2] lib/i915/intel_drrs: Update DRRS capability check Patchwork
2024-02-21 12:19 ` ✓ Fi.CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fda36966-c282-45f2-9cfc-722ed51eec0e@intel.com \
--to=kunal1.joshi@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox