Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Pranay Samala <pranay.samala@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <karthik.b.s@intel.com>, <sameer.lattannavar@intel.com>
Subject: Re: [PATCH i-g-t] tests/kms_atomic_transition: Add newline to assert message
Date: Wed, 6 May 2026 17:10:48 +0530	[thread overview]
Message-ID: <fdb79c2f-b20b-492d-9cd8-0ea89418ec89@intel.com> (raw)
In-Reply-To: <20260506090426.62298-1-pranay.samala@intel.com>


On 06-05-2026 02:34 pm, Pranay Samala wrote:
> Add missing trailing newline to igt_assert_f() error message.
Patch LGTM

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

>
> Signed-off-by: Pranay Samala <pranay.samala@intel.com>
> ---
>   tests/kms_atomic_transition.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
> index 431508a83..58cadc560 100644
> --- a/tests/kms_atomic_transition.c
> +++ b/tests/kms_atomic_transition.c
> @@ -439,7 +439,7 @@ static void setup_parms(data_t *data, igt_crtc_t *crtc,
>   		if (cursor_width == sprite_width &&
>   		    cursor_height == sprite_height) {
>   			igt_plane_t *removed_plane = NULL;
> -			igt_assert_f(n_planes >= 3, "No planes left to proceed with!");
> +			igt_assert_f(n_planes >= 3, "No planes left to proceed with!\n");
>   			if (n_overlays > 0) {
>   				uint32_t plane_to_remove = hars_petruska_f54_1_random_unsafe_max(n_overlays);
>   				removed_plane = &crtc->planes[overlays[plane_to_remove]];

  reply	other threads:[~2026-05-06 11:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06  9:04 [PATCH i-g-t] tests/kms_atomic_transition: Add newline to assert message Pranay Samala
2026-05-06 11:40 ` Sharma, Swati2 [this message]
2026-05-06 12:29 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-05-06 12:32 ` ✓ i915.CI.BAT: " Patchwork
2026-05-06 13:49 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-05-06 17:48 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdb79c2f-b20b-492d-9cd8-0ea89418ec89@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.b.s@intel.com \
    --cc=pranay.samala@intel.com \
    --cc=sameer.lattannavar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox