Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Anirban, Sk" <sk.anirban@intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	<igt-dev@lists.freedesktop.org>, <anshuman.gupta@intel.com>,
	<badal.nilawar@intel.com>, <riana.tauro@intel.com>,
	<karthik.poosa@intel.com>, <raag.jadav@intel.com>,
	<soham.purkait@intel.com>,  <mallesh.koujalagi@intel.com>
Subject: Re: [PATCH 1/2] tests/intel/xe_survivability: update ignored dmesg regex
Date: Tue, 14 Jul 2026 23:15:58 +0530	[thread overview]
Message-ID: <fde84a97-4eb8-4d17-baab-596b35ea628f@intel.com> (raw)
In-Reply-To: <20260714111010.ql7aaowfcyaicf35@kamilkon-DESK.igk.intel.com>

Hi

On 14-07-2026 04:40 pm, Kamil Konieczny wrote:
> Hi Anirban,,
> On 2026-07-13 at 22:59:04 +0530, Anirban, Sk wrote:
>> Hi,
>>
>> On 09-07-2026 08:42 pm, Kamil Konieczny wrote:
>>> Hi Sk,
>>> On 2026-07-09 at 12:39:07 +0530, Sk Anirban wrote:
>>>> The kernel now reports -ENOTRECOVERABLE when the device is wedged.
>>>> As runtime-survivability deliberately wedges the device, update
>>>> dmesg regex so igt_runner does not treat the expected error logs
>>>> as failures.
>>>>
>>>> kernel implementation:
>>>> https://patchwork.freedesktop.org/series/168780/
>>>>
>>>> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
>>>> ---
>>>>    tests/intel/xe_survivability.c | 7 ++++---
>>>>    1 file changed, 4 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/tests/intel/xe_survivability.c b/tests/intel/xe_survivability.c
>>>> index 74488bbea..cc54b37ad 100644
>>>> --- a/tests/intel/xe_survivability.c
>>>> +++ b/tests/intel/xe_survivability.c
>>>> @@ -43,12 +43,13 @@ static char bus_addr[NAME_MAX];
>>>>    static void ignore_wedged_in_dmesg(void)
>>>>    {
>>>>    	/* this is needed for igt_runner so it will ignore it */
>>>> -	igt_emit_ignore_dmesg_regex("GT[0-9A-Fa-f]*: failed to enable GuC scheduling policies: -ECANCELED"
>>> Please keep old value for some time (a year?).
>> As kernel changes are merged, we may no longer receive the same error code
>> (ECANCELED) in wedge scenarios.
>> Additionally, if there are any gaps in the kernel patches that still result
>> in ECANCELED being returned, we won't be able to detect that issue using IGT
>> if we keep the old error codes here.
> Hmm, up to you but it could make testing for older kernels hard,
> e.g. those which will not backport kernel changes yet. So up to
> you, both this on one below is acceptable.
Got your point, I will fix that in next rev.
>
>>>> +	igt_emit_ignore_dmesg_regex("GT[0-9A-Fa-f]*: failed to enable GuC scheduling policies: -ENOTRECOVERABLE"
>>>>    				    "|CRITICAL: Xe has declared device [0-9A-Fa-f:.]* as wedged"
>>>> -				    "|GT[0-9A-Fa-f]*: reset failed .-ECANCELED"
>>>> +				    "|GT[0-9A-Fa-f]*: reset failed .-ENOTRECOVERABLE"
>>> Same here, keep both.
>>>
>>>>    				    "|GT[0-9A-Fa-f]*: Failed to submit"
>>>>    				    "|Modules linked in:"
>>>> -				    "|__pfx___drm_");
>>>> +				    "|__pfx___drm_"
>>>> +				    "|-ENOTRECOVERABLE");
>>> Do not add such, it could made to ignore errors in unrelated context.
>> ENOTRECOVERABLE is intended to be returned only for wedged-state scenarios
>> by the kernel. I think the test should ignore any failures that return this
>> error code.
> The problem is that this regex is applied to kernel error and
> you do not know if it will be dropped from other contexts,
> outside of your test. So it is better to make sure it was from
> xe driver. As it is now it is too generic.
>
> Regards,
> Kamil

Sure, in that case, I will also add a few error messages that were 
observed recently for the second revision.

Thanks,
Anirban

>
>> Thanks
>> Anirban
>>
>>> Regards,
>>> Kamil
>>>
>>>>    }
>>>>    static bool check_survivability_mode_sysfs(void)
>>>> -- 
>>>> 2.43.0
>>>>

  reply	other threads:[~2026-07-14 17:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  7:09 [PATCH 0/2] tests/intel/xe_survivability: update ignored dmesg regex Sk Anirban
2026-07-09  7:09 ` [PATCH 1/2] " Sk Anirban
2026-07-09 15:12   ` Kamil Konieczny
2026-07-13 17:29     ` Anirban, Sk
2026-07-14 11:10       ` Kamil Konieczny
2026-07-14 17:45         ` Anirban, Sk [this message]
2026-07-09  7:09 ` [PATCH 2/2] Add xe_survivability to xe-fast-feedback Sk Anirban
2026-07-09 15:10   ` Kamil Konieczny
2026-07-13  9:54   ` Kamil Konieczny
2026-07-14 20:29     ` Anirban, Sk
2026-07-09 20:15 ` ✗ Xe.CI.BAT: failure for tests/intel/xe_survivability: update ignored dmesg regex Patchwork
2026-07-09 20:41 ` ✓ i915.CI.BAT: success " Patchwork
2026-07-10  2:29 ` ✓ Xe.CI.FULL: " Patchwork
2026-07-10 23:18 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fde84a97-4eb8-4d17-baab-596b35ea628f@intel.com \
    --to=sk.anirban@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=karthik.poosa@intel.com \
    --cc=mallesh.koujalagi@intel.com \
    --cc=raag.jadav@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=soham.purkait@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox