From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 24DF410E591 for ; Wed, 6 Sep 2023 08:07:17 +0000 (UTC) Message-ID: Date: Wed, 6 Sep 2023 13:37:10 +0530 MIME-Version: 1.0 Content-Language: en-US To: Bhanuprakash Modem , igt-dev@lists.freedesktop.org References: <20230905125356.1659246-1-bhanuprakash.modem@intel.com> <20230905125356.1659246-5-bhanuprakash.modem@intel.com> From: "Sharma, Swati2" In-Reply-To: <20230905125356.1659246-5-bhanuprakash.modem@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [i-g-t V2 4/7] tests/intel/kms_pm_dc: Fix testplan documentation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: LGTM Reviewed-by: Swati Sharma On 05-Sep-23 6:23 PM, Bhanuprakash Modem wrote: > As kms_pm_dc is moved to display, update the test documentation > according to the kms testplan kms_test_config.json > > Cc: Swati Sharma > Signed-off-by: Bhanuprakash Modem > --- > tests/intel/kms_pm_dc.c | 66 ++++++++++++++++++++++++++++------------- > 1 file changed, 45 insertions(+), 21 deletions(-) > > diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c > index b5b38c976..dd810c0c2 100644 > --- a/tests/intel/kms_pm_dc.c > +++ b/tests/intel/kms_pm_dc.c > @@ -19,45 +19,69 @@ > #include "time.h" > #include "igt_pm.h" > /** > - * TEST: i915 pm dc > + * TEST: kms pm dc > + * Category: Display > * Description: Tests to validate display power DC states. > - * Run type: FULL > * > * SUBTEST: dc3co-vpb-simulation > - * Description: > - * In this test we make sure that system enters DC3CO when PSR2 is active and system is in SLEEP > - * state > - * Feature: dc3co, pm_dc > + * Description: Make sure that system enters DC3CO when PSR2 is active and system > + * is in SLEEP state > + * Driver requirement: i915 > + * Functionality: dc3co, pm_dc, psr2 > + * Mega feature: Display Power > + * Run type: FULL > + * Test category: functionality test > * > * SUBTEST: dc5-dpms > - * Description: > - * This test validates display engine entry to DC5 state while all connectors's DPMS property > - * set to OFF > - * Feature: pm_dc > + * Description: Validate display engine entry to DC5 state while all connectors's > + * DPMS property set to OFF > + * Driver requirement: i915 > + * Functionality: dpms, pm_dc > + * Mega feature: Display Power > + * Run type: FULL > + * Test category: functionality test > * > * SUBTEST: dc5-dpms-negative > - * Description: > - * This test validates negative scenario of DC5 display engine entry to DC5 state while all > - * connectors's DPMS property set to ON > - * Feature: pm_dc > + * Description: Validate negative scenario of DC5 display engine entry to DC5 state > + * while all connectors's DPMS property set to ON > + * Driver requirement: i915 > + * Functionality: dpms, pm_dc > + * Mega feature: Display Power > + * Run type: FULL > + * Test category: functionality test > * > * SUBTEST: dc5-psr > * Description: This test validates display engine entry to DC5 state while PSR is active > - * Feature: pm_dc > + * Driver requirement: i915 > + * Functionality: pm_dc, psr > + * Mega feature: Display Power > + * Run type: FULL > + * Test category: functionality test > * > * SUBTEST: dc6-dpms > - * Description: > - * This test validates display engine entry to DC6 state while all connectors's DPMS property > - * set to OFF > - * Feature: pm_dc > + * Description: Validate display engine entry to DC6 state while all connectors's > + * DPMS property set to OFF > + * Driver requirement: i915 > + * Functionality: dpms, pm_dc > + * Mega feature: Display Power > + * Run type: FULL > + * Test category: functionality test > * > * SUBTEST: dc6-psr > * Description: This test validates display engine entry to DC6 state while PSR is active > - * Feature: pm_dc > + * Driver requirement: i915 > + * Functionality: pm_dc, psr > + * Mega feature: Display Power > + * Run type: FULL > + * Test category: functionality test > * > * SUBTEST: dc9-dpms > * Description: This test validates display engine entry to DC9 state > - * Feature: pm_dc > + * Driver requirement: i915 > + * Functionality: dpms, pm_dc > + * Mega feature: Display Power > + * Run type: FULL > + * Test category: functionality test > */ > > /* DC State Flags */