RE: [PATCH i-g-t 7/7] tests/kms_writeback: use for_each_connector_mode()

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 09 Apr 2026, "Garg, Nemesa" <nemesa.garg@intel.com> wrote:
>> -----Original Message-----
>> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Jani
>> Nikula
>> Sent: Thursday, April 9, 2026 1:51 AM
>> To: igt-dev@lists.freedesktop.org
>> Cc: Nikula, Jani <jani.nikula@intel.com>
>> Subject: [PATCH i-g-t 7/7] tests/kms_writeback: use
>> for_each_connector_mode()
>> 
>> We have	a helper for looping the output	modes. Use it.
>> 
> Nit: Please remove extra space. With this

Whoops, somehow a bunch of tabs crept in the commit messages. Fixed
while applying.

> Reviewed-by: Nemesa Garg <nemesa.garg@intel.com>

Thanks a lot, pushed.

BR,
Jani.

>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  tests/kms_writeback.c | 10 +++++++---
>>  1 file changed, 7 insertions(+), 3 deletions(-)
>> 
>> diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c index
>> f15abba96765..d189f2f04657 100644
>> --- a/tests/kms_writeback.c
>> +++ b/tests/kms_writeback.c
>> @@ -468,10 +468,14 @@ static igt_output_t
>> *list_writeback_modes(igt_display_t *display)
>>  		igt_output_t *output = &display->outputs[i];
>> 
>>  		if (output->config.connector->connector_type ==
>> DRM_MODE_CONNECTOR_WRITEBACK) {
>> +			drmModeModeInfo *mode;
>> +			int j = 0;
>> +
>>  			igt_info("\tname  vref hdis hss hse htot vdis vss vse
>> vtot flags type clock\n");
>> -			for (int j = 0; j < output->config.connector-
>> >count_modes; j++) {
>> -				igt_info("[%d]", j);
>> -				kmstest_dump_mode(&output-
>> >config.connector->modes[j]);
>> +
>> +			for_each_connector_mode(output, mode) {
>> +				igt_info("[%d]", j++);
>> +				kmstest_dump_mode(mode);
>>  			}
>>  			break;
>>  		}
>> --
>> 2.47.3
>

-- 
Jani Nikula, Intel